-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update app with new branding #2576
Conversation
Just need to test this out on Android next, but having trouble building the app. |
Thanks for helping out with that! I think this is ready for full review and merge then. |
How did you get the screenshots locally with the updated avatars that come from cloudfront? |
Ah, those new avatars are coming from Web-Static changes that we'll deploy alongside all of the app updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, well I think this PR is working as expected 👍
@Dal-Papa all you for the final approval! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
🚀 Deployed to staging in version: 1.0.31-4🚀
|
Looks like iOS deploy failed 😕 |
@shawnborton This is now a deploy blocker, do you have a quick fix or should I revert? |
Yeah, I can provide the missing icon if that helps? |
Yeah, I think we need to provide the missing icon and somehow link it in the PLists. Maybe following this article: https://medium.com/@this.shoaib/missing-required-icon-file-1893c0bedaaf |
Ah, I see exactly what I did wrong. I made icons for iPad at 72x72 instead of 76x76. So should I just send a separate PR that has the three new icons with no QA, etc? Or what is the best way to proceed? Alternatively, I can just supply the new icons to you if that is easier. |
Feel free to submit a new PR, this error is still a bit of a mystery to me |
It looks like it wants 152x152 for iPad |
Here is the follow up PR: #2591 Let me know what I need to do for testing steps, etc. |
Okay, btw @shawnborton I'm going to mark this as No QA, but really it should be |
Sounds good, thanks for helping me out with this one! |
🚀 Deployed to production in version: 1.0.39-5🚀
|
Details
This updates the app with our new logo and colors.
Fixed Issues
N/A
Tests / QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android