[CP Staging] Fix selection list regressions: page animation, scroll indicator, first member highlight, bold text #25921

thiagobrez · 2023-08-25T10:25:35Z

Details

Fixes part of the regressions found in SelectionList, enumerated here: https://expensify.slack.com/archives/C01GTK53T8Q/p1692920321478729

More context:
https://expensify.slack.com/archives/C01GTK53T8Q/p1692952886670059

Fixed Issues

$ #25860
$ #25879
$ #25890
$ #25896

PROPOSAL:

Tests

Verify that no errors appear in the JS console

In Profile -> Personal Details -> Date of birth -> Year:

Page opening should be animated
List should show scroll indicator
Initially focused item should be the year that was selected

In Profile -> Timezone:

Page opening should be animated
List should show scroll indicator
Initially focused item should be the timezone that was selected

In Profile -> Pronouns:

Page opening should be animated
Initially focused item should be the pronoun that was selected

In Workspace -> Members:

Page opening should be animated
List should show scroll indicator
There should be no initially focused item, only after pressing UP or DOWN arrow keys
All members should have BOLD name, even if unselected

In Workspace -> Members -> Invite:

Page opening should be animated
List should show scroll indicator
There should be no initially focused item, only after pressing UP or DOWN arrow keys
All members should have BOLD name, even if unselected

Offline tests

QA Steps

Verify that no errors appear in the JS console

In Profile -> Personal Details -> Date of birth -> Year:

Page opening should be animated
List should show scroll indicator
Initially focused item should be the year that was selected

In Profile -> Timezone:

Page opening should be animated
List should show scroll indicator
Initially focused item should be the timezone that was selected

In Profile -> Pronouns:

Page opening should be animated
Initially focused item should be the pronoun that was selected

In Workspace -> Members:

Page opening should be animated
List should show scroll indicator
There should be no initially focused item, only after pressing UP or DOWN arrow keys
All members should have BOLD name, even if unselected

In Workspace -> Members -> Invite:

Page opening should be animated
List should show scroll indicator
There should be no initially focused item, only after pressing UP or DOWN arrow keys
All members should have BOLD name, even if unselected

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

android.web.mov

Mobile Web - Safari

ios.web.mp4

Desktop

iOS

ios.native.mp4

Android

Screen.Recording.2023-08-25.at.13.20.58.mov

melvin-bot · 2023-08-25T10:25:41Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…ersPage

Santhosh-Sellavel · 2023-08-25T12:15:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-25.at.5.40.25.PM.mov

Mobile Web - Chrome & Mobile Web - Safari

Screen.Recording.2023-08-25.at.7.38.15.PM.mov

Desktop

DesktopS.mov

iOS & Android

Screen.Recording.2023-08-25.at.6.21.08.PM.mov

Santhosh-Sellavel · 2023-08-25T14:13:26Z

@thiagobrez We don't need a scroll indicator pronouns page?

thiagobrez · 2023-08-25T14:18:00Z

@Santhosh-Sellavel It was not specified which lists were supposed to have it. I thought it was supposed only for long lists (read someone saying this somewhere but can't find it), so I added to the Timezone Page, Year Picker, Workspace Members and Workspace Invite

Santhosh-Sellavel · 2023-08-25T14:27:59Z

The scroll indicator is different color in mWeb iOS

thiagobrez · 2023-08-25T14:47:49Z

@Santhosh-Sellavel Seems like you're on System light mode, but dark mode in the app, so that's expected. The scrollbar is just the default, same as the old implementation

Santhosh-Sellavel · 2023-08-25T14:50:15Z

Yes you are right!

Santhosh-Sellavel

LGTM!
cc: @cristipaval @mountiny

melvin-bot · 2023-08-25T15:01:31Z

Congrats, that’s your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It’s an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

OSBotify · 2023-08-25T15:05:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…egressions-1 [CP Staging] Fix selection list regressions: page animation, scroll indicator, first member highlight, bold text (cherry picked from commit 837020d)

OSBotify · 2023-08-25T16:00:52Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.57-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-29T00:06:21Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.57-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:56:48Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.59-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:57:06Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

thiagobrez added 3 commits August 25, 2023 11:21

fix(selection-list): bold text even if unselected

fddb5cd

fix(selection-list): dont auto focus first item

64e3dbe

fix(selection-list): page animation and scroll indicator

af6fe92

thiagobrez requested a review from a team as a code owner August 25, 2023 10:25

melvin-bot bot requested review from eVoloshchak and removed request for a team August 25, 2023 10:25

thiagobrez added 3 commits August 25, 2023 11:36

fix(selection-list): fix lint

ff64ee9

fix(selection-list): remove initiallyFocusedOption from WorkspaceMemb…

831a6c7

…ersPage

fix(selection-list): render pronouns after load

19aaf95

cristipaval requested review from Santhosh-Sellavel and removed request for eVoloshchak August 25, 2023 11:12

thiagobrez added 2 commits August 25, 2023 12:23

fix(selection-list): render pronouns after load

86ebe93

fix(selection-list): fix lint

d3e862a

mountiny assigned thiagobrez Aug 25, 2023

mountiny changed the title ~~Fix selection list regressions: page animation, scroll indicator, first member highlight, bold text~~ [CP Staging] Fix selection list regressions: page animation, scroll indicator, first member highlight, bold text Aug 25, 2023

thiagobrez mentioned this pull request Aug 25, 2023

[HOLD for payment 2023-09-06] [$1000] No animation for Members and Invite Members page #25860

Closed

6 tasks

Santhosh-Sellavel approved these changes Aug 25, 2023

View reviewed changes

melvin-bot bot requested a review from NikkiWines August 25, 2023 14:51

cristipaval approved these changes Aug 25, 2023

View reviewed changes

cristipaval merged commit 837020d into Expensify:main Aug 25, 2023

OSBotify mentioned this pull request Aug 26, 2023

Deploy Checklist: New Expensify 2023-08-24 #25813

Closed

73 tasks

dummy-1111 mentioned this pull request Aug 28, 2023

[HOLD for payment 2023-09-20] Web - Profile - Pronouns Displayed Without Performing Search #26074

Closed

6 tasks

OSBotify mentioned this pull request Aug 30, 2023

Deploy Checklist: New Expensify 2023-08-30 #26268

Closed

thiagobrez mentioned this pull request Sep 5, 2023

[HOLD #11795][$1000] No transition animation on timezone selector #24139

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix selection list regressions: page animation, scroll indicator, first member highlight, bold text #25921

[CP Staging] Fix selection list regressions: page animation, scroll indicator, first member highlight, bold text #25921

thiagobrez commented Aug 25, 2023 •

edited

Loading

melvin-bot bot commented Aug 25, 2023

Santhosh-Sellavel commented Aug 25, 2023 •

edited

Loading

Santhosh-Sellavel commented Aug 25, 2023

thiagobrez commented Aug 25, 2023 •

edited

Loading

Santhosh-Sellavel commented Aug 25, 2023

thiagobrez commented Aug 25, 2023 •

edited

Loading

Santhosh-Sellavel commented Aug 25, 2023

Santhosh-Sellavel left a comment

melvin-bot bot commented Aug 25, 2023

OSBotify commented Aug 25, 2023

OSBotify commented Aug 25, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

[CP Staging] Fix selection list regressions: page animation, scroll indicator, first member highlight, bold text #25921

[CP Staging] Fix selection list regressions: page animation, scroll indicator, first member highlight, bold text #25921

Conversation

thiagobrez commented Aug 25, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 25, 2023

Santhosh-Sellavel commented Aug 25, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel commented Aug 25, 2023

thiagobrez commented Aug 25, 2023 • edited Loading

Santhosh-Sellavel commented Aug 25, 2023

thiagobrez commented Aug 25, 2023 • edited Loading

Santhosh-Sellavel commented Aug 25, 2023

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Aug 25, 2023

OSBotify commented Aug 25, 2023

OSBotify commented Aug 25, 2023

OSBotify commented Aug 29, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

thiagobrez commented Aug 25, 2023 •

edited

Loading

Santhosh-Sellavel commented Aug 25, 2023 •

edited

Loading

thiagobrez commented Aug 25, 2023 •

edited

Loading

thiagobrez commented Aug 25, 2023 •

edited

Loading