Don't focus when ref composer is unmounted #25981

rushatgabhane · 2023-08-25T21:48:33Z

Details

Fixed a regression caused by #25758.
cc: @mountiny @mountiny

Fixed Issues

$ https://expensify.slack.com/archives/C049HHMV9SM/p1692991483808169
PROPOSAL: https://expensify.slack.com/archives/C049HHMV9SM/p1692997508379109?thread_ts=1692991483.808169&cid=C049HHMV9SM

Tests

Open a report A, then open report B
Click on the emoji picker from the composer
Click on the browser's back button
Verify that the app doesn't crash

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-26.at.14.39.35.mov

Mobile Web - Chrome

screen-20230828-021327-2023-08-27.20_45_09.248.mp4

Mobile Web - Safari

Screen.Recording.2023-08-28.at.02.11.45.mov

Desktop

Screen.Recording.2023-08-28.at.02.20.50.mov

iOS

Screen.Recording.2023-08-28.at.02.02.49.mov

Android

screen-20230828-031153-2023-08-27.21_43_11.290.mp4

mountiny · 2023-08-27T17:54:29Z

@hannojg

melvin-bot · 2023-08-27T20:48:58Z

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-08-27T21:43:49Z

PR ready for review

hannojg · 2023-08-28T06:00:43Z

LGTM

hannojg · 2023-08-28T06:00:49Z

Lint is failing?

rushatgabhane · 2023-08-28T06:02:45Z

thanks, fixed!

hannojg · 2023-08-28T06:23:44Z

@rushatgabhane Just an idea, so there are two places where composerRef.current.focus gets called. Lets put the call with the if null check in a use callback (calling it focus() or sth), and use that function in both places?

mountiny · 2023-08-28T13:10:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web25981.mp4

Mobile Web - Chrome

N/A

Mobile Web - Safari

25981safari.mp4

Desktop

25981desktop.mp4

iOS

ios25981.mp4

Android

N/A

rushatgabhane · 2023-08-28T13:14:26Z

#25981 (comment)

Nice call! What do you think of using optional chaining everywhere? There's more places where composerRef could be null

rushatgabhane · 2023-08-28T13:15:13Z

Optional chaining is not allowed. RIP

This reverts commit 8433620.

mountiny · 2023-08-28T13:17:58Z

Yeah not until Typescript, can you revert that change please

mountiny

Thanks @rushatgabhane ❤️

rushatgabhane · 2023-08-28T13:21:26Z

@mountiny could you please retest web once.

rushatgabhane · 2023-08-28T13:22:40Z

src/pages/home/report/ReportActionCompose/ReportActionCompose.js

@@ -403,7 +410,7 @@ function ReportActionCompose({
                    {DeviceCapabilities.canUseTouchScreen() && isMediumScreenWidth ? null : (
                        <EmojiPickerButton
                            isDisabled={isBlockedFromConcierge || disabled}
-                            onModalHide={() => composerRef.current.focus(true)}
+                            onModalHide={focus}


@mountiny this might be a noob question, but are these both equivalent?

onModalHide={focus}

onModalHide={() => focus()}

I believe they are equivalent. The first option is passing the function directly as a reference so in theory its slightly more efficient because the second option everytime creates a new inline function that calls the focus function

mountiny · 2023-08-28T13:22:48Z

Works well
https://github.com/Expensify/App/assets/36083550/9862929d-4e2d-41d9-890d-327c1b7b0bf0

mountiny · 2023-08-28T13:26:18Z

@rushatgabhane lint

rushatgabhane · 2023-08-28T13:37:50Z

@mountiny fixed :)

mountiny

Thanks!

Natnael-Guchima · 2023-08-28T13:53:41Z

@mountiny I reported this issue. Can you please add my name as a reporter.

Thanks.

OSBotify · 2023-08-28T13:55:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mountiny · 2023-08-28T13:56:52Z

@Natnael-Guchima we havent created issues for these, can you please take note and I will create one issue with all the valid follow ups found and fixed once this is done and dusted?

Natnael-Guchima · 2023-08-28T14:01:37Z

Sure! I will list all the follow-ups I reported and I will let you know once this is all done and pushed to prod.

OSBotify · 2023-08-28T18:47:56Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:16:59Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:55:18Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.59-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:55:36Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

rushatgabhane added 2 commits August 26, 2023 03:08

don't focus when ref composer is unmounted

c9b0ebc

don't focus when ref composer is unmounted

9a66b0c

mountiny assigned rushatgabhane Aug 27, 2023

mountiny self-requested a review August 27, 2023 17:54

rushatgabhane marked this pull request as ready for review August 27, 2023 20:48

rushatgabhane requested a review from a team as a code owner August 27, 2023 20:48

melvin-bot bot removed the request for review from a team August 27, 2023 20:48

Merge branch 'main' into fix-crash

10f033b

lint

fd7fd0f

use optional chaining

8433620

Revert "use optional chaining"

345485d

This reverts commit 8433620.

mountiny previously approved these changes Aug 28, 2023

View reviewed changes

use focus()

d41c300

rushatgabhane dismissed mountiny’s stale review via d41c300 August 28, 2023 13:19

rushatgabhane added 2 commits August 28, 2023 18:50

fix lint

5fea3ba

prettier

165d635

rushatgabhane commented Aug 28, 2023

View reviewed changes

mountiny mentioned this pull request Aug 28, 2023

Fix: use focusWithDelay #26057

Merged

57 tasks

define func before it's used

ca245d1

mountiny approved these changes Aug 28, 2023

View reviewed changes

mountiny merged commit 165e1b8 into Expensify:main Aug 28, 2023
11 checks passed

OSBotify mentioned this pull request Aug 28, 2023

Deploy Checklist: New Expensify 2023-08-28 #26113

Closed

OSBotify mentioned this pull request Aug 30, 2023

Deploy Checklist: New Expensify 2023-08-30 #26268

Closed

rushatgabhane deleted the fix-crash branch September 20, 2023 08:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't focus when ref composer is unmounted #25981

Don't focus when ref composer is unmounted #25981

rushatgabhane commented Aug 25, 2023 •

edited

Loading

mountiny commented Aug 27, 2023

melvin-bot bot commented Aug 27, 2023

rushatgabhane commented Aug 27, 2023

hannojg commented Aug 28, 2023

hannojg commented Aug 28, 2023

rushatgabhane commented Aug 28, 2023

hannojg commented Aug 28, 2023

mountiny commented Aug 28, 2023 •

edited

Loading

rushatgabhane commented Aug 28, 2023 •

edited

Loading

rushatgabhane commented Aug 28, 2023

mountiny commented Aug 28, 2023

mountiny left a comment •

edited

Loading

rushatgabhane commented Aug 28, 2023

rushatgabhane Aug 28, 2023 •

edited

Loading

mountiny Aug 28, 2023

mountiny commented Aug 28, 2023

mountiny commented Aug 28, 2023

rushatgabhane commented Aug 28, 2023

mountiny left a comment

Natnael-Guchima commented Aug 28, 2023

OSBotify commented Aug 28, 2023

mountiny commented Aug 28, 2023

Natnael-Guchima commented Aug 28, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

Don't focus when ref composer is unmounted #25981

Don't focus when ref composer is unmounted #25981

Conversation

rushatgabhane commented Aug 25, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

mountiny commented Aug 27, 2023

melvin-bot bot commented Aug 27, 2023

rushatgabhane commented Aug 27, 2023

hannojg commented Aug 28, 2023

hannojg commented Aug 28, 2023

rushatgabhane commented Aug 28, 2023

hannojg commented Aug 28, 2023

mountiny commented Aug 28, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane commented Aug 28, 2023 • edited Loading

rushatgabhane commented Aug 28, 2023

mountiny commented Aug 28, 2023

mountiny left a comment • edited Loading

Choose a reason for hiding this comment

rushatgabhane commented Aug 28, 2023

rushatgabhane Aug 28, 2023 • edited Loading

Choose a reason for hiding this comment

mountiny Aug 28, 2023

Choose a reason for hiding this comment

mountiny commented Aug 28, 2023

mountiny commented Aug 28, 2023

rushatgabhane commented Aug 28, 2023

mountiny left a comment

Choose a reason for hiding this comment

Natnael-Guchima commented Aug 28, 2023

OSBotify commented Aug 28, 2023

mountiny commented Aug 28, 2023

Natnael-Guchima commented Aug 28, 2023

OSBotify commented Aug 28, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

rushatgabhane commented Aug 25, 2023 •

edited

Loading

mountiny commented Aug 28, 2023 •

edited

Loading

rushatgabhane commented Aug 28, 2023 •

edited

Loading

mountiny left a comment •

edited

Loading

rushatgabhane Aug 28, 2023 •

edited

Loading