Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed unread message indicator UI #2624

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Apr 29, 2021

Please review.

Details

Fixed -> Hovering over the message hides the new unread message indicator and the context menu remains in hovered stated.

Fixed Issues

Fixes #2541

Tests / QA Steps

  1. Log into expensify.cash on the web or desktop app
  2. Go to a chat with unread messages
  3. Hover over the new message line indicator, the line should be visible behind the context menu.
  4. In the same (new) chat, hover over the Copy function on the context menu.
  5. Slowly move the cursor to another message, the previous message's context menu should be hidden.

Tested On

  • Web
  • Mobile Web (Unaffected)
  • Desktop
  • iOS (Unaffected)
  • Android (Unaffected)

Screenshots

Web / Desktop

line.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner April 29, 2021 06:52
@MelvinBot MelvinBot requested review from johnmlee101 and removed request for a team April 29, 2021 06:53
@parasharrajat
Copy link
Member Author

One thing I noticed that the Context menu is not vertically aligned over the single messages as compared to the grouped messages (message with the user name and avatar) which can be seen in the video above. Let me know if I can fix that in the same PR. 😅

@johnmlee101
Copy link
Contributor

Hi Rajat, if you see a fix that can be made, I'd recommend you follow https://github.com/Expensify/Expensify.cash/blob/master/CONTRIBUTING.md#proposing-a-job-that-expensify-hasnt-posted to propose a new issue! This would include a bonus as per the guidelines!

Copy link
Contributor

@johnmlee101 johnmlee101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the changes.

@johnmlee101 johnmlee101 merged commit e130a97 into Expensify:main Apr 29, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.33-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented May 8, 2021

🚀 Deployed to production in version: 1.0.39-5🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New message indicator disappears, report action menu persists after hover
3 participants