Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: migrate index.js class to function component #26374

Merged
merged 15 commits into from
Oct 2, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,70 +1,69 @@
import React from 'react';
import React, {useCallback, useEffect, useRef} from 'react';
import _ from 'underscore';
import withLocalize from '../../../withLocalize';

import ControlSelection from '../../../../libs/ControlSelection';
import * as DeviceCapabilities from '../../../../libs/DeviceCapabilities';
import htmlRendererPropTypes from '../htmlRendererPropTypes';
import BasePreRenderer from './BasePreRenderer';
import * as DeviceCapabilities from '../../../../libs/DeviceCapabilities';
import ControlSelection from '../../../../libs/ControlSelection';

class PreRenderer extends React.Component {
constructor(props) {
super(props);

this.scrollNode = this.scrollNode.bind(this);
this.debouncedIsScrollingVertically = _.debounce(this.isScrollingVertically.bind(this), 100, true);
}
const isScrollingVertically = (event) =>
// Mark as vertical scrolling only when absolute value of deltaY is more than the double of absolute
// value of deltaX, so user can use trackpad scroll on the code block horizontally at a wide angle.
Math.abs(event.deltaY) > Math.abs(event.deltaX) * 2;

componentDidMount() {
if (!this.ref) {
return;
}
this.ref.getScrollableNode().addEventListener('wheel', this.scrollNode);
}
const debouncedIsScrollingVertically = _.debounce(isScrollingVertically, 100, true);

componentWillUnmount() {
this.ref.getScrollableNode().removeEventListener('wheel', this.scrollNode);
}
function PreRenderer(props) {
const scrollViewRef = useRef();
teneeto marked this conversation as resolved.
Show resolved Hide resolved

/**
* Check if user is scrolling vertically based on deltaX and deltaY. We debounce this
* method in the constructor to make sure it's called only for the first event.
* Checks if user is scrolling vertically based on deltaX and deltaY. We debounce this
* method in order to make sure it's called only for the first event.
* @param {WheelEvent} event Wheel event
* @returns {Boolean} true if user is scrolling vertically
*/
isScrollingVertically(event) {
// Mark as vertical scrolling only when absolute value of deltaY is more than the double of absolute
// value of deltaX, so user can use trackpad scroll on the code block horizontally at a wide angle.
return Math.abs(event.deltaY) > Math.abs(event.deltaX) * 2;
}

/**
* Manually scrolls the code block if code block horizontal scrollable, then prevents the event from being passed up to the parent.
* @param {Object} event native event
*/
scrollNode(event) {
const node = this.ref.getScrollableNode();
const scrollNode = useCallback((event) => {
const node = scrollViewRef.current.getScrollableNode();
const horizontalOverflow = node.scrollWidth > node.offsetWidth;
const isScrollingVertically = this.debouncedIsScrollingVertically(event);
if (event.currentTarget === node && horizontalOverflow && !isScrollingVertically) {
if (event.currentTarget === node && horizontalOverflow && !debouncedIsScrollingVertically(event)) {
node.scrollLeft += event.deltaX;
event.preventDefault();
event.stopPropagation();
}
}
}, []);

useEffect(() => {
const eventListenerRefValue = scrollViewRef.current;
if (!eventListenerRefValue) {
return;
}
eventListenerRefValue.getScrollableNode().addEventListener('wheel', scrollNode);

return () => {
if (!eventListenerRefValue.getScrollableNode()) {
return;
}
eventListenerRefValue.getScrollableNode().removeEventListener('wheel', scrollNode);
};
teneeto marked this conversation as resolved.
Show resolved Hide resolved
teneeto marked this conversation as resolved.
Show resolved Hide resolved
}, [scrollNode]);

render() {
return (
<BasePreRenderer
// eslint-disable-next-line react/jsx-props-no-spreading
{...this.props}
ref={(el) => (this.ref = el)}
onPressIn={() => DeviceCapabilities.canUseTouchScreen() && ControlSelection.block()}
onPressOut={() => ControlSelection.unblock()}
/>
);
}
return (
<BasePreRenderer
// eslint-disable-next-line react/jsx-props-no-spreading
{...props}
ref={scrollViewRef}
onPressIn={() => DeviceCapabilities.canUseTouchScreen() && ControlSelection.block()}
onPressOut={ControlSelection.unblock}
/>
);
}
teneeto marked this conversation as resolved.
Show resolved Hide resolved

PreRenderer.propTypes = htmlRendererPropTypes;
PreRenderer.displayName = 'PreRenderer';

export default withLocalize(PreRenderer);
export default PreRenderer;
Loading