Checking ToS box before filling fields throws error in mweb but not in android app #26699

tamdao · 2023-09-04T17:29:07Z

Details

Fixed Issues

$ #26009
PROPOSAL: #26009 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login
Go to workspaces and select Bank account
Click on connect manually
Check the ToS box
See validation error message

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-06.at.07.58.44.mov

Screen.Recording.2023-09-06.at.07.57.20.mov

Mobile Web - Chrome

Screen.Recording.2023-09-05.at.00.20.52.mov

Mobile Web - Safari

Screen.Recording.2023-09-06.at.08.01.35.mov

Desktop

Screen.Recording.2023-09-06.at.08.07.46.mov

iOS

Screen.Recording.2023-09-06.at.10.05.11.mov

Android

Screen.Recording.2023-09-05.at.00.16.47.mov

…d input is different input

melvin-bot · 2023-09-04T17:29:11Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-09-04T17:32:38Z

@burczu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

burczu · 2023-09-05T08:21:50Z

@tamdao I can't see any testing steps in your PR description - please add it. Also please add screenshots/screen-captures for all the platforms - I know the issue was only on Android but we need a proof that everything is working correctly everywhere. Last but not least - you have to check all the checkboxes in the PR author checklist.

tamdao · 2023-09-05T08:38:13Z

@burczu I have attached the test video for chrome on android and android app. I will add other videos today

tamdao · 2023-09-05T23:12:32Z

@burczu I have some problems with setting up iOS native app on my local and I'm still trying to resolve it. But I also uploaded other test videos

tamdao · 2023-09-06T01:07:52Z

@burczu I have added all the platforms

burczu · 2023-09-06T06:53:42Z

Ok, so what about this:

I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

and this:

If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers

We can't proceed until all the PR author's checkboxes are checked 🤷‍♂️ And you still didn't add any test steps yet...

tamdao · 2023-09-06T06:56:34Z

Ok, so what about this:

I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

and this:

If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers

We can't proceed until all the PR author's checkboxes are checked 🤷‍♂️ And you still didn't add any test steps yet...

Updated. Sorry I forgot that

burczu · 2023-09-06T07:07:41Z

@tamdao Test steps still missing...

tamdao · 2023-09-06T07:13:10Z

@tamdao Test steps still missing...

Updated. :(

burczu · 2023-09-06T07:14:49Z

@tamdao Alright, thanks - all set now. We will wrap this up today.

burczu · 2023-09-06T08:05:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

26699-web.mp4

Mobile Web - Chrome

26699-web-mobile-chrome.mp4

Mobile Web - Safari

26699-web-mobile-safari.mp4

Desktop

26699-desktop.mp4

iOS

26699-ios.mp4

Android

26699-android.mp4

burczu · 2023-09-06T08:09:31Z

@tamdao Actually one more thing... You've added new prop that the Form injects into its inputs - onFocus, so you should document it here: https://github.com/Expensify/App/blob/main/contributingGuides/FORMS.md#props-provided-to-form-inputs

tamdao · 2023-09-06T08:16:59Z

@tamdao Actually one more thing... You've added new prop that the Form injects into its inputs - onFocus, so you should document it here: https://github.com/Expensify/App/blob/main/contributingGuides/FORMS.md#props-provided-to-form-inputs

updated

burczu

Reviewed and tested - I think we are good to go!

OSBotify · 2023-09-08T18:08:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-11T03:48:39Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.67-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-11T23:44:22Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.67-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-12T00:19:04Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.68-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-13T08:45:31Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Add focus logic into form to validate the focused input if the change…

a80707c

…d input is different input

tamdao marked this pull request as ready for review September 4, 2023 17:32

tamdao requested a review from a team as a code owner September 4, 2023 17:32

melvin-bot bot requested review from burczu and removed request for a team September 4, 2023 17:32

tamdao mentioned this pull request Sep 4, 2023

[HOLD for payment 2023-09-18] [$1000] Bank account - Inconsistency bug: Checking ToS box before filling fields throws error in mweb but not in android app #26009

Closed

6 tasks

Update FORMS.md doc to add onFocus

0508ec8

burczu approved these changes Sep 6, 2023

View reviewed changes

melvin-bot bot requested a review from puneetlath September 6, 2023 08:44

puneetlath approved these changes Sep 8, 2023

View reviewed changes

puneetlath merged commit 6e106c6 into Expensify:main Sep 8, 2023
12 checks passed

OSBotify mentioned this pull request Sep 11, 2023

Deploy Checklist: New Expensify 2023-09-11 #27120

Closed

31 tasks

lanitochka17 mentioned this pull request Sep 11, 2023

[HOLD for payment 2023-10-05] [$500] Bank account - Bank account message redirects to an invalid page on browser #27148

Closed

6 tasks

OSBotify mentioned this pull request Sep 12, 2023

Deploy Checklist: New Expensify 2023-09-12 #27210

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Checking ToS box before filling fields throws error in mweb but not in android app #26699

Checking ToS box before filling fields throws error in mweb but not in android app #26699

tamdao commented Sep 4, 2023 •

edited

Loading

melvin-bot bot commented Sep 4, 2023

melvin-bot bot commented Sep 4, 2023

burczu commented Sep 5, 2023

tamdao commented Sep 5, 2023

tamdao commented Sep 5, 2023

tamdao commented Sep 6, 2023

burczu commented Sep 6, 2023 •

edited

Loading

tamdao commented Sep 6, 2023

burczu commented Sep 6, 2023

tamdao commented Sep 6, 2023

burczu commented Sep 6, 2023

burczu commented Sep 6, 2023 •

edited

Loading

burczu commented Sep 6, 2023 •

edited

Loading

tamdao commented Sep 6, 2023

burczu left a comment

OSBotify commented Sep 8, 2023

OSBotify commented Sep 11, 2023

OSBotify commented Sep 11, 2023

OSBotify commented Sep 12, 2023

OSBotify commented Sep 13, 2023

Checking ToS box before filling fields throws error in mweb but not in android app #26699

Checking ToS box before filling fields throws error in mweb but not in android app #26699

Conversation

tamdao commented Sep 4, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 4, 2023

melvin-bot bot commented Sep 4, 2023

burczu commented Sep 5, 2023

tamdao commented Sep 5, 2023

tamdao commented Sep 5, 2023

tamdao commented Sep 6, 2023

burczu commented Sep 6, 2023 • edited Loading

tamdao commented Sep 6, 2023

burczu commented Sep 6, 2023

tamdao commented Sep 6, 2023

burczu commented Sep 6, 2023

burczu commented Sep 6, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

burczu commented Sep 6, 2023 • edited Loading

tamdao commented Sep 6, 2023

burczu left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 8, 2023

OSBotify commented Sep 11, 2023

OSBotify commented Sep 11, 2023

OSBotify commented Sep 12, 2023

OSBotify commented Sep 13, 2023

tamdao commented Sep 4, 2023 •

edited

Loading

burczu commented Sep 6, 2023 •

edited

Loading

burczu commented Sep 6, 2023 •

edited

Loading

burczu commented Sep 6, 2023 •

edited

Loading