Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After deleting an attachment, the LHN shows '[Attachment]' instead of 'No activity yet' until you delete one more message #26850

Merged
merged 4 commits into from
Sep 13, 2023
Merged

After deleting an attachment, the LHN shows '[Attachment]' instead of 'No activity yet' until you delete one more message #26850

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8792382
adding condition
pradeepmdk Sep 6, 2023
00718d8
fix conflicts
pradeepmdk Sep 8, 2023
1850aa8
fix
pradeepmdk Sep 13, 2023
03522c3
make const changes
pradeepmdk Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/libs/isReportMessageAttachment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ type IsReportMessageAttachmentParams = {
* @param reportActionMessage report action's message as text, html and translationKey
*/
export default function isReportMessageAttachment({text, html, translationKey}: IsReportMessageAttachmentParams): boolean {
if (translationKey) {
return translationKey === CONST.TRANSLATION_KEYS.ATTACHMENT;
}

if (!text || !html) {
return false;
}

if (translationKey && text === CONST.ATTACHMENT_MESSAGE_TEXT) {
return translationKey === CONST.TRANSLATION_KEYS.ATTACHMENT;
}

const regex = new RegExp(` ${CONST.ATTACHMENT_SOURCE_ATTRIBUTE}="(.*)"`, 'i');
return text === CONST.ATTACHMENT_MESSAGE_TEXT && (!!html.match(regex) || html === CONST.ATTACHMENT_UPLOADING_MESSAGE_HTML);
}
Loading