Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] [TS migration] Migrate 'NumberUtils.js' lib to TypeScript #26864

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions src/libs/NumberUtils.js → src/libs/NumberUtils.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import _ from 'underscore';
import CONST from '../CONST';

/**
* Generates a random positive 64 bit numeric string by randomly generating the left, middle, and right parts and concatenating them. Used to generate client-side ids.
* @returns {String} string representation of a randomly generated 64 bit signed integer
*
* @returns string representation of a randomly generated 64 bit signed integer
*/
function rand64() {
function rand64(): string {
// Max 64-bit signed:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function rand64(): string {
/**
* Generates a random positive 64 bit numeric string by randomly generating the left, middle, and right parts and concatenating them. Used to generate client-side ids.
* @returns string representation of a randomly generated 64 bit signed integer
*/
function rand64(): string {

We should keep the @returns description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed @fabioh8010 :)

// 9,223,372,036,854,775,807
// The left part of the max 64-bit number *+1* because we're flooring it.
Expand Down Expand Up @@ -38,24 +38,22 @@ function rand64() {

/**
* Returns a hexadecimal value of the specified length
* @param {Number} num
* @returns {String}
*/
function generateHexadecimalValue(num) {
return _.times(num, () => Math.floor(Math.random() * 16).toString(16))
.join('')
.toUpperCase();
function generateHexadecimalValue(num: number): string {
const result: string[] = [];
for (let i = 0; i < num; i++) {
result.push(Math.floor(Math.random() * 16).toString(16));
}
return result.join('').toUpperCase();
}

/**
* Generates a random integer between a and b
* It's and equivalent of _.random(a, b)
*
* @param {Number} a
* @param {Number} b
* @returns {Number} random integer between a and b
* @returns random integer between a and b
*/
function generateRandomInt(a, b) {
function generateRandomInt(a: number, b: number): number {
const lower = Math.ceil(Math.min(a, b));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function generateRandomInt(a: number, b: number): number {
/**
* Generates a random integer between a and b
* It's and equivalent of _.random(a, b)
*
* @returns random integer between a and b
*/
function generateRandomInt(a: number, b: number): number {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the @returns description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed @fabioh8010 :)

const upper = Math.floor(Math.max(a, b));
return Math.floor(lower + Math.random() * (upper - lower + 1));
Expand Down
Loading