fix overscroll spacer in safari #26873

ishpaul777 · 2023-09-06T13:46:17Z

Details

Fixed Issues

$ #23422
PROPOSAL: #23422 (comment)

Tests

Verify that no errors appear in the JS console

On Safari IOS and IOS Native app:

Navigate to preferences page
Try to overscroll Down, verify no green background until scrolled 50% of Scrollable view
Try to overscroll Upward, verify no illustrated Header color until scrolled 50% of Scrollable view
Navigate to Workspace list page
Try to overscroll Down, verify no green background until scrolled 50% of Scrollable view
Try to overscroll Upward, verify no illustrated Header color until scrolled 50% of Scrollable view

Offline tests

On Safari IOS and IOS Native app:

Navigate to preferences page
Try to overscroll Down, verify no green background until scrolled 50% of Scrollable view
Try to overscroll Upward, verify no illustrated Header color until scrolled 50% of Scrollable view
Navigate to Workspace list page
Try to overscroll Down, verify no green background until scrolled 50% of Scrollable view
Try to overscroll Upward, verify no illustrated Header color until scrolled 50% of Scrollable view

QA Steps

Verify that no errors appear in the JS console

On Safari IOS and IOS Native app:

Navigate to preferences page
Try to overscroll Down, verify no green background until scrolled 50% of Scrollable view
Try to overscroll Upward, verify no illustrated Header color until scrolled 50% of Scrollable view
Navigate to Workspace list page
Try to overscroll Down, verify no green background until scrolled 50% of Scrollable view
Try to overscroll Upward, verify no illustrated Header color until scrolled 50% of Scrollable view

PR Author Checklist

Screenshots/Videos

Web Safari

Screen.Recording.2023-09-06.at.10.50.47.AM.mov

Web Chrome

Screen.Recording.2023-09-06.at.8.17.06.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-09-06.at.11.04.30.AM.mov

Mobile Web - Safari

Screen.Recording.2023-09-06.at.10.45.52.AM.mov

Desktop

Screen.Recording.2023-09-06.at.8.10.54.PM.mov

iOS

Screen.Recording.2023-09-06.at.10.47.14.AM.mov

Android

Screen.Recording.2023-09-06.at.11.24.52.AM-1.mov

melvin-bot · 2023-09-06T13:46:22Z

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

0xmiros · 2023-09-06T19:10:30Z

Navigate to Workspace page

Update this to

Navigate to Workspaces list page

ishpaul777 · 2023-09-06T19:13:00Z

done

0xmiros · 2023-09-06T19:23:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

safari.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

0xmiros

LGTM! (still workaround though)

ishpaul777 · 2023-09-06T19:45:54Z

@roryabraham Please Hold your review I found a styling issue, pushing fix in few minutes

src/components/IllustratedHeaderPageLayout.js

ishpaul777 · 2023-09-06T21:35:22Z

src/components/IllustratedHeaderPageLayout.js

+                        {Browser.isSafari() && (
+                            <View style={[styles.dualColorOverscrollSpacer]}>
+                                <View style={[styles.flex1, StyleUtils.getBackgroundColorStyle(backgroundColor)]} />
+                                <View style={[isSmallScreenWidth ? styles.flex1 : styles.flex3, StyleUtils.getBackgroundColorStyle(themeColors.appBG)]} />


for the large screen when workspace count is less upper background was visible, On mac safari, overscrolling is allowed very little so i guess this is fine

ishpaul777 · 2023-09-06T21:41:36Z

@0xmiroslav @roryabraham Bumping for review

0xmiros · 2023-09-07T16:47:39Z

@ishpaul777 ok, so you changed nothing after my review, right?

ishpaul777 · 2023-09-07T16:50:55Z

I apologize i changed few things commit was not signed, reverted and forgot to push again, will made change again give me few mins.

0xmiros · 2023-09-07T16:55:09Z

src/components/IllustratedHeaderPageLayout.js

@@ -66,9 +68,9 @@ function IllustratedHeaderPageLayout({backgroundColor, children, illustration, f
                                    loop
                                />
                            </View>
-                            <View style={[styles.pt5]}>{children}</View>
+                            <View style={[styles.pt5, StyleUtils.getBackgroundColorStyle(themeColors.appBG)]}>{children}</View>


Use new variable defining this.

0xmiros

LGTM!

I think @roryabraham will be busy this week (attending in RNEU conference)
Hopefully reviewed & merged next Monday

roryabraham

I was still able to reproduce this in Safari with a vigorous scroll, but it's much better than it was.

web.mov

We also can't really shift it so that the blue background takes up more than half of the screen because then we'll just introduce the inverse problem on the bottom.

So with this PR you can still see the bug if you intentionally over-scroll beyond what you would normally do. The solution isn't perfect but it's a workaround to a safari bug that makes it better for most users most of the time, and I'll take that in this case because we can't fix it upstream in Safari.

roryabraham · 2023-09-10T17:41:39Z

This is not urgent, so I'd like to wait until after we do one more production release before merging this. Because of the merge freeze, if we're not careful we'll have a GIANT release checklist on our hands if we merge everything the first day the freeze is lifted.

This delay should not count against the #urgency bonus. I think the PR was made and approved by C+ within the time limit to get the #urgency bonus so unless something changes I think this PR should receive the #urgency bonus

roryabraham · 2023-09-14T09:15:48Z

Thanks for your patience here @ishpaul777. Can you please resolve conflicts so we can get this merged?

…spacer-safari

src/components/IllustratedHeaderPageLayout.js

0xmiros · 2023-09-14T09:37:03Z

@ishpaul777 did you test all platforms after last commit?

ishpaul777 · 2023-09-14T09:41:42Z

@0xmiroslav android app is build, tested on all other platforms, also How can i test lounge access page?

0xmiros · 2023-09-14T09:43:13Z

@0xmiroslav android app is build, tested on all other platforms, also How can i test lounge access page?

Manually search for props.user.hasLoungeAccess and replace it with true

ishpaul777 · 2023-09-14T10:12:57Z

Lounge access page has header BG same as appBG so fix has effect on the page. Android app is still building, sorrry for delay.

Screen.Recording.2023-09-14.at.3.38.45.PM.mov

ishpaul777 · 2023-09-14T11:32:39Z

Merge changes tests well on all platforms @0xmiroslav

0xmiros

Tests well for me too

@roryabraham all good to merge!

melvin-bot · 2023-09-15T10:52:20Z

Congrats, that’s your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It’s an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

OSBotify · 2023-09-15T10:58:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-18T10:40:24Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.71-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-20T08:12:54Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.71-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

ishpaul777 requested a review from a team as a code owner September 6, 2023 13:46

melvin-bot bot removed the request for review from a team September 6, 2023 13:46

melvin-bot bot requested a review from 0xmiros September 6, 2023 13:46

fix overscroller for safari

b309738

ishpaul777 force-pushed the ishpaul777/fix-IllustratedHeader-Overscroll-spacer-safari branch from 5fe785d to b309738 Compare September 6, 2023 15:01

0xmiros approved these changes Sep 6, 2023

View reviewed changes

melvin-bot bot requested a review from roryabraham September 6, 2023 19:24

ishpaul777 commented Sep 6, 2023

View reviewed changes

src/components/IllustratedHeaderPageLayout.js Show resolved Hide resolved

ishpaul777 commented Sep 6, 2023

View reviewed changes

ishpaul777 force-pushed the ishpaul777/fix-IllustratedHeader-Overscroll-spacer-safari branch from 3bbf0d5 to b309738 Compare September 6, 2023 21:39

ishpaul777 requested a review from 0xmiros September 6, 2023 21:41

0xmiros reviewed Sep 7, 2023

View reviewed changes

made the fix specific to safari

23fe5ca

ishpaul777 force-pushed the ishpaul777/fix-IllustratedHeader-Overscroll-spacer-safari branch from 263249e to 23fe5ca Compare September 7, 2023 17:31

ishpaul777 requested a review from 0xmiros September 7, 2023 17:32

0xmiros approved these changes Sep 7, 2023

View reviewed changes

0xmiros mentioned this pull request Sep 8, 2023

[HOLD for @0xmiroslav payment] [$1000] mweb: Green background colour visible when scrolling on the Preference Page #23422

Closed

6 tasks

roryabraham previously approved these changes Sep 10, 2023

View reviewed changes

Merge branch 'main' into ishpaul777/fix-IllustratedHeader-Overscroll-…

b758c59

…spacer-safari

ishpaul777 dismissed roryabraham’s stale review via b758c59 September 14, 2023 09:26

ishpaul777 requested a review from roryabraham September 14, 2023 09:26

0xmiros reviewed Sep 14, 2023

View reviewed changes

src/components/IllustratedHeaderPageLayout.js Show resolved Hide resolved

resolve-conflicts

a55003d

ishpaul777 requested a review from 0xmiros September 14, 2023 09:35

0xmiros approved these changes Sep 14, 2023

View reviewed changes

roryabraham approved these changes Sep 15, 2023

View reviewed changes

roryabraham merged commit d9f35a3 into Expensify:main Sep 15, 2023
12 checks passed

OSBotify mentioned this pull request Sep 18, 2023

Deploy Checklist: New Expensify 2023-09-18 #27654

Closed

91 tasks

ishpaul777 mentioned this pull request Sep 20, 2023

Feat/initial settings page layout change #27468

Merged

59 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix overscroll spacer in safari #26873

fix overscroll spacer in safari #26873

ishpaul777 commented Sep 6, 2023 •

edited

Loading

melvin-bot bot commented Sep 6, 2023

0xmiros commented Sep 6, 2023

ishpaul777 commented Sep 6, 2023

0xmiros commented Sep 6, 2023

0xmiros left a comment

ishpaul777 commented Sep 6, 2023 •

edited

Loading

ishpaul777 Sep 6, 2023

ishpaul777 commented Sep 6, 2023

0xmiros commented Sep 7, 2023

ishpaul777 commented Sep 7, 2023 •

edited

Loading

0xmiros Sep 7, 2023

0xmiros left a comment

roryabraham left a comment

roryabraham commented Sep 10, 2023

roryabraham commented Sep 14, 2023

0xmiros commented Sep 14, 2023

ishpaul777 commented Sep 14, 2023

0xmiros commented Sep 14, 2023

ishpaul777 commented Sep 14, 2023 •

edited

Loading

ishpaul777 commented Sep 14, 2023

0xmiros left a comment

melvin-bot bot commented Sep 15, 2023

OSBotify commented Sep 15, 2023

OSBotify commented Sep 18, 2023

OSBotify commented Sep 20, 2023

fix overscroll spacer in safari #26873

fix overscroll spacer in safari #26873

Conversation

ishpaul777 commented Sep 6, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 6, 2023

0xmiros commented Sep 6, 2023

ishpaul777 commented Sep 6, 2023

0xmiros commented Sep 6, 2023

Reviewer Checklist

Screenshots/Videos

0xmiros left a comment

Choose a reason for hiding this comment

ishpaul777 commented Sep 6, 2023 • edited Loading

ishpaul777 Sep 6, 2023

Choose a reason for hiding this comment

ishpaul777 commented Sep 6, 2023

0xmiros commented Sep 7, 2023

ishpaul777 commented Sep 7, 2023 • edited Loading

0xmiros Sep 7, 2023

Choose a reason for hiding this comment

0xmiros left a comment

Choose a reason for hiding this comment

roryabraham left a comment

Choose a reason for hiding this comment

roryabraham commented Sep 10, 2023

roryabraham commented Sep 14, 2023

0xmiros commented Sep 14, 2023

ishpaul777 commented Sep 14, 2023

0xmiros commented Sep 14, 2023

ishpaul777 commented Sep 14, 2023 • edited Loading

ishpaul777 commented Sep 14, 2023

0xmiros left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 15, 2023

OSBotify commented Sep 15, 2023

OSBotify commented Sep 18, 2023

OSBotify commented Sep 20, 2023

ishpaul777 commented Sep 6, 2023 •

edited

Loading

ishpaul777 commented Sep 6, 2023 •

edited

Loading

ishpaul777 commented Sep 7, 2023 •

edited

Loading

ishpaul777 commented Sep 14, 2023 •

edited

Loading