Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hoverable component refactored from class into functional approach #27223

Merged
merged 18 commits into from
Oct 2, 2023
Merged

Hoverable component refactored from class into functional approach #27223

merged 18 commits into from
Oct 2, 2023

Commits on Sep 22, 2023

  1. rewrite Hoverable class component into functional

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    96cf606 View commit details
    Browse the repository at this point in the history

  2. add Hoverable missing export statement

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    cc13306 View commit details
    Browse the repository at this point in the history

  3. do not call hover callbacks if disabled

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    7d23059 View commit details
    Browse the repository at this point in the history

  4. narrow useCallback deps

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    b8e2551 View commit details
    Browse the repository at this point in the history

  5. add displayName to Hoverable

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    0a2a307 View commit details
    Browse the repository at this point in the history

  6. remove unnecessary comment

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    7958647 View commit details
    Browse the repository at this point in the history

  7. add checks for hover callbacks

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    393aa90 View commit details
    Browse the repository at this point in the history

  8. fix forward ref issues

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    d2258a1 View commit details
    Browse the repository at this point in the history

  9. use useImperativeHandle to manage outerRef

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    269b58a View commit details
    Browse the repository at this point in the history

  10. change callback name to be more decsriptive

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    789d927 View commit details
    Browse the repository at this point in the history

  11. update isHovered properly on disabled

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    b3ffe68 View commit details
    Browse the repository at this point in the history

  12. add missing checkHover handler

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    b28f30b View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into refactor/16161/hoverable-class-to-functional

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    aed03e7 View commit details
    Browse the repository at this point in the history

  14. obey curly eslint rule

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    3d427f8 View commit details
    Browse the repository at this point in the history

  15. update hovered on scroll end and fix conditional

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    88a1bc0 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Fix scrollingListener cleanup

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    0dbb737 View commit details
    Browse the repository at this point in the history

  2. Replace isScrolling state with ref

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    d1c0a27 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. add useImperativeHandle explanation comment

    @kacper-mikolajczak
    kacper-mikolajczak committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    a9601db View commit details
    Browse the repository at this point in the history