Refactor/16226/auth screens components migration to functional #27764

barttom · 2023-09-19T09:46:39Z

Details

Migration component from lass to functional

Fixed Issues

$ #16226
PROPOSAL: #16226

Tests

Open the app and log in.
Navigate to a few screens to make sure that navigator works properly.
Logout and login again.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the app and log in.
Navigate to a few screens to make sure that navigator works properly.
Logout and login again.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
All props are defined accurately and each prop has a /** comment above it */
The file is named correctly
The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
The only data being stored in the state is data necessary for rendering and nothing else
If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
All JSX used for rendering exists in the render method
The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

16226_web.mp4

Desktop

iOS

16226_iphone.mp4

Android

16226_android.mp4

src/libs/Navigation/AppNavigator/AuthScreens.js

melvin-bot · 2023-09-20T11:21:25Z

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2023-09-24T15:35:32Z

I can review if this requires C+

marcochavezf · 2023-09-25T02:39:38Z

Hi @situchan, yes please, I will assign you as C+ reviewer

marcochavezf · 2023-09-25T02:51:03Z

Hi @barttom, there are some lint errors and unverified commits. For the unverified commits, I think the solution will be maybe to force push the branch with verified commits.

barttom · 2023-09-25T10:45:31Z

thanks @marcochavezf, fixed :)

situchan

Code looks good. Let's just fix lint

src/libs/Navigation/AppNavigator/AuthScreens.js

barttom · 2023-09-27T10:29:56Z

@situchan fixed

situchan · 2023-09-28T13:27:58Z

Job 3 is failing. Please pull main

barttom · 2023-09-28T13:56:58Z

@situchan fixed

src/libs/Navigation/AppNavigator/AuthScreens.js

situchan · 2023-10-15T16:16:57Z

Please add test case

barttom · 2023-10-16T13:56:58Z

Please add test case

test case added

barttom · 2023-10-18T14:51:30Z

@situchan could You review this?

situchan · 2023-10-18T14:52:12Z

reviewing today

barttom · 2023-10-20T06:04:28Z

@situchan can we move it forward?

marcochavezf · 2023-10-23T20:16:58Z

friendly bump @situchan

situchan · 2023-10-25T16:34:19Z

@barttom that PR was merged. Please pull main

barttom · 2023-10-25T16:47:22Z

@situchan done :)

situchan · 2023-10-25T17:07:12Z

Crash on resize window on web. Already happening on main so out of scope.

Screen.Recording.2023-10-25.at.11.05.37.PM.mov

situchan · 2023-10-25T17:15:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

situchan

marcochavezf

Code LGTM, thank you guys!

OSBotify · 2023-10-25T18:09:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-26T23:00:50Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.92-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-30T07:44:08Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.92-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-30T08:05:20Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.93-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-31T21:38:29Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.93-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

situchan · 2024-01-26T19:17:27Z

src/libs/Navigation/AppNavigator/AuthScreens.js

@@ -160,7 +170,7 @@ class AuthScreens extends React.Component {
            if (isLoadingApp) {
                App.openApp();
            } else {
-                App.reconnectApp(this.props.lastUpdateIDAppliedToClient);
+                App.reconnectApp(lastUpdateIDAppliedToClient);


As we are aware already, there's hidden bug where lastUpdateIDAppliedToClient is NOT the updated updateID we saved in Onyx as this isn't added in useEffect dependency

fabioh8010 reviewed Sep 19, 2023

View reviewed changes

src/libs/Navigation/AppNavigator/AuthScreens.js Outdated Show resolved Hide resolved

gedu reviewed Sep 19, 2023

View reviewed changes

src/libs/Navigation/AppNavigator/AuthScreens.js Show resolved Hide resolved

barttom force-pushed the refactor/16226/auth-screens-components-migration-to-functional branch from cec9cc1 to 556bddb Compare September 20, 2023 11:08

barttom marked this pull request as ready for review September 20, 2023 11:20

barttom requested a review from a team as a code owner September 20, 2023 11:20

melvin-bot bot requested review from marcochavezf and removed request for a team September 20, 2023 11:21

marcochavezf mentioned this pull request Sep 25, 2023

[HOLD for payment 2023-11-06] [$250] Migrate AuthScreens.js to function component #16226

Closed

1 task

barttom force-pushed the refactor/16226/auth-screens-components-migration-to-functional branch from 556bddb to 1120abe Compare September 25, 2023 10:44

situchan reviewed Sep 25, 2023

View reviewed changes

src/libs/Navigation/AppNavigator/AuthScreens.js Show resolved Hide resolved

barttom force-pushed the refactor/16226/auth-screens-components-migration-to-functional branch from 04dec83 to 873b249 Compare September 27, 2023 10:26

barttom force-pushed the refactor/16226/auth-screens-components-migration-to-functional branch from 873b249 to 5b08a59 Compare September 28, 2023 13:50

situchan reviewed Oct 1, 2023

View reviewed changes

src/libs/Navigation/AppNavigator/AuthScreens.js Show resolved Hide resolved

barttom force-pushed the refactor/16226/auth-screens-components-migration-to-functional branch from 5b08a59 to 1af44fc Compare October 12, 2023 10:12

barttom force-pushed the refactor/16226/auth-screens-components-migration-to-functional branch from 1af44fc to ef4b623 Compare October 16, 2023 13:56

barttom force-pushed the refactor/16226/auth-screens-components-migration-to-functional branch from ef4b623 to 3f73234 Compare October 18, 2023 14:50

barttom and others added 11 commits October 25, 2023 18:38

refactor: rerite AuthScreen to funcitonal compoenent

5547726

reafctor: switched to width dimmensions hook instead of HOC

df47aa9

refactor: remove momnization

814d6e4

fix: moved striting timing to useEffect

31a0d4d

refactor: restored initial Timing start

a44d5e7

refactor: comment eslint rule for effect hook

3a3300b

refactor: added memiozation of AuthScreen component

568040a

refactor: prettier file after merge

44c281e

refactor: merge main

8a2c5e4

fix: restore cmd+J shortcut

f0981d1

fix: fixwes after rebase

a16c3ff

barttom force-pushed the refactor/16226/auth-screens-components-migration-to-functional branch from bef9ef6 to a16c3ff Compare October 25, 2023 16:46

situchan approved these changes Oct 25, 2023

View reviewed changes

melvin-bot bot requested a review from marcaaron October 25, 2023 17:15

marcochavezf approved these changes Oct 25, 2023

View reviewed changes

marcochavezf merged commit ac8cfd3 into Expensify:main Oct 25, 2023
15 checks passed

OSBotify mentioned this pull request Oct 26, 2023

Deploy Checklist: New Expensify 2023-10-26 #30469

Closed

64 tasks

OSBotify mentioned this pull request Oct 30, 2023

Deploy Checklist: New Expensify 2023-10-30 #30560

Closed

iwiznia mentioned this pull request Dec 6, 2023

[HOLD for payment 2024-01-24] [$500] AuthScreens reconnectApp call is passing an outdated lastUpdateIDAppliedToClient #32583

Closed

situchan reviewed Jan 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor/16226/auth screens components migration to functional #27764

Refactor/16226/auth screens components migration to functional #27764

barttom commented Sep 19, 2023 •

edited

Loading

melvin-bot bot commented Sep 20, 2023

situchan commented Sep 24, 2023

marcochavezf commented Sep 25, 2023

marcochavezf commented Sep 25, 2023

barttom commented Sep 25, 2023

situchan left a comment

barttom commented Sep 27, 2023

situchan commented Sep 28, 2023

barttom commented Sep 28, 2023

situchan commented Oct 15, 2023

barttom commented Oct 16, 2023

barttom commented Oct 18, 2023

situchan commented Oct 18, 2023

barttom commented Oct 20, 2023

marcochavezf commented Oct 23, 2023

situchan commented Oct 25, 2023

barttom commented Oct 25, 2023

situchan commented Oct 25, 2023

situchan commented Oct 25, 2023

situchan left a comment

marcochavezf left a comment

OSBotify commented Oct 25, 2023

OSBotify commented Oct 26, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 31, 2023

situchan Jan 26, 2024

Refactor/16226/auth screens components migration to functional #27764

Refactor/16226/auth screens components migration to functional #27764

Conversation

barttom commented Sep 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 20, 2023

situchan commented Sep 24, 2023

marcochavezf commented Sep 25, 2023

marcochavezf commented Sep 25, 2023

barttom commented Sep 25, 2023

situchan left a comment

Choose a reason for hiding this comment

barttom commented Sep 27, 2023

situchan commented Sep 28, 2023

barttom commented Sep 28, 2023

situchan commented Oct 15, 2023

barttom commented Oct 16, 2023

barttom commented Oct 18, 2023

situchan commented Oct 18, 2023

barttom commented Oct 20, 2023

marcochavezf commented Oct 23, 2023

situchan commented Oct 25, 2023

barttom commented Oct 25, 2023

situchan commented Oct 25, 2023

situchan commented Oct 25, 2023

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

marcochavezf left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 25, 2023

OSBotify commented Oct 26, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 31, 2023

situchan Jan 26, 2024

Choose a reason for hiding this comment

barttom commented Sep 19, 2023 •

edited

Loading