[No QA] [TS migration] Migrate 'CurrencyUtils.js' lib to TypeScript #27865

VickyStash · 2023-09-20T14:04:36Z

Details

Migrate 'CurrencyUtils.js' lib to TypeScript

Fixed Issues

$ #24891
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Click on the main action button -> Request Money
Select the 'Manual' option on the Request Money screen => make sure it shows the right currency
Enter the value => press next
Select user to split the money with => press add to the split
Check the split screen, and make sure the amount of money and currency are ok
Press split -> Check money request details on the chat screen

Make sure the functionality works as before.

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

Click on the main action button -> Request Money
Select the 'Manual' option on the Request Money screen => make sure it shows the right currency
Enter the value => press next
Select user to split the money with => press add to the split
Check the split screen, and make sure the amount of money and currency are ok
Press split -> Check money request details on the chat screen

Make sure the functionality works as before.

PR Author Checklist

Screenshots/Videos

Web

Web.mov

Mobile Web - Chrome

android.browser.mp4

Mobile Web - Safari

ios.safari.mp4

Desktop

Desktop.mov

iOS

ios.mov

Android

android.mov

src/libs/CurrencyUtils.ts

fabioh8010 · 2023-09-20T15:36:57Z

src/libs/CurrencyUtils.ts

+type CurrencyList = Record<string, Currency>;
+
+let currencyList: CurrencyList = {};


Suggested change

type CurrencyList = Record<string, Currency>;

let currencyList: CurrencyList = {};

let currencyList: OnyxValues[typeof ONYXKEYS.CURRENCY_LIST] = {};

melvin-bot · 2023-09-20T15:48:14Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav

LGTM. Approved based the guidelines for TS mgration.

melvin-bot · 2023-09-20T19:46:29Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #24891 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

blazejkustra

LGTM, SWM still need to do the checklist.

Skalakid · 2023-09-21T15:51:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

chrome.mov

Mobile Web - Safari

safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

arosiclair · 2023-09-25T01:53:24Z

LGTM though we got some merge conflicts @VickyStash

VickyStash · 2023-09-25T10:35:15Z

@arosiclair I've resolved conflicts, please take a look

OSBotify · 2023-09-26T02:05:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-28T19:20:15Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:24:11Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:52:49Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:53:46Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[TS migration] Migrate 'CurrencyUtils.js' lib

0eba8a5

kubabutkiewicz reviewed Sep 20, 2023

View reviewed changes

src/libs/CurrencyUtils.ts Show resolved Hide resolved

kubabutkiewicz reviewed Sep 20, 2023

View reviewed changes

src/libs/CurrencyUtils.ts Show resolved Hide resolved

fabioh8010 reviewed Sep 20, 2023

View reviewed changes

Remove extra type

ee8c075

fabioh8010 approved these changes Sep 20, 2023

View reviewed changes

VickyStash marked this pull request as ready for review September 20, 2023 15:48

VickyStash requested a review from a team as a code owner September 20, 2023 15:48

melvin-bot bot requested review from mananjadhav and removed request for a team September 20, 2023 15:48

mananjadhav approved these changes Sep 20, 2023

View reviewed changes

melvin-bot bot requested a review from arosiclair September 20, 2023 19:46

blazejkustra approved these changes Sep 21, 2023

View reviewed changes

Skalakid approved these changes Sep 21, 2023

View reviewed changes

arosiclair previously approved these changes Sep 25, 2023

View reviewed changes

VickyStash added 2 commits September 25, 2023 10:27

Merge branch 'main' into ts-migration/currencyUtils-lib

98a9b3d

Resolve conflicts

42d21e2

VickyStash dismissed arosiclair’s stale review via 42d21e2 September 25, 2023 08:42

arosiclair approved these changes Sep 26, 2023

View reviewed changes

arosiclair merged commit 973f5b8 into Expensify:main Sep 26, 2023
14 checks passed

OSBotify mentioned this pull request Sep 28, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

melvin-bot bot mentioned this pull request Oct 2, 2023

[HOLD for payment 2023-10-09] [TS migration] Migrate 'CurrencyUtils.js' lib to TypeScript #24891

Closed

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] [TS migration] Migrate 'CurrencyUtils.js' lib to TypeScript #27865

[No QA] [TS migration] Migrate 'CurrencyUtils.js' lib to TypeScript #27865

VickyStash commented Sep 20, 2023 •

edited

Loading

fabioh8010 Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

mananjadhav left a comment

melvin-bot bot commented Sep 20, 2023

blazejkustra left a comment

Skalakid commented Sep 21, 2023 •

edited

Loading

arosiclair commented Sep 25, 2023 •

edited

Loading

VickyStash commented Sep 25, 2023 •

edited

Loading

OSBotify commented Sep 26, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

		type CurrencyList = Record<string, Currency>;

		let currencyList: CurrencyList = {};

[No QA] [TS migration] Migrate 'CurrencyUtils.js' lib to TypeScript #27865

[No QA] [TS migration] Migrate 'CurrencyUtils.js' lib to TypeScript #27865

Conversation

VickyStash commented Sep 20, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

fabioh8010 Sep 20, 2023

Choose a reason for hiding this comment

melvin-bot bot commented Sep 20, 2023

mananjadhav left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 20, 2023

blazejkustra left a comment

Choose a reason for hiding this comment

Skalakid commented Sep 21, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

arosiclair commented Sep 25, 2023 • edited Loading

VickyStash commented Sep 25, 2023 • edited Loading

OSBotify commented Sep 26, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

VickyStash commented Sep 20, 2023 •

edited

Loading

Skalakid commented Sep 21, 2023 •

edited

Loading

arosiclair commented Sep 25, 2023 •

edited

Loading

VickyStash commented Sep 25, 2023 •

edited

Loading