-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove sms domain task preview #28243
remove sms domain task preview #28243
Conversation
@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Hi @cubuspl42 @Julesssss PR is already for review. |
Are you aware of some phone number accounts suitable for testing? Also, please don't ping internal engineers unless really necessary, they don't take part in the first stage of PR review. |
Sure, I updated @cubuspl42 |
Reviewer Checklist
Screenshots/VideosWebno-sms-web.mp4Mobile Web - Chromeno-sms-android-web-compressed.mp4Mobile Web - Safarino-sms-ios-web.mp4Desktopno-sms-desktop.mp4iOSno-sms-ios.mp4Androidno-sms-android-compressed.mp4 |
Hey @cubuspl42, just noticed that Desktop is missing. Do you need me to test that platform? |
@Julesssss To be honest, I test Desktop only when we're remotely close to the small functionality area when Web and Desktop can be expected to work differently. In case of a change like this one, also taking into account that the Contributor already tested on Desktop, this feels like art for art's sake. The Expensify checklists are often helpful, but sometimes I decide to skip some part of it, taking responsibility for that decision. If you feel that re-testing on Desktop brings some value here, I can do that |
@cubuspl42 we understand that these checks can sometimes feel redundant, but following the process for each PR prevents cases in which we mistakenly make the assumption that something is not worth testing because it cannot have broken. This wastes our internal teams time on the investigation and resolution of regressions. |
@Julesssss |
Thanks! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.75-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.76-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀
|
Details
Fixed Issues
$ #27330
PROPOSAL: #27330 (comment)
Tests
@expensify.sms
Offline tests
The same test
QA Steps
The same test
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
mweb.mov
Mobile Web - Safari
safari.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov