include task status messages in last message text #28248

rojiphil · 2023-09-26T10:28:52Z

@rushatgabhane @Gonals

Details

This PR additionally returns the text for Task Status messages within getLastMessageTextForReport function

Fixed Issues

$ #26679
PROPOSAL: #26679 (comment)

Tests

Click on FAB for a Chat Report and Assign a Task
In the Task Report, click on Mark as done button in header.
Send a message in Task Report.
Delete the message in Step 3 in Task Report
Navigate to Search Page via CTRL+K or LHN Search button.
Expected Behaviour: Verify that the Task Status message for completed task is displayed as subtitle/alternate text in Search Page.

Verify that no errors appear in the JS console
Found out a console error while launching search page.
Have raised bug in expensify-bugs Slack channel here

Offline tests

Same as Steps for Tests Section.

QA Steps

Same as Steps for Tests Section.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

1-26679-web-safari.mp4

26679-web-safari.mp4

Mobile Web - Chrome

1-26679-mweb-chrome.mp4

26679-mweb-android.mp4

Mobile Web - Safari

1-26679-mweb-safari.mp4

26679-mweb-safari.mp4

Desktop

1-26679-desktop.mp4

26679-desktop.mp4

iOS

1-26679-ios-native.mp4

26679-ios-native.mp4

Android

1-26679-android-native.mp4

26679-android-native.mp4

Offline

26679-offline.mp4

melvin-bot · 2023-09-26T10:28:57Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-09-26T20:53:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

rushatgabhane · 2023-09-26T20:58:48Z

src/libs/OptionsListUtils.js

+    } else if (
+        lastActionName === CONST.REPORT.ACTIONS.TYPE.TASKCOMPLETED ||
+        lastActionName === CONST.REPORT.ACTIONS.TYPE.TASKREOPENED ||
+        lastActionName === CONST.REPORT.ACTIONS.TYPE.TASKCANCELLED


@rojiphil I think we should add TASKEDITED here because on edit, we're still showing the old task name in search page.

@rojiphil it doesn't have a message associated with it but when a task is edited, the action type is edited.

If we don't add edited action, the search page won't have the edited task. it'll show old task title

looks outside of the scope in our current context

i think we should add task edited. It's a one line change

I confirmed it locally yesterday

@rushatgabhane

Can you please share the details of your tests?
We have an obvious disconnect here. So, just want to check if I am missing something very simple.

@rojiphil im sorry for poor communication, im away from my laptop. Anyway, let's work it out today 😊

Can you please share the details of your tests

Create a task - "water plants"

Mark it as done

Make it as undone

Click task name and change it's name to - "do laundry"

Open LHN

Notice that the LHN's subtitle for task refers fo the original task name "water plants"

Expected: LHN subtitle is "do laundry"

@rushatgabhane

Ah! Now, I get it.
Please have a look at the attached test video.
As seen in video, the BE doesn't update the text message[0].text with edited task name.
Looks like a bug in BE.
Does this make sense?

subtitle-BE-issue.mp4

Thank you so much for clarifying that @rojiphil
You're right, the backend isn't updating the text. It's a different issue. Please report it on slack for a bonus :)

rushatgabhane

LGTM!

Gonals · 2023-09-28T06:24:56Z

Seems like we have some conflicts!

…e-fix

rojiphil · 2023-09-28T08:11:28Z

Seems like we have some conflicts!

@rushatgabhane @Gonals
Have resolved and merged. And tested and verified the outcome again on all the platforms.
Kindly review. Thanks.

rojiphil · 2023-09-30T04:35:11Z

@Gonals @rushatgabhane

Gentle nudge to get this merged. Thanks.

OSBotify · 2023-10-02T08:24:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-02T17:46:25Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:47:22Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T16:11:45Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.3.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-05T00:18:35Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

include task status messages in last message text

c2e4e20

rojiphil requested a review from a team as a code owner September 26, 2023 10:28

melvin-bot bot requested review from rushatgabhane and removed request for a team September 26, 2023 10:28

rojiphil mentioned this pull request Sep 26, 2023

[HOLD for payment 2023-10-10] [$1000] No activity yet appears in task item of search RHN. #26679

Closed

6 tasks

rushatgabhane reviewed Sep 26, 2023

View reviewed changes

rushatgabhane approved these changes Sep 27, 2023

View reviewed changes

melvin-bot bot requested a review from Gonals September 27, 2023 19:40

rojiphil added 2 commits September 28, 2023 12:25

Merge branch 'main' into 26679-searchpage-incorrect-subtitle-fix

1e626fc

Merge branch 'Expensify:main' into 26679-searchpage-incorrect-subtitl…

cac8ad7

…e-fix

Gonals approved these changes Sep 29, 2023

View reviewed changes

This comment was marked as outdated.

Sign in to view

Gonals merged commit aaa8ae3 into Expensify:main Oct 2, 2023
14 checks passed

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

OSBotify mentioned this pull request Oct 3, 2023

Deploy Checklist: New Expensify 2023-10-03 #28727

Closed

rojiphil mentioned this pull request Oct 3, 2023

[$500] Web - LHN Subtitle Changed to "Not Active" Instead of "Delete" After Deleting Assigned Tasks and Attachment #28015

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

include task status messages in last message text #28248

include task status messages in last message text #28248

rojiphil commented Sep 26, 2023 •

edited

Loading

melvin-bot bot commented Sep 26, 2023

rushatgabhane commented Sep 26, 2023 •

edited

Loading

rushatgabhane Sep 26, 2023

This comment was marked as off-topic.

rushatgabhane Sep 27, 2023

rushatgabhane Sep 27, 2023

This comment was marked as off-topic.

This comment was marked as off-topic.

rojiphil Sep 27, 2023

rushatgabhane Sep 27, 2023 •

edited

Loading

rojiphil Sep 27, 2023

rushatgabhane Sep 27, 2023

rushatgabhane left a comment

Gonals commented Sep 28, 2023

rojiphil commented Sep 28, 2023 •

edited

Loading

This comment was marked as outdated.

rojiphil commented Sep 30, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 5, 2023

include task status messages in last message text #28248

include task status messages in last message text #28248

Conversation

rojiphil commented Sep 26, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 26, 2023

rushatgabhane commented Sep 26, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane Sep 26, 2023

Choose a reason for hiding this comment

This comment was marked as off-topic.

rushatgabhane Sep 27, 2023

Choose a reason for hiding this comment

rushatgabhane Sep 27, 2023

Choose a reason for hiding this comment

This comment was marked as off-topic.

This comment was marked as off-topic.

rojiphil Sep 27, 2023

Choose a reason for hiding this comment

rushatgabhane Sep 27, 2023 • edited Loading

Choose a reason for hiding this comment

rojiphil Sep 27, 2023

Choose a reason for hiding this comment

rushatgabhane Sep 27, 2023

Choose a reason for hiding this comment

rushatgabhane left a comment

Choose a reason for hiding this comment

Gonals commented Sep 28, 2023

rojiphil commented Sep 28, 2023 • edited Loading

This comment was marked as outdated.

rojiphil commented Sep 30, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 3, 2023

OSBotify commented Oct 5, 2023

rojiphil commented Sep 26, 2023 •

edited

Loading

rushatgabhane commented Sep 26, 2023 •

edited

Loading

rushatgabhane Sep 27, 2023 •

edited

Loading

rojiphil commented Sep 28, 2023 •

edited

Loading