-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@swm/global nav menu v1 #28277
@swm/global nav menu v1 #28277
Conversation
@shawnborton for providing the icons |
These are all of the icons we'll need, some already exist in the App repo though, so you might need to upload certain ones: Icon svgs: Icons.zip |
@hoangzinh @hayata-suenaga One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-10-05.at.6.15.48.PM.movMobile Web - ChromeScreen.Recording.2023-10-05.at.6.19.44.PM.movMobile Web - SafariScreen.Recording.2023-10-05.at.6.18.15.PM.movDesktopScreen.Recording.2023-10-05.at.6.22.04.PM.moviOSScreen.Recording.2023-10-05.at.6.17.29.PM.movAndroidScreen.Recording.2023-10-05.at.6.20.45.PM.mov |
src/pages/home/sidebar/GlobalNavigation/GlobalNavigationMenuItem.js
Outdated
Show resolved
Hide resolved
src/pages/home/sidebar/GlobalNavigation/GlobalNavigationMenuItem.js
Outdated
Show resolved
Hide resolved
src/pages/home/sidebar/GlobalNavigation/GlobalNavigationMenuItem.js
Outdated
Show resolved
Hide resolved
src/pages/home/sidebar/GlobalNavigation/GlobalNavigationMenuItemList.js
Outdated
Show resolved
Hide resolved
@allroundexperts I made some adjustments.
This also should be fixed |
Added your device to the provisioning profile, hopefully it will work next |
Dang, still having that same integrity error. |
Ok it works for me, I will ask in Slack what else is required. |
Started a build with new provisioning profile 🤞 |
🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪 |
Dang, I still can't install iOS. |
Dang, I am not sure whats next, this should have the new profile with your deviceID in it |
Hey, I see there are still a few style related things to fix. I would like to propose to implement them after the rest of the global navigation logic. There are a few factors why I am considering it:
Of course, I can understand the reasons for merging only style perfect PR with the main. On the other hand, it's not about ignoring all these valuable comments on how to improve the look of the app. It's about moving them later in the production cycle. I would be happy to hear your opinion on this. I think this option is worth considering but I will be happy with any decision. cc: @hayata-suenaga @shawnborton @s77rt @allroundexperts @mountiny |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamgrzybowski I agree with shipping this one so the community can catch any bigger bugs/ deeplinks and whatnot which we might be missing here and holding the merge on styling updates now would not be worth it. Great job on this PR!
@shawnborton I think we can collect the styling feedback on one issue and ask C+ to handle it as they have the best experience with the app codebase and they can address that fast, curious if you agree
@hayata-suenaga @stitesExpensify up to you and all yours 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job and thank you for suggesting the idea of merging PR first and making style adjustments later 🙌
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.80-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.80-3 🚀
|
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.81-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
2 similar comments
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀
|
Details
The v1 version of the global navigation. Only one option "Chats" is included.
Fixed Issues
$ #27000
PROPOSAL:
Tests
Confirm the new Global Nav component appears as expected
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
Mobile Web - Safari
Desktop
desktop.mov
iOS
Android