[TS migration] Migrate 'BankAccounts.js' lib to TypeScript #28316

VickyStash · 2023-09-27T13:05:15Z

Details

Fixed Issues

$ #24903
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Make sure you are using the staging server (Settings -> Preferences -> Use staging server)

Open Settings -> Wallet
Click on Add payment method -> Bank Account
Press Continue inside the Plaid modal
Select the bank to link and progress with the necessary steps
Select the bank account to use -> bank account should be successfully added
Click on the added bank account -> press Delete -> make sure the account was deleted

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

Make sure you are using the staging server (Settings -> Preferences -> Use staging server)

Open Settings -> Wallet
Click on Add payment method -> Bank Account
Press Continue inside the Plaid modal
Select the bank to link and progress with the necessary steps
Select the bank account to use -> bank account should be successfully added
Click on the added bank account -> press Delete -> make sure the account was deleted

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Android.google.mov

Mobile Web - Safari

ios.safari.mov

Desktop

Desktop.mov

iOS

ios.mov

Android

android.mp4

src/libs/actions/BankAccounts.ts

rezkiy37

Left a few comments. Overall, LGTM.

src/libs/actions/BankAccounts.ts

src/types/onyx/Request.ts

src/libs/actions/BankAccounts.ts

blazejkustra · 2023-10-11T11:46:58Z

@VickyStash Is this PR ready for cross review?

VickyStash · 2023-10-11T12:00:22Z

@blazejkustra The only blocker here is that this PR has OnyxData type declared and your API PR also has it, if it's ok then I can mark it as ready for cross review

blazejkustra · 2023-10-11T12:21:39Z

@VickyStash Don't worry, we can clean that in the '[TS migration] Review and clean up Libs files' PR.

src/types/onyx/PersonalBankAccount.ts

src/libs/actions/BankAccounts.ts

melvin-bot · 2023-10-11T14:39:12Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ollyws · 2023-10-12T11:40:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

01_MacOS_Chrome.mp4

Mobile Web - Chrome

02_Android_Chrome.mp4

Mobile Web - Safari

03_iOS_Safari.mp4

Desktop

04_MacOS_Desktop.mp4

iOS

05_iOS_Native.mp4

Android

06_Android_Native.mp4

Ollyws

LGTM

melvin-bot · 2023-10-12T11:41:21Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #24903 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

tgolen · 2023-10-12T14:33:22Z

src/libs/actions/BankAccounts.ts

    const commandName = 'ConnectBankAccountWithPlaid';

-    const parameters = {
+    type ConnectBankAccountWithPlaidParams = {


Why is this type defined inline while other types exist in separate files or at the top of this file? My understanding was that all types should exist in their own file.

tgolen · 2023-10-12T14:33:38Z

src/libs/actions/BankAccounts.ts

    const commandName = 'AddPersonalBankAccount';

-    const parameters = {
+    type AddPersonalBankAccountParams = {


tgolen · 2023-10-12T14:33:56Z

src/libs/actions/BankAccounts.ts

-        },
-    );
+function deletePaymentBankAccount(bankAccountID: number) {
+    type DeletePaymentBankAccountParams = {bankAccountID: number};


Same - OK, if I see any more, I'm going to skip commenting on them.

Ah, I see now that maybe this is the pattern to follow for params to API calls?

I wonder if there is a good reason for still not wanting to define them in their own files... 🤔

@tgolen Yeah, we agreed to define API params types like this for now. As I know, we are going to improve API typing in the future, so it can be put in a separate file then
^^ @blazejkustra @kubabutkiewicz

Yes @tgolen there was a message from @fabioh8010 that we will follow this for now

I'm totally on board with that approach. Thanks for making me aware of it!

tgolen · 2023-10-12T14:37:44Z

src/libs/actions/BankAccounts.ts

 }

-function openReimbursementAccountPage(stepToOpen, subStep, localCurrentStep) {
-    const onyxData = {
+function openReimbursementAccountPage(stepToOpen: string, subStep: string, localCurrentStep: string) {


It looks like stepToOpen comes from this:

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Lines 209 to 224 in 34c2a27

switch (lodashGet(this.props.route, ['params', 'stepToOpen'], '')) {

case 'new':

return CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT;

case 'company':

return CONST.BANK_ACCOUNT.STEP.COMPANY;

case 'personal-information':

return CONST.BANK_ACCOUNT.STEP.REQUESTOR;

case 'contract':

return CONST.BANK_ACCOUNT.STEP.ACH_CONTRACT;

case 'validate':

return CONST.BANK_ACCOUNT.STEP.VALIDATION;

case 'enable':

return CONST.BANK_ACCOUNT.STEP.ENABLE;

default:

return '';

}

Instead of using a type of string, how about using something more like ValueOf<typeof CONST.BANK_ACCOUNT.STEP>

@tgolen Updated

tgolen · 2023-10-12T14:38:29Z

src/libs/actions/BankAccounts.ts

@@ -300,122 +305,104 @@ function openReimbursementAccountPage(stepToOpen, subStep, localCurrentStep) {
        ],
    };

-    const param = {
+    type OpenReimbursementAccountPageParams = {
+        stepToOpen: string;


Same comment here about using ValueOf

tgolen · 2023-10-12T14:39:42Z

src/libs/actions/BankAccounts.ts

-function updateBeneficialOwnersForBankAccount(params) {
-    API.write('UpdateBeneficialOwnersForBankAccount', {...params}, getVBBADataForOnyx());
+function updateBeneficialOwnersForBankAccount(params: ACHContractStepProps) {
+    API.write('UpdateBeneficialOwnersForBankAccount', params, getVBBADataForOnyx());


Are you sure there is no problem with removing the spread operator (like, maybe it was there to ensure something wasn't passed by reference)?

@tgolen I've found only one usage of this function and it looks like it should be ok
https://github.com/Expensify/App/blob/main/src/pages/ReimbursementAccount/ACHContractStep.js#L137

tgolen · 2023-10-13T16:19:30Z

Ah, sorry. There is a conflict now.

# Conflicts: # src/libs/actions/BankAccounts.ts

VickyStash · 2023-10-16T07:48:56Z

@tgolen I've resolved conflicts and fixed a couple of TS errors after that

tgolen

OK, thanks! Could you also please remove No QA from the issue title? QA should be able to test out this flow to ensure there were no regressions.

VickyStash · 2023-10-16T15:27:55Z

@tgolen Sure, done

OSBotify · 2023-10-16T16:28:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-16T21:47:57Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-17T23:12:42Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-17T23:58:51Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-18T23:56:21Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

VickyStash added 2 commits September 27, 2023 14:14

[TS migration] Migrate 'BankAccounts.js' lib

d0460ae

Add OnyxData type

f54ac08

rezkiy37 reviewed Sep 27, 2023

View reviewed changes

src/libs/actions/BankAccounts.ts Outdated Show resolved Hide resolved

rezkiy37 reviewed Sep 27, 2023

View reviewed changes

src/libs/actions/BankAccounts.ts Outdated Show resolved Hide resolved

rezkiy37 reviewed Sep 27, 2023

View reviewed changes

BeeMargarida reviewed Sep 27, 2023

View reviewed changes

src/libs/actions/BankAccounts.ts Outdated Show resolved Hide resolved

fabioh8010 reviewed Sep 27, 2023

View reviewed changes

VickyStash added 4 commits September 28, 2023 17:50

Merge branch 'main' into ts-migration/bank-accounts-lib

604fa02

Merge branch 'main' into ts-migration/bank-accounts-lib

92c370d

Add types for API calls params

0a325e1

Merge branch 'main' into ts-migration/bank-accounts-lib

831f486

fabioh8010 mentioned this pull request Oct 2, 2023

[TS] Allow deep null values on merge operations Expensify/react-native-onyx#381

Merged

Merge branch 'main' into ts-migration/bank-accounts-lib

da5c57e

fabioh8010 mentioned this pull request Oct 3, 2023

[No QA] Upgrade react-native-onyx to 1.0.98 #28725

Merged

57 tasks

VickyStash added 2 commits October 3, 2023 17:58

Merge branch 'main' into ts-migration/bank-accounts-lib

1e644a8

Types updates

2f8d51f

fabioh8010 reviewed Oct 3, 2023

View reviewed changes

src/libs/actions/BankAccounts.ts Outdated Show resolved Hide resolved

fabioh8010 approved these changes Oct 3, 2023

View reviewed changes

VickyStash added 3 commits October 3, 2023 18:38

Remove extra type

3738181

Merge branch 'main' into ts-migration/bank-accounts-lib

8013c20

Rename error_description to errorDescription

1b1c044

blazejkustra suggested changes Oct 11, 2023

View reviewed changes

src/types/onyx/PersonalBankAccount.ts Show resolved Hide resolved

src/libs/actions/BankAccounts.ts Show resolved Hide resolved

Type api requests onyxData as OnyxData

cbe27b1

blazejkustra approved these changes Oct 11, 2023

View reviewed changes

VickyStash marked this pull request as ready for review October 11, 2023 14:39

VickyStash requested a review from a team as a code owner October 11, 2023 14:39

melvin-bot bot removed the request for review from a team October 11, 2023 14:39

melvin-bot bot requested a review from Ollyws October 11, 2023 14:39

Ollyws approved these changes Oct 12, 2023

View reviewed changes

melvin-bot bot requested a review from tgolen October 12, 2023 11:41

tgolen requested changes Oct 12, 2023

View reviewed changes

Add bank account step type

aa0a6ce

tgolen previously approved these changes Oct 13, 2023

View reviewed changes

VickyStash added 2 commits October 13, 2023 18:31

Merge branch 'main' into ts-migration/bank-accounts-lib

0aa6dfb

# Conflicts: # src/libs/actions/BankAccounts.ts

Fix ts errors after merging main

3c0246c

VickyStash dismissed tgolen’s stale review via 3c0246c October 16, 2023 07:01

Merge branch 'main' into ts-migration/bank-accounts-lib

9d99ed0

# Conflicts: # src/libs/actions/BankAccounts.ts

tgolen approved these changes Oct 16, 2023

View reviewed changes

VickyStash changed the title ~~[No QA] [TS migration] Migrate 'BankAccounts.js' lib to TypeScript~~ [TS migration] Migrate 'BankAccounts.js' lib to TypeScript Oct 16, 2023

tgolen merged commit a456ef9 into Expensify:main Oct 16, 2023
14 checks passed

OSBotify mentioned this pull request Oct 16, 2023

Deploy Checklist: New Expensify 2023-10-16 #29717

Closed

lanitochka17 mentioned this pull request Oct 17, 2023

[$500] Wallet - Wallet page does not update instantly when bank account is added or deleted #29767

Closed

6 tasks

melvin-bot bot mentioned this pull request Oct 17, 2023

[HOLD for payment 2023-10-24] [TS migration] Migrate 'BankAccounts.js' lib to TypeScript #24903

Closed

OSBotify mentioned this pull request Oct 17, 2023

Deploy Checklist: New Expensify 2023-10-17 #29837

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'BankAccounts.js' lib to TypeScript #28316

[TS migration] Migrate 'BankAccounts.js' lib to TypeScript #28316

VickyStash commented Sep 27, 2023 •

edited

Loading

rezkiy37 left a comment

blazejkustra commented Oct 11, 2023

VickyStash commented Oct 11, 2023

blazejkustra commented Oct 11, 2023

melvin-bot bot commented Oct 11, 2023

Ollyws commented Oct 12, 2023

Ollyws left a comment

melvin-bot bot commented Oct 12, 2023

tgolen Oct 12, 2023

tgolen Oct 12, 2023

tgolen Oct 12, 2023

tgolen Oct 12, 2023

tgolen Oct 12, 2023

VickyStash Oct 12, 2023

kubabutkiewicz Oct 12, 2023

tgolen Oct 13, 2023

tgolen Oct 12, 2023

VickyStash Oct 12, 2023

tgolen Oct 12, 2023

tgolen Oct 12, 2023

VickyStash Oct 12, 2023

tgolen commented Oct 13, 2023

VickyStash commented Oct 16, 2023

tgolen left a comment

VickyStash commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 18, 2023

	switch (lodashGet(this.props.route, ['params', 'stepToOpen'], '')) {
	case 'new':
	return CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT;
	case 'company':
	return CONST.BANK_ACCOUNT.STEP.COMPANY;
	case 'personal-information':
	return CONST.BANK_ACCOUNT.STEP.REQUESTOR;
	case 'contract':
	return CONST.BANK_ACCOUNT.STEP.ACH_CONTRACT;
	case 'validate':
	return CONST.BANK_ACCOUNT.STEP.VALIDATION;
	case 'enable':
	return CONST.BANK_ACCOUNT.STEP.ENABLE;
	default:
	return '';
	}

[TS migration] Migrate 'BankAccounts.js' lib to TypeScript #28316

[TS migration] Migrate 'BankAccounts.js' lib to TypeScript #28316

Conversation

VickyStash commented Sep 27, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rezkiy37 left a comment

Choose a reason for hiding this comment

blazejkustra commented Oct 11, 2023

VickyStash commented Oct 11, 2023

blazejkustra commented Oct 11, 2023

melvin-bot bot commented Oct 11, 2023

Ollyws commented Oct 12, 2023

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tgolen commented Oct 13, 2023

VickyStash commented Oct 16, 2023

tgolen left a comment

Choose a reason for hiding this comment

VickyStash commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 18, 2023

VickyStash commented Sep 27, 2023 •

edited

Loading