Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Plan-Types.md #28348

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Update Plan-Types.md #28348

merged 4 commits into from
Oct 9, 2023

Conversation

NicMendonca
Copy link
Contributor

@NicMendonca NicMendonca commented Sep 27, 2023

https://github.com/Expensify/Expensify/issues/311411

Details

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

@NicMendonca NicMendonca requested a review from a team September 27, 2023 20:12
@NicMendonca NicMendonca self-assigned this Sep 27, 2023
@melvin-bot melvin-bot bot requested review from dangrous and removed request for a team September 27, 2023 20:13
@melvin-bot
Copy link

melvin-bot bot commented Sep 27, 2023

@dangrous Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Contributor

@dangrous dangrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor changes, looks good otherwise!

@dangrous dangrous requested a review from rushatgabhane October 2, 2023 15:16
@@ -2,4 +2,31 @@
title: Plan-Types
description: Plan-Types
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the description. It'll be used for SEO purposes

updating description as per SEO
Copy link
Contributor Author

@NicMendonca NicMendonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating description for SEO

Copy link
Member

@rushatgabhane rushatgabhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dangrous LGTM!

image

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

@melvin-bot melvin-bot bot requested a review from stitesExpensify October 3, 2023 00:26
@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #28667.

@stitesExpensify
Copy link
Contributor

@NicMendonca can you fill out the checklist please? Most of it is probably not related to this change, but it is required to check everything off (even the non-applicable ones) for us to merge the PR

@NicMendonca
Copy link
Contributor Author

@stitesExpensify sorry for the delay! done!

Copy link
Contributor

@dangrous dangrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one remaining change I think but otherwise looks great!

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 757c3dc
Status: ✅  Deploy successful!
Preview URL: https://2e5fb2d1.helpdot.pages.dev
Branch Preview URL: https://nicmendonca-patch-2.helpdot.pages.dev

View logs

@stitesExpensify stitesExpensify requested a review from a team as a code owner October 5, 2023 23:26
@melvin-bot melvin-bot bot removed the request for review from a team October 5, 2023 23:26
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Contributor

@stitesExpensify stitesExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marged main myself to get cloudflare pages to work

@stitesExpensify
Copy link
Contributor

All yours @dangrous

@dangrous dangrous merged commit 8697379 into main Oct 9, 2023
14 checks passed
@dangrous dangrous deleted the NicMendonca-patch-2 branch October 9, 2023 20:08
@OSBotify
Copy link
Contributor

OSBotify commented Oct 9, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1240.481 ms → 1351.865 ms (+111.384 ms, +9.0%) 🔴
App start runJsBundle 858.133 ms → 944.736 ms (+86.603 ms, +10.1%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1240.481 ms
Stdev: 39.534 ms (3.2%)
Runs: 1149.1966999999713 1158.8140040000435 1160.044685000088 1166.7553260000423 1169.753150000004 1176.8763629999012 1180.223071000073 1181.9991280001123 1183.1867329999804 1183.407908000052 1193.1189870000817 1193.4327750001103 1193.8675659999717 1195.0947259999812 1197.0495430000592 1197.2683290001005 1201.1962210000493 1201.661342999898 1205.9625580001157 1206.0550949999597 1209.1902890000492 1210.4618989999872 1211.1247690001037 1211.4234740000684 1215.0894649999682 1216.6840280001052 1218.1032889999915 1220.3208250000607 1224.3808540001046 1228.943037000019 1230.0605649999343 1230.687084000092 1231.4944929999765 1233.5302059999667 1234.1217239999678 1236.2694339998998 1236.276925999904 1236.3096459999215 1236.8898899999913 1237.7579870000482 1237.9262089999393 1238.7704479999375 1239.0859000000637 1239.1375839998946 1239.6046949999873 1240.2567700000945 1240.2961130000185 1241.1586279999465 1242.2794200000353 1244.297196000116 1244.9296919999178 1246.473432000028 1247.6302579999901 1247.9091809999663 1250.611883000005 1254.5601910001133 1256.7877809999045 1257.0468399999663 1257.9609980001114 1260.1779219999444 1263.1074320001062 1263.5186209999956 1263.5765929999761 1265.3437179999892 1266.5285400000867 1266.9111460000277 1267.3855940001085 1268.2191240000539 1268.3532090000808 1269.1336950000841 1269.2448150001 1269.2778660000768 1272.5091109999921 1273.2495170000475 1273.376186999958 1273.811226000078 1274.9340460000094 1281.0074330000207 1282.7396060000174 1284.2396140000783 1284.5654720000457 1285.3199020000175 1285.8951709999237 1292.6320549999364 1293.0118400000501 1300.9609379998874 1301.1587900000159 1311.5936259999871 1313.3285230000038 1314.762737999903 1353.069453000091

Current
Mean: 1351.865 ms
Stdev: 58.724 ms (4.3%)
Runs: 1213.0860890001059 1230.0783159998246 1241.353482999839 1259.6483900002204 1265.3578599998727 1275.1542440000921 1278.663687999826 1283.153204999864 1286.2205360000953 1289.1560060000047 1293.0893620001152 1296.9694139999337 1297.243104999885 1298.6216139998287 1298.851724000182 1299.1534440000542 1300.725240000058 1301.9756909999996 1304.4677380002104 1307.2417830000632 1309.3483279999346 1309.5892880000174 1311.216947000008 1312.2815769999288 1312.4458710001782 1312.8568600001745 1312.9344270001166 1313.0930030001327 1318.6256780000404 1319.7016569999978 1322.045406000223 1324.258113999851 1324.3761200001463 1325.1885139998049 1325.7030939999968 1325.894677999895 1327.1947329998948 1329.0890219998546 1332.6249540001154 1334.953125 1336.688463000115 1340.9840259999037 1340.9847940001637 1341.5744409998879 1343.2135760001838 1343.225316000171 1345.0863740001805 1346.4048520000651 1347.306365000084 1352.7935739997774 1357.3071039998904 1358.913887000177 1359.4899880001321 1367.257184999995 1368.146875999868 1368.9886119998991 1369.61222000001 1370.8472070000134 1374.2867470001802 1376.7405829997733 1377.0010870001279 1377.1488069999032 1377.2732339999638 1377.5260950000957 1378.4490359998308 1380.4808510001749 1383.6111759999767 1384.2276949998923 1391.911989999935 1392.3227039999329 1394.4794950000942 1395.3655340000987 1398.734561999794 1399.585101999808 1402.986024999991 1411.4400749998167 1417.37528999988 1423.1731039998122 1424.8463480002247 1425.530902999919 1426.3249209998176 1428.343313000165 1449.1245590001345 1451.4902470000088 1456.5970549997874 1457.709962000139 1470.2282890002243 1474.5777830001898 1497.4638299997896 1509.044021999929
App start runJsBundle Baseline
Mean: 858.133 ms
Stdev: 30.853 ms (3.6%)
Runs: 790 790 796 802 803 807 808 811 811 820 823 823 824 826 826 828 829 832 832 835 836 836 837 841 843 844 845 845 845 845 845 846 847 848 848 848 851 851 852 854 854 856 856 857 857 858 858 858 861 863 863 864 864 865 865 867 867 869 870 871 871 874 874 874 875 877 878 878 879 880 881 882 887 888 894 896 896 897 898 898 899 899 901 906 906 907 911 916 921 923

Current
Mean: 944.736 ms
Stdev: 42.169 ms (4.5%)
Runs: 843 870 875 880 881 881 885 889 893 895 895 897 899 900 901 901 902 904 906 908 909 911 911 912 915 917 918 922 922 923 923 924 925 925 925 926 930 933 934 934 937 937 938 938 939 939 939 940 942 945 947 947 950 951 955 959 961 962 962 965 966 970 971 972 973 973 975 976 977 978 979 982 983 984 986 987 988 991 992 992 994 1002 1003 1006 1007 1017 1017 1023 1034 1037 1039

Meaningless Changes To Duration

Show entries
Name Duration
App start nativeLaunch 21.730 ms → 22.567 ms (+0.836 ms, +3.8%)
App start regularAppStart 0.015 ms → 0.016 ms (+0.001 ms, +7.2%)
Open Search Page TTI 634.104 ms → 630.920 ms (-3.184 ms, -0.5%)
Show details
Name Duration
App start nativeLaunch Baseline
Mean: 21.730 ms
Stdev: 3.046 ms (14.0%)
Runs: 18 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 23 23 24 24 24 24 24 24 25 25 25 26 26 27 27 27 28 28 28 29 29 29 29 30

Current
Mean: 22.567 ms
Stdev: 2.875 ms (12.7%)
Runs: 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 24 24 24 24 24 24 25 25 25 25 26 26 26 26 26 26 26 27 27 27 28 28 28 29 30 30 31
App start regularAppStart Baseline
Mean: 0.015 ms
Stdev: 0.001 ms (6.3%)
Runs: 0.013182999799028039 0.013264999957755208 0.013386999955400825 0.013428000034764409 0.013671000022441149 0.01371199986897409 0.014038000022992492 0.014038000022992492 0.014038000022992492 0.014038000022992492 0.014038000022992492 0.01412000018171966 0.014160000020638108 0.014160000020638108 0.0142000000923872 0.014200999867171049 0.014201000100001693 0.014322999864816666 0.01432300009764731 0.014362999936565757 0.014405000023543835 0.014445000095292926 0.014485999941825867 0.014526000013574958 0.014567000092938542 0.014648000011220574 0.0147299999371171 0.014730000169947743 0.014770000008866191 0.014771000016480684 0.014771000016480684 0.014892999781295657 0.014892999781295657 0.014933000085875392 0.014933000085875392 0.015014000004157424 0.015015000011771917 0.01509599993005395 0.01509599993005395 0.01513600000180304 0.015137000009417534 0.015137000009417534 0.015217999927699566 0.01521899993531406 0.015257999999448657 0.015258999774232507 0.01525900000706315 0.015299999853596091 0.015339999925345182 0.015379999997094274 0.015381000004708767 0.015381000004708767 0.015420999843627214 0.015461999922990799 0.015461999922990799 0.015462999930605292 0.015543000074103475 0.01558400015346706 0.015585000161081553 0.01566500007174909 0.01566599984653294 0.015705999918282032 0.015705999918282032 0.015787999844178557 0.015787999844178557 0.015787999844178557 0.01582799991592765 0.015828999923542142 0.015910000074654818 0.01595000014640391 0.01595000014640391 0.01595000014640391 0.01599099999293685 0.015992000000551343 0.01603100006468594 0.016316999914124608 0.016357999993488193 0.016561000142246485 0.016600999981164932 0.016601999988779426 0.016601999988779426 0.0166830001398921 0.0166830001398921 0.017089999979361892 0.017131000058725476 0.017333999974653125 0.017699999967589974

Current
Mean: 0.016 ms
Stdev: 0.001 ms (5.5%)
Runs: 0.014119000174105167 0.014323000330477953 0.014444999862462282 0.014525999780744314 0.014607999939471483 0.014851999934762716 0.015054999850690365 0.01509599993005395 0.015177000313997269 0.015299000311642885 0.015300000086426735 0.015339999925345182 0.01534100016579032 0.015422000084072351 0.015462000388652086 0.015544000081717968 0.015625 0.015666000079363585 0.015705999918282032 0.015705999918282032 0.015705999918282032 0.015746999997645617 0.015786999836564064 0.015868999995291233 0.015868999995291233 0.01587000023573637 0.015910000074654818 0.015910000074654818 0.015949999913573265 0.015950999688357115 0.015951000154018402 0.01599099999293685 0.01607300015166402 0.016113999765366316 0.016113999765366316 0.01615400006994605 0.016195000149309635 0.016234999988228083 0.016235999763011932 0.01623600022867322 0.016276000067591667 0.016316999681293964 0.01631700014695525 0.01631700014695525 0.01631700014695525 0.01635799976065755 0.016398000065237284 0.01643899967893958 0.016439000144600868 0.016478999983519316 0.016480000223964453 0.0165200000628829 0.0165200000628829 0.016560999676585197 0.016561000142246485 0.016561000142246485 0.016600999981164932 0.01660200022161007 0.01664199959486723 0.016642000060528517 0.016642000060528517 0.016642999835312366 0.016682999674230814 0.016805000137537718 0.016805000137537718 0.01688600005581975 0.01688600005581975 0.016926999669522047 0.01696800021454692 0.017008000053465366 0.01704900013282895 0.017212000209838152 0.017212000209838152 0.017251999583095312 0.0172520000487566 0.0172520000487566 0.017374999821186066 0.0174150001257658 0.017455999739468098 0.017740999814122915 0.0177819998934865 0.01806599972769618 0.018106999807059765 0.018554999958723783 0.018635999877005816
Open Search Page TTI Baseline
Mean: 634.104 ms
Stdev: 25.355 ms (4.0%)
Runs: 593.9123539999127 596.4791259998456 602.5589610000607 603.1824949998409 603.4023440000601 603.5658780001104 604.0298669999465 607.1832680001389 608.1279299999587 608.9308670000173 609.4364420000929 609.9254150001798 610.2533769998699 610.3058680000249 610.8850110000931 611.9627680000849 612.1768399998546 612.3633629998658 612.5274259997532 612.6486420002766 612.7449550000019 613.977213999955 614.0309249998536 614.166300999932 614.4675299995579 615.5875249998644 616.0413000001572 616.4724939996377 618.9774579997174 619.5442300001159 619.8693850003183 619.9572760001756 620.0262859999202 621.007040000055 621.4979250000324 621.7790529998019 621.999715999933 622.2651370000094 622.7288420000114 624.4628909998573 624.9119070000015 626.4127200001385 627.5241290000267 627.6621499999892 627.6706550000235 628.7113439999521 629.9838460001629 630.2229410000145 630.3983559999615 630.986654000124 631.2097569997422 631.9556479998864 633.3717040000483 634.8265789998695 634.8745120000094 635.3098150000442 635.4668780001812 635.9770100000314 636.1214189999737 636.9785160000902 637.1527509996668 637.1837160000578 637.7283119999338 638.2274989997968 644.1532389998902 644.2621670002118 646.850097999908 651.5639649997465 651.6151939998381 651.765788000077 655.3089189999737 656.3883869999554 657.2328700001817 659.2196859999094 659.7478440001141 660.5316979999188 661.720336999977 661.8152669998817 662.7624919998925 663.2546800000127 663.6864020000212 668.2569589999039 670.1899009998888 670.518962000031 673.3895270000212 677.0625 680.5437829999719 691.5750329999719 701.031413000077 705.131347999908 717.5917159998789

Current
Mean: 630.920 ms
Stdev: 20.559 ms (3.3%)
Runs: 598.2615970000625 600.9499920001253 604.6843670001253 606.5581869999878 607.2838960001245 608.6922209998593 608.9441729998216 609.2078450000845 609.7930910000578 610.3592530000024 612.2110999999568 612.5617680000141 612.7018239996396 613.0038659996353 613.1362299998291 613.9685880001634 614.0004070000723 614.1919760000892 614.2309570000507 614.3769940002821 614.4614260001108 614.4646399999037 614.6648360001855 614.8687340002507 615.4139000000432 615.8684899997897 615.9207359999418 616.4347740001976 617.878052000422 618.1040850002319 620.2969979997724 620.9971519997343 621.077432999853 621.3767909999005 621.3846430000849 621.5911059998907 621.8555910000578 621.8645430002362 622.4296880001202 622.9189860001206 622.9916179999709 623.2053629998118 623.8797610001639 624.6084400000982 625.9102380000986 626.9491380001418 626.9970289999619 628.5428470000625 628.8004560000263 628.8503419999033 629.6831470001489 629.9607340004295 630.0136310001835 630.5375169999897 631.0710040000267 632.8572189998813 633.8550619999878 634.9482829999179 635.4660649998114 637.2235110001639 637.7893469999544 638.382203000132 638.4508870001882 639.393717000261 639.8016770002432 640.2441409998573 641.4651290001348 641.9615480001085 645.4833990000188 647.2363280002028 647.5635179998353 647.6107180002145 649.0868330001831 649.5741789997555 650.3267009998672 652.5155030000024 655.8848470002413 657.2920340001583 657.6350909997709 659.654826999642 660.5905360002071 673.5763759999536 673.8063970003277 674.6412349999882 681.5882979999296 683.1694339998066 683.7576100002043 693.1609299997799

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 9, 2023

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.80-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.80-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.81-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

2 similar comments
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants