-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Update Lyft.md #28429
[NoQA] Update Lyft.md #28429
Conversation
Updated to add the relevant photos from the image repo
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
docs/articles/expensify-classic/integrations/travel-integrations/Lyft.md
Outdated
Show resolved
Hide resolved
…ns/Lyft.md Co-authored-by: Yuwen Memon <yuwen@expensify.com>
@miljakljajic this is what we want
|
docs/articles/expensify-classic/integrations/travel-integrations/Lyft.md
Outdated
Show resolved
Hide resolved
made the suggested updates! |
…ns/Lyft.md Co-authored-by: Yuwen Memon <yuwen@expensify.com>
@miljakljajic Can you sign the CLA? https://stackoverflowteams.com/c/expensify/questions/7660 |
Also, can you find another reviewer? I'm headed out on sabbatical! (Also you need to fill out the checklist 😉) |
docs/articles/expensify-classic/integrations/travel-integrations/Lyft.md
Outdated
Show resolved
Hide resolved
docs/articles/expensify-classic/integrations/travel-integrations/Lyft.md
Outdated
Show resolved
Hide resolved
…ns/Lyft.md Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>
I have read the CLA Document and I hereby sign the CLA |
…ns/Lyft.md Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>
![Alt text for accessibility] | ||
(https://help.expensify.com/assets/images/ExpensifyHelp_Lyft_01.png){:width="100%"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's supposed to be a new image committed in this PR as well? This one doesn't seem to exist in the repo yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll be up soon: #28425
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the caption on the file in miljakljajic-patch-4
docs/articles/expensify-classic/integrations/travel-integrations/Lyft.md
Outdated
Show resolved
Hide resolved
…ns/Lyft.md Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>
Made the suggested updates to the Lyft photo caption
I have read the CLA Document and I hereby sign the CLA |
docs/articles/expensify-classic/integrations/travel-integrations/Lyft.md
Outdated
Show resolved
Hide resolved
…ns/Lyft.md Co-authored-by: Francois Laithier <francois@expensify.com>
@miljakljajic why did you make another pull request for the same file at the same time? This branch looks good as it stands, but now there's a conflict because of that other PR that was just merged. |
The text looks mostly the same (except the last sentence and the page title/description), I'll help resolve the conflicts. We'll use the existing copy from |
4da6615
to
4975bca
Compare
Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.78-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀
|
🚀 Deployed to staging by https://github.com/francoisl in version: 1.3.79-0 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀
|
Updated to add the relevant photos from the image repo
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/311465
PROPOSAL:
Tests
Offline tests
QA Steps
No QA
PR Author Checklist
Tests
sectionOffline steps
sectionQA steps
sectionthis
properlyScrollView
component to make it scrollable when more elements are added to the pagemain
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
stepsScreenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android