Fix navigation breaks on opening search page after reloading the attachment #28486

dukenv0307 · 2023-09-29T13:38:39Z

Details

Fixed Issues

Tests

Note: PopoverWithoutOverlay is only used on Web and Desktop so we just might add the video and test on Web and Desktop

Open any report
Send an attachment
Click on the attachment to open the preview modal
Reload the page
Press CMD + K or Ctrl + K to open search page
Verify that the attachment is closed and the search page appears

Verify that no errors appear in the JS console

Offline tests

QA Steps

Note: PopoverWithoutOverlay is only used on Web and Desktop so we just might add the video and test on Web and Desktop

Open any report
Send an attachment
Click on the attachment to open the preview modal
Reload the page
Press CMD + K or Ctrl + K to open search page
Verify that the attachment is closed and the search page appears

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-09-29.at.17.58.03.mov

Mobile Web - Chrome

Record_2023-10-07-19-44-36.mp4

Mobile Web - Safari

Screen.Recording.2023-10-07.at.19.47.16.mov

Desktop

Screen.Recording.2023-09-29.at.20.39.11.mov

iOS

Screen.Recording.2023-10-07.at.20.10.15.mov

Android

Screen.Recording.2023-10-07.at.20.14.51.mov

melvin-bot · 2023-10-04T03:47:11Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2023-10-05T20:37:38Z

src/components/PopoverWithoutOverlay/index.js

@@ -38,11 +40,14 @@ function Popover(props) {
            Modal.onModalDidClose();
        }
        Modal.willAlertModalBecomeVisible(props.isVisible);
+        if (prevIsVisible === props.isVisible) {


Please add an explanatory comment.

src/components/PopoverWithoutOverlay/index.js

parasharrajat · 2023-10-05T21:11:02Z

Please attach videos for all platforms. If some of them are not applicable, we can show a working video of functionality related to the issue.

Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>

dukenv0307 · 2023-10-07T13:18:24Z

@parasharrajat I update all screenshots and comment

parasharrajat · 2023-10-07T15:40:24Z

src/components/PopoverWithoutOverlay/index.js

@@ -37,11 +40,16 @@ function Popover(props) {
            Modal.onModalDidClose();
        }
        Modal.willAlertModalBecomeVisible(props.isVisible);
+
+        // We prevent setting closeModal function to null when the first time the component is rendered
+        if (prevIsVisible === props.isVisible) {


Question: What if the modal is mounted and the first-time value for isVisible is true? Shouldn't the further logic be triggered in that case?

For example,

<Component isVisible />

Wouldn't this prevent close Modal to be set?

I think this is fine because in the app the popover is invisible by default.

What if the modal is mounted and the first-time value for isVisible is true?

If we want to cover that case we can create a firstRenderRef to check this case.

So this component is a widely used component. I would prefer if we handled that case here as well just to be on the safer side. Thanks for waiting, I was doing some research on it.

@parasharrajat I just updated.

src/components/PopoverWithoutOverlay/index.js

Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>

parasharrajat · 2023-10-09T09:07:16Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-10-09.at.3.14.56.PM.mov

🔲 iOS / Safari

Screen.Recording.2023-10-09.at.3.14.08.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-10-09.at.2.38.34.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-10-09.at.2.36.16.PM.mov

🔲 Android / Chrome

Screen.Recording.2023-10-09.at.3.01.51.PM.mov

🔲 Android / native

Screen.Recording.2023-10-09.at.2.49.59.PM.mov

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

deetergp

Looks good and tests well 👍

OSBotify · 2023-10-09T16:16:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-09T23:01:04Z

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.80-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-11T04:41:20Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.80-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-11T05:10:08Z

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.81-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-13T21:59:20Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:11:23Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:27:36Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T23:03:00Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:14:41Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-16T21:51:01Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

dukenv0307 added 3 commits September 27, 2023 15:29

fix: 28241

8ea4f6f

Merge branch 'main' into fix/28241

360d596

fix lint

610b1ae

dukenv0307 marked this pull request as ready for review October 4, 2023 03:46

dukenv0307 requested a review from a team as a code owner October 4, 2023 03:47

melvin-bot bot removed the request for review from a team October 4, 2023 03:47

melvin-bot bot requested a review from parasharrajat October 4, 2023 03:47

parasharrajat reviewed Oct 5, 2023

View reviewed changes

src/components/PopoverWithoutOverlay/index.js Show resolved Hide resolved

dukenv0307 and others added 2 commits October 6, 2023 18:22

Update src/components/PopoverWithoutOverlay/index.js

9e7498a

Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>

add explaination comment

48dc3b6

dukenv0307 added 2 commits October 7, 2023 20:32

fix lint

4378d80

Merge branch 'main' into fix/28241

77fcb70

parasharrajat reviewed Oct 7, 2023

View reviewed changes

dukenv0307 added 2 commits October 8, 2023 15:11

add first render ref

859bccf

update comment

865b027

parasharrajat suggested changes Oct 8, 2023

View reviewed changes

src/components/PopoverWithoutOverlay/index.js Outdated Show resolved Hide resolved

src/components/PopoverWithoutOverlay/index.js Outdated Show resolved Hide resolved

dukenv0307 and others added 3 commits October 8, 2023 15:30

Update src/components/PopoverWithoutOverlay/index.js

ff5cd42

Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>

Update src/components/PopoverWithoutOverlay/index.js

8a18248

Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>

fix lint

7d4892a

parasharrajat approved these changes Oct 9, 2023

View reviewed changes

melvin-bot bot requested a review from deetergp October 9, 2023 09:46

deetergp approved these changes Oct 9, 2023

View reviewed changes

deetergp merged commit 5fb236e into Expensify:main Oct 9, 2023
12 checks passed

OSBotify mentioned this pull request Oct 9, 2023

Deploy Checklist: New Expensify 2023-10-09 #29131

Closed

64 tasks

s-alves10 mentioned this pull request Oct 10, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-18] [$500] Web – Chat - Unable to delete message using Context menu #29159

Closed

6 tasks

melvin-bot bot mentioned this pull request Oct 11, 2023

[$500] Web - Navigation breaks on opening attachment, reload and opening search by shortcut #28241

Closed

6 tasks

OSBotify mentioned this pull request Oct 11, 2023

Deploy Checklist: New Expensify 2023-10-11 #29252

Closed

bernhardoj mentioned this pull request Oct 12, 2023

Fix attachment modal doesn't close when pressing search shortcut #27639

Merged

59 tasks

This was referenced Oct 12, 2023

[HOLD for payment 2023-10-25] [$500] Fab - App disables CTRL+K / CTRL+SHIFT+K shortcuts on FAB menu option pages #29341

Closed

[$125] Web - Keyboard shortcuts don't work on Web #29444

Closed

parasharrajat mentioned this pull request Oct 17, 2023

Revert "Fix navigation breaks on opening search page after reloading the attachment" #29784

Merged

59 tasks

MelvinBot mentioned this pull request Oct 14, 2024

[Snyk] Security upgrade @storybook/addon-essentials from 8.1.10 to 8.2.0 #50717

Closed

50 tasks

melvin-bot bot mentioned this pull request Oct 14, 2024

[Snyk] Security upgrade @storybook/addon-essentials from 8.1.10 to 8.2.0 #50718

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix navigation breaks on opening search page after reloading the attachment #28486

Fix navigation breaks on opening search page after reloading the attachment #28486

dukenv0307 commented Sep 29, 2023 •

edited

Loading

melvin-bot bot commented Oct 4, 2023

parasharrajat Oct 5, 2023

parasharrajat Oct 7, 2023

parasharrajat commented Oct 5, 2023

dukenv0307 commented Oct 7, 2023

parasharrajat Oct 7, 2023 •

edited

Loading

dukenv0307 Oct 7, 2023

dukenv0307 Oct 7, 2023

parasharrajat Oct 8, 2023

dukenv0307 Oct 8, 2023

parasharrajat commented Oct 9, 2023 •

edited

Loading

parasharrajat left a comment

deetergp left a comment

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

Fix navigation breaks on opening search page after reloading the attachment #28486

Fix navigation breaks on opening search page after reloading the attachment #28486

Conversation

dukenv0307 commented Sep 29, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 4, 2023

parasharrajat Oct 5, 2023

Choose a reason for hiding this comment

parasharrajat Oct 7, 2023

Choose a reason for hiding this comment

parasharrajat commented Oct 5, 2023

dukenv0307 commented Oct 7, 2023

parasharrajat Oct 7, 2023 • edited Loading

Choose a reason for hiding this comment

dukenv0307 Oct 7, 2023

Choose a reason for hiding this comment

dukenv0307 Oct 7, 2023

Choose a reason for hiding this comment

parasharrajat Oct 8, 2023

Choose a reason for hiding this comment

dukenv0307 Oct 8, 2023

Choose a reason for hiding this comment

parasharrajat commented Oct 9, 2023 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

deetergp left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

dukenv0307 commented Sep 29, 2023 •

edited

Loading

parasharrajat Oct 7, 2023 •

edited

Loading

parasharrajat commented Oct 9, 2023 •

edited

Loading