Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Viewing a category to a Split Bill #28628

Merged

Conversation

rezkiy37
Copy link
Contributor

@rezkiy37 rezkiy37 commented Oct 2, 2023

Details

We are adding an ability to add a category for a split bill in #27936. Therefore, we need to implement viewing a category on a newly created split bill.

Fixed Issues

$ #28593
PROPOSAL: N/A

Tests

Note: the backend is not ready yet to add and get a category for a split bill. So, we need to mock a situation when we have a category inside a split bill.

Hack: we need to modify getCategory of TransactionUtils.ts. The function should return a hardcode string - name of a category like: return "Home".

  1. Create a split bill with a workspace with a category.
  2. Open "Details" page.
  3. Click on "Show more".
  4. Verify that there is a category field.
  5. Verify that the field is disabled, you cannot interact with it.
  • Verify that no errors appear in the JS console

Offline tests

Same as "Tests".

QA Steps

Same as "Tests".

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web Chrome Safari
Mobile Web - Chrome Android Chrome
Mobile Web - Safari

IOS Safari

Desktop Desktop
iOS

IOS

Android Android

@rezkiy37 rezkiy37 marked this pull request as ready for review October 3, 2023 15:38
@rezkiy37 rezkiy37 requested a review from a team as a code owner October 3, 2023 15:38
@melvin-bot melvin-bot bot requested review from burczu and removed request for a team October 3, 2023 15:38
@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

@burczu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@burczu
Copy link
Contributor

burczu commented Oct 6, 2023

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screenshot 2023-10-06 at 10 43 43

Mobile Web - Chrome

Screenshot 2023-10-06 at 10 54 00

Mobile Web - Safari

Screenshot 2023-10-06 at 10 52 35

Desktop

Screenshot 2023-10-06 at 10 48 09

iOS

Screenshot 2023-10-06 at 10 47 07

Android

Screenshot 2023-10-06 at 10 50 54

Copy link
Contributor

@burczu burczu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot melvin-bot bot requested a review from puneetlath October 6, 2023 08:55
puneetlath
puneetlath previously approved these changes Oct 9, 2023
Copy link
Contributor

@puneetlath puneetlath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you have conflicts @rezkiy37

@rezkiy37
Copy link
Contributor Author

rezkiy37 commented Oct 9, 2023

@puneetlath, conflicts resolved 🙂

@puneetlath puneetlath merged commit 2bae957 into Expensify:main Oct 9, 2023
12 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented Oct 9, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1210.914 ms → 1299.250 ms (+88.336 ms, +7.3%) 🔴
App start runJsBundle 829.978 ms → 890.622 ms (+60.644 ms, +7.3%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1210.914 ms
Stdev: 39.754 ms (3.3%)
Runs: 1109.7634620070457 1128.443090006709 1137.48991599679 1140.1102810055017 1142.7553229928017 1150.2463960051537 1153.1804510056973 1155.5642389953136 1156.0955619961023 1165.0880749970675 1165.2926229983568 1165.6743330061436 1166.644856005907 1170.6283469945192 1172.6335130035877 1174.6359589993954 1177.7767100036144 1179.8644970059395 1182.493955001235 1184.8031029999256 1186.611856997013 1186.7875259965658 1187.0782929956913 1187.1119160056114 1187.4031780064106 1189.833294004202 1190.2346570044756 1191.926357999444 1192.0300630033016 1194.459543004632 1194.8349200040102 1195.4119119942188 1196.3611959964037 1196.5705029964447 1198.824843004346 1199.5365349948406 1200.1195600032806 1200.556854993105 1201.5327219963074 1201.7848549932241 1203.9597720056772 1204.5876020044088 1205.1549479961395 1205.861928999424 1206.1524949967861 1206.7558619976044 1208.5368310064077 1208.9781920015812 1209.0001550018787 1211.0156670063734 1211.3125150054693 1211.5300379991531 1214.2087190002203 1216.4098799973726 1216.520832002163 1221.1308030039072 1221.7463089972734 1223.9779099971056 1226.614894002676 1227.34876999259 1227.7275989949703 1229.2476959973574 1230.3035439997911 1233.199135005474 1234.2354799956083 1235.486523002386 1235.8315470069647 1239.1766590029001 1239.396543994546 1240.6269219964743 1242.6136039942503 1243.246979996562 1247.8665239959955 1247.932326003909 1248.2258830070496 1250.0498059988022 1250.7652219980955 1252.62391500175 1253.5207860022783 1255.3594270050526 1268.7805549949408 1269.990989997983 1271.263943001628 1271.3400930017233 1277.1010590046644 1282.832515001297 1291.2781340032816 1291.4509260058403 1296.8408650010824 1304.9532739967108

Current
Mean: 1299.250 ms
Stdev: 53.252 ms (4.1%)
Runs: 1179.769341006875 1185.1096750050783 1202.3636630028486 1203.0558039993048 1207.1277000010014 1212.8335140049458 1213.6809249967337 1217.0181970000267 1219.4529460072517 1220.929629996419 1223.062723994255 1230.5118010044098 1235.9464589953423 1237.3083759993315 1241.9922350049019 1248.4667849987745 1251.1645759940147 1259.978440001607 1262.3011180013418 1262.3860909938812 1264.7520290017128 1265.5548589974642 1267.4469089955091 1271.556005999446 1272.8112410008907 1274.2049040049314 1275.2927930057049 1278.6501850038767 1279.691501006484 1284.6100559979677 1284.848353996873 1285.34989400208 1285.9497510045767 1286.4272499978542 1287.1348830014467 1287.1376039981842 1287.4036909937859 1287.6103709936142 1287.9680439978838 1288.2241660058498 1289.0877529978752 1289.2563599944115 1291.4948949962854 1294.4772509932518 1301.4808740019798 1301.5253870040178 1302.5728339999914 1302.7190970033407 1304.7818010002375 1305.9316810071468 1306.2700500041246 1308.1546490043402 1310.5403410047293 1310.8166459947824 1311.3300849944353 1313.7557680010796 1315.3238140046597 1317.1231839954853 1319.364520996809 1320.512463003397 1321.4119420051575 1321.4942360073328 1324.371272996068 1327.8979330062866 1328.0182220041752 1328.5007610023022 1330.2575169950724 1336.419994994998 1337.7779220044613 1339.4353780001402 1339.6401190012693 1343.8279729932547 1344.0627450048923 1346.0428339987993 1347.6751639991999 1354.9249359965324 1355.1176320016384 1355.9225859940052 1358.9004919975996 1361.202915996313 1361.788495004177 1361.7996740043163 1364.3067259937525 1378.4923910051584 1383.0707249939442 1383.671431005001 1391.9533620029688 1402.065997004509 1432.2834729999304 1436.5787959992886
App start runJsBundle Baseline
Mean: 829.978 ms
Stdev: 33.118 ms (4.0%)
Runs: 761 762 763 766 771 775 782 786 786 789 790 793 795 795 798 799 801 806 809 809 810 810 811 811 812 815 815 815 816 817 818 818 819 819 820 820 821 821 821 823 824 824 825 825 825 825 826 827 829 831 832 833 834 835 836 838 839 839 841 844 845 845 845 845 846 846 849 850 850 850 853 855 858 861 864 864 867 869 869 870 871 872 882 884 884 884 889 910 910 911

Current
Mean: 890.622 ms
Stdev: 37.788 ms (4.2%)
Runs: 799 816 822 825 828 831 832 834 836 840 842 842 843 844 845 849 852 855 858 861 862 864 864 865 866 867 872 872 872 874 876 876 877 878 878 879 881 881 882 882 883 887 891 891 892 896 896 899 899 900 900 901 901 902 903 904 905 907 907 907 908 911 911 914 915 917 921 921 922 923 923 925 927 929 929 930 930 931 935 935 935 936 940 944 949 952 956 960 965 969

Meaningless Changes To Duration

Show entries
Name Duration
Open Search Page TTI 625.338 ms → 628.571 ms (+3.233 ms, +0.5%)
App start nativeLaunch 22.438 ms → 22.920 ms (+0.482 ms, +2.1%)
App start regularAppStart 0.015 ms → 0.016 ms (+0.001 ms, +9.8%)
Show details
Name Duration
Open Search Page TTI Baseline
Mean: 625.338 ms
Stdev: 20.859 ms (3.3%)
Runs: 593.9698890000582 594.4602459967136 595.6659349948168 596.6531170010567 598.6708980053663 600.3856199979782 601.3021240085363 602.676269993186 602.7508949935436 602.9552009999752 603.7436930090189 603.8146570026875 604.4982910007238 605.7639169991016 605.985799998045 606.2210699915886 607.3022470027208 608.2343350052834 608.5465500056744 609.2274989932775 609.5909430086613 609.9311929941177 610.2998870015144 610.3600260019302 610.5342620015144 610.6056730002165 611.0909020006657 611.3080239892006 612.4678560048342 612.9220380038023 613.1293540000916 613.4058440029621 613.5608320087194 613.9766039997339 613.9863289892673 614.1253259927034 614.4416920095682 614.5553389936686 615.7070309966803 616.3957930058241 616.4119469970465 616.8708899915218 617.1260990053415 617.1724849939346 617.5506599992514 618.4718019962311 618.9797360002995 619.9976810067892 621.2779549956322 621.9193530082703 622.488484993577 622.5559900105 623.4180509895086 623.5614010095596 624.0241300016642 624.859944999218 625.8512379974127 627.1322840005159 629.3999840021133 629.6538910120726 630.0115159898996 630.2736419886351 631.5293790102005 632.5711260139942 633.3185219913721 635.6997479945421 638.5458980053663 638.8153489977121 640.8105880022049 641.577922001481 642.2628990113735 643.6813149899244 644.2736409902573 644.7430019974709 646.6303720027208 650.5861819982529 651.1535240113735 654.297729998827 655.3854569941759 657.2798670083284 659.2678219974041 659.7721770107746 661.8862310051918 661.9343670010567 663.1684159934521 663.2025559991598 664.5564379990101 665.3606770038605 666.6011960059404 671.9133709967136 680.7434089928865

Current
Mean: 628.571 ms
Stdev: 22.949 ms (3.7%)
Runs: 596.71875 602.6248780041933 602.6610109955072 604.0840249955654 604.4621990025043 604.8661299943924 605.0908199995756 606.066812992096 606.4000660032034 606.4276940077543 607.1601970046759 607.6225180029869 607.8120529949665 607.8540849983692 607.9117840081453 607.9635419994593 608.2315270006657 608.993000999093 609.0763750076294 610.3998620063066 612.3819169998169 612.494425997138 612.5768640041351 612.7296959906816 612.7738859951496 613.0629480034113 613.4005940109491 613.5948079973459 613.6666669994593 613.9071860015392 614.1148680001497 614.442586004734 614.667847007513 614.8326420038939 614.8533120006323 614.900593996048 614.951293990016 616.1804199963808 616.6816820055246 616.6858730018139 617.8706469982862 617.9315190017223 617.966065004468 619.6951899975538 619.8657640069723 619.9691160023212 620.5700690001249 621.0978600084782 621.1457929909229 621.2025960087776 621.2430429905653 621.7628580033779 623.1682540029287 625.0614420026541 625.2297360002995 626.5701909959316 627.5079759955406 628.1231279969215 628.2978930026293 633.3286950141191 633.5166840106249 633.7560629993677 635.0828450024128 635.8565270006657 636.5963129997253 637.0171310007572 640.0062669962645 641.9135740101337 642.0242110043764 642.4331459999084 644.7197670042515 644.8990480005741 645.5381269901991 646.782186999917 648.7961840033531 650.8716640025377 657.1937659978867 662.1396490037441 662.2461350113153 662.6441650092602 664.4028730094433 666.319864988327 667.6087239980698 671.3875730037689 671.5826009958982 675.4774169921875 676.2731940001249 678.8172200024128 682.8204350024462 685.4134529978037 692.9342859983444
App start nativeLaunch Baseline
Mean: 22.438 ms
Stdev: 3.264 ms (14.5%)
Runs: 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 24 24 24 24 24 24 25 25 25 25 26 26 27 27 27 28 28 29 29 30 30 30 30 31 31

Current
Mean: 22.920 ms
Stdev: 2.940 ms (12.8%)
Runs: 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 24 24 24 24 24 24 25 25 25 25 25 25 26 26 27 27 27 27 28 28 28 29 29 29 29 29 29 29 30
App start regularAppStart Baseline
Mean: 0.015 ms
Stdev: 0.001 ms (5.9%)
Runs: 0.01297999918460846 0.013143002986907959 0.013183996081352234 0.01326499879360199 0.013304993510246277 0.013346001505851746 0.01338699460029602 0.013467997312545776 0.013469010591506958 0.013509005308151245 0.01354999840259552 0.01354999840259552 0.013589993119239807 0.013631001114845276 0.01367199420928955 0.013672009110450745 0.013752996921539307 0.013793006539344788 0.013793990015983582 0.013793990015983582 0.013875007629394531 0.013916000723838806 0.013916000723838806 0.013916000723838806 0.013956993818283081 0.014037996530532837 0.014118999242782593 0.014118999242782593 0.01411999762058258 0.014120012521743774 0.014160007238388062 0.014160007238388062 0.014160007238388062 0.01416100561618805 0.014199987053871155 0.014241009950637817 0.014241009950637817 0.014362990856170654 0.014485001564025879 0.014526993036270142 0.014566987752914429 0.014607995748519897 0.014607995748519897 0.014608010649681091 0.014648005366325378 0.014690011739730835 0.01472899317741394 0.014729008078575134 0.014730006456375122 0.014730006456375122 0.01477000117301941 0.014770999550819397 0.014810994267463684 0.014810994267463684 0.014851003885269165 0.014852002263069153 0.014852002263069153 0.014852002263069153 0.014852002263069153 0.014932990074157715 0.014973998069763184 0.01501399278640747 0.01501399278640747 0.01505500078201294 0.01505500078201294 0.01505500078201294 0.015055999159812927 0.015055999159812927 0.01513698697090149 0.015258997678756714 0.015299007296562195 0.01534000039100647 0.015380993485450745 0.015380993485450745 0.015421003103256226 0.015421003103256226 0.015422001481056213 0.015625 0.015664994716644287 0.01566600799560547 0.01574799418449402 0.015991002321243286 0.0161140114068985 0.016153991222381592 0.016154006123542786 0.016194000840187073 0.016234993934631348 0.016397997736930847 0.016439005732536316 0.01668301224708557

Current
Mean: 0.016 ms
Stdev: 0.001 ms (6.8%)
Runs: 0.014118999242782593 0.014241009950637817 0.014282003045082092 0.014444991946220398 0.014445006847381592 0.014526009559631348 0.014688998460769653 0.014770999550819397 0.014810994267463684 0.014932990074157715 0.014933004975318909 0.014933004975318909 0.015136003494262695 0.015137001872062683 0.015137001872062683 0.015137001872062683 0.01517699658870697 0.015177994966506958 0.015178009867668152 0.015259012579917908 0.015299990773200989 0.015300005674362183 0.01534000039100647 0.01534000039100647 0.01534000039100647 0.015380993485450745 0.015421003103256226 0.015421003103256226 0.015422001481056213 0.0154619961977005 0.01550300419330597 0.015584006905555725 0.015585005283355713 0.015625 0.015705987811088562 0.015706002712249756 0.015707001090049744 0.01574699580669403 0.01574699580669403 0.015747010707855225 0.015786990523338318 0.015827998518943787 0.015869006514549255 0.015870004892349243 0.01590898633003235 0.01590999960899353 0.01590999960899353 0.016071990132331848 0.016071990132331848 0.016072005033493042 0.016072005033493042 0.016112998127937317 0.016112998127937317 0.016112998127937317 0.016234993934631348 0.016276001930236816 0.016276001930236816 0.016357004642486572 0.016397997736930847 0.016397997736930847 0.016397997736930847 0.016439005732536316 0.016479000449180603 0.01652100682258606 0.016560986638069153 0.016600996255874634 0.016601011157035828 0.01684500277042389 0.016846001148223877 0.016885995864868164 0.01700800657272339 0.017048999667167664 0.01708999276161194 0.017212003469467163 0.017497003078460693 0.01757800579071045 0.017659008502960205 0.017659991979599 0.01782199740409851 0.01782199740409851 0.01798500120639801 0.018107011914253235 0.018228992819786072 0.01871800422668457 0.018798992037773132 0.01932699978351593

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 9, 2023

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.80-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.80-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.81-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

2 similar comments
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants