Fix: Android-Scan camera preview in Scan becomes blank #28792

dukenv0307 · 2023-10-04T07:59:19Z

Details

Camera preview should not blank after navigating around in tab selector

Fixed Issues

$ #27879
PROPOSAL: #27879 (comment)

Tests

Go to + > Request money.
Go to Scan and enable camera access if not allowed yet.
Go to Distance, then Manual a few times.
Go back to Scan.
Verify that the Scan camera preview is not blank

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to + > Request money.
Go to Scan and enable camera access if not allowed yet.
Go to Distance, then Manual a few times.
Go back to Scan.
Verify that the Scan camera preview is not blank

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.2.mp4

Mobile Web - Chrome

Screenrecorder-2023-10-04-15-30-32-425.mp4

Mobile Web - Safari

safari.mov

Desktop

desktop.3.mp4

iOS

Screen.Recording.2023-10-04.at.15.59.34.mov

Android

Screenrecorder-2023-10-04-14-37-05-328.mp4

melvin-bot · 2023-10-04T09:03:23Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2023-10-04T20:34:06Z

@bondydaa Can we please trigger an adhoc-build for this one to test the iOS camera?

mananjadhav · 2023-10-04T20:39:15Z

src/pages/iou/ReceiptSelector/TabNavigationAwareCamera.js


 const propTypes = {
    /* The index of the tab that contains this camera */
    cameraTabIndex: PropTypes.number.isRequired,

    /* Forwarded ref */
    forwardedRef: refPropTypes.isRequired,
+
+    /* Which tab has been selected */


Suggested change

/* Which tab has been selected */

/* Name of the selected receipt tab*/

mananjadhav · 2023-10-04T20:39:33Z

src/pages/iou/ReceiptSelector/index.native.js

@@ -54,6 +54,9 @@ const propTypes = {

    /** Whether or not the receipt selector is in a tab navigator for tab animations */
    isInTabNavigator: PropTypes.bool,
+
+    /** Which tab has been selected */


Suggested change

/** Which tab has been selected */

/** Name of the selected receipt tab */

mananjadhav

@dukenv0307 Small suggestions on the prop comments.

mananjadhav · 2023-10-04T21:16:06Z

@dukenv0307 I am getting these warnings. Can you please fix this?

dukenv0307 · 2023-10-05T09:09:13Z

@mananjadhav Just resolved the warning. Please help review again.

mananjadhav · 2023-10-05T14:05:56Z

This looks better. I'll test this again in an hour or so.

mananjadhav · 2023-10-05T17:55:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-scan-blank.mov

Mobile Web - Chrome

mweb-chrome-scan-blank.mov

Mobile Web - Safari

mweb-safari-scan-blank.mov

Desktop

desktop-scan-blank.mov

iOS

Android

android-scan-blank.mov

mananjadhav · 2023-10-05T17:58:25Z

@bondydaa Can you please help us with the iOS QA here? We can't run this a external contributors and adhoc build also doesn't seem to be working (link).

bondydaa · 2023-10-09T18:49:04Z

whoops sorry, going to kick off the build now. hopefully whatever was broken is fixed 🙏

bondydaa · 2023-10-09T18:50:22Z

okay building here https://github.com/Expensify/App/actions/runs/6460584143

bondydaa · 2023-10-11T05:04:23Z

@mananjadhav did those work?

mananjadhav · 2023-10-11T05:14:22Z

@bondydaa The adhoc build doesn't work for me. That's what I mentioned here as well. Can you help us with the iOS QA?

ios-adhoc-build.mp4

bondydaa · 2023-10-12T05:20:10Z

I don't have an iOS device unfortunately.

looks like there's a conflict though as well now.

dukenv0307 · 2023-10-16T02:36:29Z

@mananjadhav @bondydaa Friendly bump. Not sure if any I can do from my side to process this faster

bondydaa · 2023-10-17T20:13:33Z

looks like theres still some conflicts here

dukenv0307 · 2023-10-18T03:43:36Z

@bondydaa There is a bug that crashes the app in the latest main right now, I think we should wait until that bug is fixed to resolve the conflict

mananjadhav · 2023-10-18T10:12:06Z

I am OOO today, but I will try to get help on this one. @bondydaa Can you help build the App again? and I can try on the iPad.

mananjadhav · 2023-10-19T16:39:16Z

Quick bump @bondydaa?

bondydaa · 2023-10-20T20:56:35Z

doh sorry, triggering the build now.

bondydaa · 2023-10-20T20:57:31Z

build running now on https://github.com/Expensify/App/actions/runs/6592626420

OSBotify · 2023-10-20T21:26:32Z

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/28792/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/28792/index.html

desktop 💻	web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/28792/NewExpensify.dmg	https://28792.pr-testing.expensify.com

mountiny · 2023-10-23T17:10:09Z

ios works well too
https://github.com/Expensify/App/assets/36083550/e00d6832-a629-4ac6-b962-443facb2b2b5

mananjadhav · 2023-10-23T17:13:27Z

Thanks @mountiny for helping us out here.

OSBotify · 2023-10-23T17:24:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-24T02:00:11Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.90-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dangrous · 2023-10-24T19:19:41Z

I'm not sure this is exactly a regression but it is definitely revealed by this PR if not caused. See #30280 - thanks!

OSBotify · 2023-10-25T16:37:05Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.90-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-25T17:01:53Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.91-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-26T22:43:54Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.91-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 marked this pull request as ready for review October 4, 2023 09:03

dukenv0307 requested a review from a team as a code owner October 4, 2023 09:03

melvin-bot bot requested review from mananjadhav and removed request for a team October 4, 2023 09:03

mananjadhav reviewed Oct 4, 2023

View reviewed changes

mananjadhav approved these changes Oct 5, 2023

View reviewed changes

melvin-bot bot requested a review from bondydaa October 5, 2023 17:52

bondydaa added the Ready To Build label Oct 9, 2023

dukenv0307 force-pushed the fix/27879 branch from 8656bed to bb60e83 Compare October 18, 2023 09:28

fix: android-scan camera preview in Scan becomes blank

18d8ccc

dukenv0307 force-pushed the fix/27879 branch from bb60e83 to 18d8ccc Compare October 18, 2023 09:46

add dependency

470ba28

mountiny approved these changes Oct 23, 2023

View reviewed changes

mountiny merged commit 22ccf4b into Expensify:main Oct 23, 2023
13 checks passed

OSBotify mentioned this pull request Oct 24, 2023

Deploy Checklist: New Expensify 2023-10-24 #30224

Closed

43 tasks

ishpaul777 mentioned this pull request Oct 24, 2023

[$500] IOS - Request - Camera blinks when switching between tabs #30280

Closed

6 tasks

melvin-bot bot mentioned this pull request Oct 25, 2023

[$500] Android - Scan - Camera preview in Scan becomes blank after returning from Distance #27879

Closed

6 tasks

OSBotify mentioned this pull request Oct 25, 2023

Deploy Checklist: New Expensify 2023-10-25 #30365

Closed

99 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Android-Scan camera preview in Scan becomes blank #28792

Fix: Android-Scan camera preview in Scan becomes blank #28792

dukenv0307 commented Oct 4, 2023 •

edited

Loading

melvin-bot bot commented Oct 4, 2023

mananjadhav commented Oct 4, 2023

mananjadhav Oct 4, 2023 •

edited

Loading

dukenv0307 Oct 5, 2023

mananjadhav Oct 4, 2023 •

edited

Loading

dukenv0307 Oct 5, 2023

mananjadhav left a comment

mananjadhav commented Oct 4, 2023

dukenv0307 commented Oct 5, 2023

mananjadhav commented Oct 5, 2023

mananjadhav commented Oct 5, 2023 •

edited

Loading

mananjadhav commented Oct 5, 2023

bondydaa commented Oct 9, 2023

bondydaa commented Oct 9, 2023

bondydaa commented Oct 11, 2023

mananjadhav commented Oct 11, 2023

bondydaa commented Oct 12, 2023

dukenv0307 commented Oct 16, 2023

bondydaa commented Oct 17, 2023

dukenv0307 commented Oct 18, 2023

mananjadhav commented Oct 18, 2023

mananjadhav commented Oct 19, 2023

bondydaa commented Oct 20, 2023

bondydaa commented Oct 20, 2023

OSBotify commented Oct 20, 2023

mountiny commented Oct 23, 2023

mananjadhav commented Oct 23, 2023

OSBotify commented Oct 23, 2023

OSBotify commented Oct 24, 2023

dangrous commented Oct 24, 2023

OSBotify commented Oct 25, 2023

OSBotify commented Oct 25, 2023

OSBotify commented Oct 26, 2023

	/* Which tab has been selected */
	/* Name of the selected receipt tab*/

	/** Which tab has been selected */
	/** Name of the selected receipt tab */

Fix: Android-Scan camera preview in Scan becomes blank #28792

Fix: Android-Scan camera preview in Scan becomes blank #28792

Conversation

dukenv0307 commented Oct 4, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 4, 2023

mananjadhav commented Oct 4, 2023

mananjadhav Oct 4, 2023 • edited Loading

Choose a reason for hiding this comment

dukenv0307 Oct 5, 2023

Choose a reason for hiding this comment

mananjadhav Oct 4, 2023 • edited Loading

Choose a reason for hiding this comment

dukenv0307 Oct 5, 2023

Choose a reason for hiding this comment

mananjadhav left a comment

Choose a reason for hiding this comment

mananjadhav commented Oct 4, 2023

dukenv0307 commented Oct 5, 2023

mananjadhav commented Oct 5, 2023

mananjadhav commented Oct 5, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mananjadhav commented Oct 5, 2023

bondydaa commented Oct 9, 2023

bondydaa commented Oct 9, 2023

bondydaa commented Oct 11, 2023

mananjadhav commented Oct 11, 2023

bondydaa commented Oct 12, 2023

dukenv0307 commented Oct 16, 2023

bondydaa commented Oct 17, 2023

dukenv0307 commented Oct 18, 2023

mananjadhav commented Oct 18, 2023

mananjadhav commented Oct 19, 2023

bondydaa commented Oct 20, 2023

bondydaa commented Oct 20, 2023

OSBotify commented Oct 20, 2023

mountiny commented Oct 23, 2023

mananjadhav commented Oct 23, 2023

OSBotify commented Oct 23, 2023

OSBotify commented Oct 24, 2023

dangrous commented Oct 24, 2023

OSBotify commented Oct 25, 2023

OSBotify commented Oct 25, 2023

OSBotify commented Oct 26, 2023

dukenv0307 commented Oct 4, 2023 •

edited

Loading

mananjadhav Oct 4, 2023 •

edited

Loading

mananjadhav Oct 4, 2023 •

edited

Loading

mananjadhav commented Oct 5, 2023 •

edited

Loading