Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "Handle suggestions only on selection change" #28794

Merged
merged 1 commit into from
Oct 4, 2023
Merged

[CP Staging] Revert "Handle suggestions only on selection change" #28794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/pages/home/report/ReportActionCompose/SuggestionMention.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,10 +234,7 @@ function SuggestionMention({

useEffect(() => {
calculateMentionSuggestion(selection.end);

// We want this hook to run only on selection change.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [selection]);
}, [selection, calculateMentionSuggestion]);

const updateShouldShowSuggestionMenuToFalse = useCallback(() => {
setSuggestionValues((prevState) => {
Expand Down
Loading