Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: RBR - Deleted error notifications reappear after reloading #28810

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Fix: RBR - Deleted error notifications reappear after reloading #28810

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e473476
fix persisted requests
shubham1206agra Oct 4, 2023
05f36bf
Merge branch 'Expensify:main' into fix-persisted-requests
shubham1206agra Oct 4, 2023
ae8cb00
Merge branch 'main' into fix-persisted-requests
shubham1206agra Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libs/actions/PersistedRequests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ function remove(requestToRemove: Request) {
* We only remove the first matching request because the order of requests matters.
* If we were to remove all matching requests, we can end up with a final state that is different than what the user intended.
*/
const index = persistedRequests.findIndex((persistedRequest) => isEqual(persistedRequest, requestToRemove));
const requests = [...persistedRequests];
const index = requests.findIndex((persistedRequest) => isEqual(persistedRequest, requestToRemove));
if (index === -1) {
return;
}
const requests = [...persistedRequests];
requests.splice(index, 1);
persistedRequests = requests;
Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, requests);
Expand Down
Loading