Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: City field is lost when login again by deeplink #28845

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

DylanDylann
Copy link
Contributor

@DylanDylann DylanDylann commented Oct 4, 2023

Details

City field should be remain when login again

Fixed Issues

$ #28007
PROPOSAL: #28007 (comment)

Tests

  1. Go to Settings -> Profile -> Personal Details -> Home address
  2. Fill all the details
  3. Log out
  4. Open https://staging.new.expensify.com/settings/profile/personal-details/address
  5. Login and verify city fields are populated
  • Verify that no errors appear in the JS console

Offline tests

  1. Go to Settings -> Profile -> Personal Details -> Home address
  2. Fill all the details
  3. Log out
  4. Open https://staging.new.expensify.com/settings/profile/personal-details/address
  5. Login and verify city fields are populated

QA Steps

  1. Go to Settings -> Profile -> Personal Details -> Home address
  2. Fill all the details
  3. Log out
  4. Open https://staging.new.expensify.com/settings/profile/personal-details/address
  5. Login and verify city fields are populated
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Screen.Recording.2023-10-05.at.00.22.15.mp4
Mobile Web - Chrome
Screen.Recording.2023-10-05.at.13.52.55.mp4
Mobile Web - Safari
Screen.Recording.2023-10-05.at.13.44.40.mp4
Desktop
Screen.Recording.2023-10-05.at.14.01.13.mp4
iOS
Android

@DylanDylann DylanDylann requested a review from a team as a code owner October 4, 2023 17:23
@melvin-bot melvin-bot bot requested review from Ollyws and removed request for a team October 4, 2023 17:23
@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@DylanDylann
Copy link
Contributor Author

@Ollyws Could you help to review it? Small change

@Ollyws
Copy link
Contributor

Ollyws commented Oct 5, 2023

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
MacOS_Web.mp4
Mobile Web - Chrome
Android_Chrome.mp4
Mobile Web - Safari
iOS_Safari.mp4
Desktop
MacOS_Desktop.mp4
iOS
iOS_Native.mp4
Android
Android_Native.mp4

Copy link
Contributor

@Ollyws Ollyws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@melvin-bot melvin-bot bot requested a review from AndrewGable October 5, 2023 11:48
@AndrewGable AndrewGable merged commit 56ced22 into Expensify:main Oct 5, 2023
15 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented Oct 5, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1250.048 ms → 1352.332 ms (+102.283 ms, +8.2%) 🔴
App start runJsBundle 862.843 ms → 921.478 ms (+58.635 ms, +6.8%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1250.048 ms
Stdev: 43.781 ms (3.5%)
Runs: 1150.546930000186 1166.4270799998194 1166.7412849999964 1167.8800060003996 1171.32745099999 1178.1170809995383 1179.6278080008924 1183.7746479995549 1186.788164999336 1188.7351029999554 1190.211459999904 1193.4864360000938 1198.6211210004985 1201.2171659991145 1202.1084330007434 1208.2309489995241 1208.2877670004964 1208.3407790008932 1209.9922710005194 1212.3395649995655 1215.8142269998789 1222.4988519996405 1224.1748249996454 1225.23012400046 1226.672488000244 1227.5960029996932 1228.8140730001032 1230.0030610002577 1231.160660000518 1231.875605000183 1232.624665999785 1233.8127030003816 1234.411603000015 1234.4481150005013 1235.7982640005648 1237.5745269991457 1240.2581290006638 1241.3189739994705 1244.002056999132 1245.1031700000167 1245.1839409992099 1245.9726410005242 1246.576359000057 1247.2710040006787 1247.369263999164 1248.9334410000592 1249.1802290007472 1249.890572000295 1253.0320149995387 1253.4238930009305 1254.2377419993281 1256.0939429998398 1256.8332770001143 1260.0278190001845 1264.5390280000865 1264.853585999459 1265.4284400008619 1269.3102669995278 1269.888919999823 1275.0729980003089 1276.3229370005429 1276.712739000097 1277.216970000416 1278.6057649999857 1278.733813000843 1278.9777210000902 1280.1397140007466 1280.2014300003648 1281.6142260003835 1282.1032909993082 1288.442466000095 1291.2282469999045 1292.5445939991623 1294.3089729994535 1294.8241360001266 1296.662050999701 1302.3420219998807 1303.7888350002468 1305.1931110005826 1306.4536920003593 1307.5931790005416 1309.2635549996048 1312.8657159991562 1313.4632089994848 1314.4222180005163 1318.7148470003158 1320.0195269994438 1327.8133829999715 1333.0076759997755 1341.6578260008246

Current
Mean: 1352.332 ms
Stdev: 55.123 ms (4.1%)
Runs: 1230.861367000267 1250.942181000486 1255.602949000895 1269.1303380001336 1269.5406059995294 1272.0727399997413 1282.4472150001675 1283.7407990004867 1285.130665000528 1286.248079000041 1288.3323599994183 1291.3149289991707 1293.6832480002195 1295.2928020004183 1295.7833379991353 1296.577588999644 1297.841365000233 1298.5179229993373 1305.9157960005105 1310.1157079990953 1310.543008999899 1312.3318980000913 1312.6542499996722 1315.069666000083 1315.1789120007306 1319.0998069997877 1319.3817570004612 1319.8268240001053 1320.354306999594 1322.0976899992675 1322.8463029991835 1325.4309149999171 1325.5444300007075 1327.6861160006374 1328.8473589997739 1331.600672999397 1333.3818169999868 1336.1337150000036 1336.216616999358 1337.0972530003637 1338.1030369997025 1338.6350829992443 1341.7257630005479 1341.83342500031 1342.5558419991285 1342.901543000713 1349.5978170000017 1351.1923190001398 1353.9703069999814 1355.7472239993513 1358.4180430006236 1358.6488690003753 1361.4392549991608 1364.1527730003 1365.4116610009223 1367.3585369996727 1370.392885999754 1371.2125930003822 1371.4924630001187 1372.4428959991783 1374.5484810005873 1376.2282449994236 1376.6686909999698 1381.0602419991046 1381.1894140001386 1382.737655999139 1383.795437000692 1389.3618810009211 1390.4798639994115 1391.6475590001792 1395.1810929998755 1397.5864669997245 1403.7313640005887 1407.9564559999853 1408.1245239991695 1410.2160829994828 1410.237323999405 1411.0081140007824 1414.231332000345 1428.3689229991287 1440.3131670001894 1443.9485560003668 1445.670216999948 1448.042240999639 1449.051766000688 1452.0190639998764 1452.2744910009205 1454.861569000408 1480.808526000008 1480.8416859991848
App start runJsBundle Baseline
Mean: 862.843 ms
Stdev: 32.873 ms (3.8%)
Runs: 769 806 809 810 815 817 820 824 825 825 826 826 827 828 828 833 833 834 834 835 837 838 840 840 840 842 842 843 843 845 846 848 849 849 851 851 853 853 854 854 854 855 856 857 859 860 861 863 868 870 871 872 872 873 875 875 877 877 878 880 880 880 880 880 881 882 884 885 885 886 887 888 892 892 893 894 899 903 908 914 914 915 917 920 922 925 927 928 937

Current
Mean: 921.478 ms
Stdev: 44.456 ms (4.8%)
Runs: 805 819 846 849 850 860 860 864 865 868 871 874 875 877 877 881 882 889 889 890 891 891 891 892 892 894 895 897 898 900 902 903 903 904 906 909 910 912 912 912 915 915 915 916 916 918 923 924 925 926 927 928 928 931 932 933 933 934 935 937 938 938 940 941 942 945 946 950 951 951 953 956 958 963 964 965 969 972 972 977 980 993 994 996 999 1001 1004 1011 1016 1032

Meaningless Changes To Duration

Show entries
Name Duration
Open Search Page TTI 628.480 ms → 634.426 ms (+5.946 ms, +0.9%)
App start nativeLaunch 21.448 ms → 23.989 ms (+2.541 ms, +11.8%)
App start regularAppStart 0.015 ms → 0.017 ms (+0.002 ms, +13.1%)
Show details
Name Duration
Open Search Page TTI Baseline
Mean: 628.480 ms
Stdev: 23.615 ms (3.8%)
Runs: 582.249471001327 594.2026780005544 595.0868330001831 595.4445390012115 596.3210859987885 596.7009689994156 597.0368250012398 597.4713550005108 599.0372720006853 599.0809329990298 600.027710000053 602.6498619988561 603.075317999348 604.7895100004971 605.3795580007136 605.4785160012543 606.0060219988227 606.132162000984 607.2571210004389 608.050862999633 608.9219569992274 609.8824460003525 610.015666000545 610.4508059993386 611.3686929997057 612.0666099991649 612.2842210009694 612.3612879998982 613.5235600005835 613.5353600010276 614.2547199986875 618.7068290002644 619.9117029998451 619.9508870001882 620.2925220001489 620.5045170001686 621.0237230006605 621.3426520004869 621.7423100005835 622.047444999218 622.0739750005305 622.6604830008 623.5555419996381 623.7427159994841 627.48506699875 627.9333910010755 628.4734299983829 628.563476998359 629.1990160010755 629.3191330004483 629.6494550015777 629.8769129998982 629.9592279996723 630.2674150001258 630.9362789988518 631.0509440004826 631.0752360001206 631.7251389995217 632.0081379991025 632.9232589993626 634.4786779992282 636.515381000936 636.8650310002267 637.4917399995029 637.7756750006229 638.7504079993814 638.8695480003953 639.0743409991264 639.3670259993523 645.8833419997245 646.1678880006075 646.4609380010515 646.5826419983059 647.2873129993677 647.8658450003713 648.0340170003474 652.1339519992471 654.1544599998742 654.290445998311 657.8553059995174 663.2961829993874 664.3511560000479 665.2495120000094 668.8834229987115 670.3106690011919 672.7522379998118 673.2309170011431 677.4044599998742 681.7395019996911 685.4961350001395 694.9042980000377

Current
Mean: 634.426 ms
Stdev: 16.172 ms (2.5%)
Runs: 610.746744999662 612.0886229984462 612.1733400002122 613.7248950004578 614.3910329993814 614.7871909998357 614.8449300006032 614.9117439985275 615.1745610013604 615.1850589998066 616.2982180006802 616.9722499996424 618.1790779996663 618.5201420001686 619.5211999993771 619.6470129992813 619.7559409998357 620.609701000154 620.6438400000334 621.0053709987551 621.2636719997972 621.297405000776 621.5606690011919 622.7338870000094 623.0183509998024 623.0872399993241 623.3047279994935 623.7262779995799 623.7329510003328 626.4109710007906 626.77779099904 627.4525969997048 628.3038340006024 628.5389820002019 628.5446780007333 628.969117000699 628.9817299991846 629.3315439987928 629.3568530008197 629.8302410002798 630.2559820003808 630.8919680006802 631.0721440017223 631.2087409999222 631.5911459997296 632.3175050001591 632.4346120003611 632.4567459989339 632.7681070007384 633.0124110002071 634.5462249983102 634.5914719998837 635.20243300125 635.734496999532 635.7873130012304 636.4040120001882 636.457073001191 637.2441000007093 637.4840909987688 637.6131599992514 638.0485839992762 638.5265709999949 639.2517099995166 639.3382569998503 639.7124439999461 641.2589919995517 642.0284839998931 643.5516769997776 643.8503430001438 644.566081000492 646.4165039993823 647.5605480000377 647.9306640010327 648.5045170001686 649.1738690007478 652.0082189999521 652.2881269995123 653.2182620000094 653.3993330001831 653.8894859999418 657.0367840006948 657.8452969994396 662.1004240009934 669.4901940003037 669.8826099988073 670.7489829994738 672.7578530013561 681.6982829999179 683.3428959995508
App start nativeLaunch Baseline
Mean: 21.448 ms
Stdev: 2.876 ms (13.4%)
Runs: 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 22 22 22 22 22 22 22 22 23 23 23 23 23 23 24 24 24 24 24 24 25 25 25 26 26 27 27 29 29 29 30 30

Current
Mean: 23.989 ms
Stdev: 3.100 ms (12.9%)
Runs: 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 23 23 23 23 23 23 24 24 24 24 24 24 24 24 24 24 24 24 25 25 25 25 25 26 26 26 26 27 28 28 28 29 29 29 30 30 30 30 30 31 31 31 31 32
App start regularAppStart Baseline
Mean: 0.015 ms
Stdev: 0.001 ms (7.3%)
Runs: 0.012736000120639801 0.012776998803019524 0.013020999729633331 0.01314299926161766 0.013265000656247139 0.013305000960826874 0.013508999720215797 0.013549000024795532 0.01355000026524067 0.013590000569820404 0.013630999252200127 0.013712000101804733 0.01371300034224987 0.013753999024629593 0.013793999329209328 0.013793999329209328 0.013794001191854477 0.013833999633789062 0.0138349998742342 0.013875000178813934 0.013915998861193657 0.013916000723838806 0.013916000723838806 0.013956001028418541 0.014038000255823135 0.014038000255823135 0.014078998938202858 0.014118999242782593 0.014242000877857208 0.014281999319791794 0.014281999319791794 0.014282001182436943 0.014322999864816666 0.014322999864816666 0.014322999864816666 0.014364000409841537 0.014444999396800995 0.014444999396800995 0.014525998383760452 0.014566998928785324 0.014566998928785324 0.014566998928785324 0.01464799977838993 0.01464799977838993 0.014649000018835068 0.014689000323414803 0.014689000323414803 0.014689000323414803 0.014729999005794525 0.014730000868439674 0.014810999855399132 0.014810999855399132 0.014810999855399132 0.014852000400424004 0.014932999387383461 0.014932999387383461 0.014973999932408333 0.014973999932408333 0.015014000236988068 0.01521800085902214 0.015258999541401863 0.015259001404047012 0.015298999845981598 0.01533999852836132 0.01534000039100647 0.01534000039100647 0.015380999073386192 0.015381000936031342 0.01550300046801567 0.015543999150395393 0.015584999695420265 0.015665000304579735 0.015665998682379723 0.015869000926613808 0.01590999960899353 0.016030998900532722 0.01603200100362301 0.01607299968600273 0.016154000535607338 0.016193998977541924 0.01619499921798706 0.016439000144600868 0.016439000144600868 0.016600999981164932 0.016764000058174133 0.01700800098478794 0.017049001529812813 0.017049001529812813 0.017455998808145523 0.017780998721718788

Current
Mean: 0.017 ms
Stdev: 0.001 ms (7.1%)
Runs: 0.013916000723838806 0.014241999015212059 0.014322999864816666 0.01476999931037426 0.01476999931037426 0.014892999082803726 0.015177000313997269 0.015217998996376991 0.015259001404047012 0.015379998832941055 0.015380000695586205 0.015543999150395393 0.015585001558065414 0.015706000849604607 0.01574699953198433 0.0157880000770092 0.015828998759388924 0.015908999368548393 0.015991000458598137 0.015991000458598137 0.016071999445557594 0.01607299968600273 0.016112999990582466 0.016112999990582466 0.016114000231027603 0.01615399867296219 0.01615399867296219 0.016154000535607338 0.016194000840187073 0.016234999522566795 0.016234999522566795 0.016316000372171402 0.01631700061261654 0.016356999054551125 0.016356999054551125 0.016357000917196274 0.016397999599575996 0.016397999599575996 0.016398001462221146 0.016398001462221146 0.016479000449180603 0.016519999131560326 0.016561001539230347 0.016600999981164932 0.016682999208569527 0.016683001071214676 0.01672299951314926 0.01672299951314926 0.016764000058174133 0.016885999590158463 0.016885999590158463 0.0168869998306036 0.01700899936258793 0.017048999667167664 0.017131000757217407 0.017170999199151993 0.017170999199151993 0.017211999744176865 0.017333999276161194 0.017333999276161194 0.017374999821186066 0.0174150001257658 0.017456000670790672 0.017456000670790672 0.017496999353170395 0.01753700152039528 0.017537999898195267 0.017578000202775 0.017619000747799873 0.017659001052379608 0.01769999973475933 0.01769999973475933 0.017741000279784203 0.017741000279784203 0.017741000279784203 0.017781998962163925 0.017862999811768532 0.018147999420762062 0.018268998712301254 0.018310999497771263 0.018596000969409943 0.018635999411344528 0.018797999247908592 0.019166000187397003 0.019531000405550003 0.019652999937534332 0.019977999851107597

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2023

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.79-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 9, 2023

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 9, 2023

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 9, 2023

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants