Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sort header display names and avatars in a group chat view #28991

Merged
merged 16 commits into from
Oct 23, 2023
Merged

fix: sort header display names and avatars in a group chat view #28991

merged 16 commits into from
Oct 23, 2023

Commits on Oct 6, 2023

  1. display sorted names for group chats in the header view and LHN

    @akinwale
    akinwale committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    7306d5b View commit details
    Browse the repository at this point in the history

  2. modify tests to handle display name sorting logic

    @akinwale
    akinwale committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    9443ddc View commit details
    Browse the repository at this point in the history

  3. use displayNamesWithTooltips list to set the sortedDisplayNames value

    @akinwale
    akinwale committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    79a227e View commit details
    Browse the repository at this point in the history

  4. use sorted display names as title in LHN only when the type is chat

    @akinwale
    akinwale committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    9c52be7 View commit details
    Browse the repository at this point in the history

  5. use chain on personalDetailsList

    @akinwale
    akinwale committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    74c0acc View commit details
    Browse the repository at this point in the history

  6. assign full title value based on certain conditions

    @akinwale
    akinwale committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    ab1ccb0 View commit details
    Browse the repository at this point in the history

  7. refactor shared code

    @akinwale
    akinwale committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    c8165ff View commit details
    Browse the repository at this point in the history

  8. cleanup fullTitle condition check

    @akinwale
    akinwale committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    d749a37 View commit details
    Browse the repository at this point in the history

  9. add helper methods to determine if a report is a group chat

    @akinwale
    akinwale committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    2b0f405 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. fix merge conflicts

    @akinwale
    akinwale committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e9c4512 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. tweak conditions for checking for a group chat

    @akinwale
    akinwale committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    5da2d3a View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. fix merge conflicts

    @akinwale
    akinwale committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    21c9aee View commit details
    Browse the repository at this point in the history

  2. fix lint

    @akinwale
    akinwale committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    eadae89 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. make isGroupChat a variable instead of a function

    @akinwale
    akinwale committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    f46e365 View commit details
    Browse the repository at this point in the history

  2. fix merge conflicts

    @akinwale
    akinwale committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    b361613 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. fix another merge conflict

    @akinwale
    akinwale committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    e5662c3 View commit details
    Browse the repository at this point in the history