-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
22875 Add API Calls when clicking “Reveal details” buttons #29017
Merged
marcaaron
merged 24 commits into
Expensify:main
from
lukemorawski:22875-api_call_on_reveal_card_details
Oct 25, 2023
Merged
Changes from 11 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
f73d601
first commit
lukemorawski 5985ec1
move to reducer and error handling
lukemorawski df10ff7
removed unnecessary helper function
lukemorawski 36fb11a
formatting
lukemorawski bfdb546
var name change to isLoading
lukemorawski 9a8962c
better linting
lukemorawski c7dd8fa
moved action types to const
lukemorawski ccf8f4e
action types fix and cardID added to api call
lukemorawski ef623a4
address refactoring
lukemorawski f7ba68a
refactoring
lukemorawski 9f173af
Merge branch 'main' into 22875-api_call_on_reveal_card_details
lukemorawski 8361350
removed comment
lukemorawski 36a6d4e
revealCardDetails move
lukemorawski 28ca868
Merge branch 'main' into 22875-api_call_on_reveal_card_details
lukemorawski a7bcbb6
added offline disabling
lukemorawski f1aad79
Merge branch 'main' into 22875-api_call_on_reveal_card_details
lukemorawski 42cb473
reject with generic error message
lukemorawski 6dac4ca
Merge branch 'main' into 22875-api_call_on_reveal_card_details
lukemorawski dcb188b
Update src/libs/actions/Card.js
lukemorawski 8254860
linting
lukemorawski 586f20e
Merge branch 'main' into 22875-api_call_on_reveal_card_details
lukemorawski aaa7042
merging with latest changes
lukemorawski 95d4a43
Update src/languages/en.ts
lukemorawski 934344a
removed error handling
lukemorawski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import * as API from '../API'; | ||
import CONST from '../../CONST'; | ||
import {TCardDetails} from '../../types/onyx/Card'; | ||
import * as Localize from '../Localize'; | ||
|
||
function revealVirtualCardDetails(cardID: string): Promise<TCardDetails> { | ||
return new Promise((resolve, reject) => { | ||
// eslint-disable-next-line rulesdir/no-api-side-effects-method | ||
API.makeRequestWithSideEffects('RevealVirtualCardDetails', {cardID}) | ||
.then((response) => { | ||
if (response.jsonCode !== CONST.JSON_CODE.SUCCESS) { | ||
reject(response.message || Localize.translateLocal('cardPage.cardDetailsLoadingFailure')); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should not return the |
||
return; | ||
} | ||
resolve(response); | ||
}) | ||
.catch((err) => { | ||
reject(err.message); | ||
}); | ||
}); | ||
} | ||
|
||
export default {revealVirtualCardDetails}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this reads better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed this copy was already approved by marketing.
@lukemorawski @MrMuzyk @grgia is this wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no error message copy for this in the Design Doc @marcaaron
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I think we need to get the copy looked at. All copy needs to be approved. 🙃
Where did this error message come from?