Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow split actions to be edited and implement IOU action completeSplitBill #29064

Merged
merged 68 commits into from
Oct 12, 2023
Merged

Allow split actions to be edited and implement IOU action completeSplitBill #29064

merged 68 commits into from
Oct 12, 2023

Commits on Oct 8, 2023

  1. Make SplitBillDetailsPage editable when receipt is scanning or SS failed

    @youssef-lr
    youssef-lr committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    8c8d3ff View commit details
    Browse the repository at this point in the history

  2. Only show SmartScan fields splitting manually or editting a split

    @youssef-lr
    youssef-lr committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    12b9043 View commit details
    Browse the repository at this point in the history

  3. Create EditSplitBillPage

    @youssef-lr
    youssef-lr committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    7fba50a View commit details
    Browse the repository at this point in the history

  4. Create routes for EditSplitBillPage

    @youssef-lr
    youssef-lr committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    bd7c4b2 View commit details
    Browse the repository at this point in the history

  5. Configure inputs on split details page and link them with routes

    @youssef-lr
    youssef-lr committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    4b95154 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Save split transaction edits to a draft transaction

    @youssef-lr
    youssef-lr committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8f3f426 View commit details
    Browse the repository at this point in the history

  2. Cleanup

    @youssef-lr
    youssef-lr committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    60bca0e View commit details
    Browse the repository at this point in the history

  3. Add useCallback dep

    @youssef-lr
    youssef-lr committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    914985f View commit details
    Browse the repository at this point in the history

  4. Add proptype

    @youssef-lr
    youssef-lr committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    b3c4a3e View commit details
    Browse the repository at this point in the history

  5. Fix code removed by mistake

    @youssef-lr
    youssef-lr committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    d62883c View commit details
    Browse the repository at this point in the history

  6. Bug fix and lint

    @youssef-lr
    youssef-lr committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    08d7577 View commit details
    Browse the repository at this point in the history

  7. wip

    @youssef-lr
    youssef-lr committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    f516e3b View commit details
    Browse the repository at this point in the history

  8. Merge branch 'youssef_startSplitBill' into youssef_completeSplitBill

    @youssef-lr
    youssef-lr committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5812464 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Merge branch 'youssef_startSplitBill' into youssef_completeSplitBill

    @youssef-lr
    youssef-lr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    7950ce7 View commit details
    Browse the repository at this point in the history

  2. Remove deprecated method and use withOnyx

    @youssef-lr
    youssef-lr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    4096fe2 View commit details
    Browse the repository at this point in the history

  3. Add completeSplitBill action

    @youssef-lr
    youssef-lr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    dd69105 View commit details
    Browse the repository at this point in the history

  4. Send necessary params to completeSplitBill

    @youssef-lr
    youssef-lr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    46b6398 View commit details
    Browse the repository at this point in the history

  5. Show right icon next to all fields in split details

    @youssef-lr
    youssef-lr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    f134e3f View commit details
    Browse the repository at this point in the history

  6. Fix a few bugs

    @youssef-lr
    youssef-lr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    01d37b7 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into youssef_completeSplitBill

    @youssef-lr
    youssef-lr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    f495a29 View commit details
    Browse the repository at this point in the history

  8. Cleanup

    @youssef-lr
    youssef-lr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    5ad7a0a View commit details
    Browse the repository at this point in the history

  9. Update src/libs/TransactionUtils.ts 

    Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    @youssef-lr @mountiny
    youssef-lr and mountiny authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    322e20f View commit details
    Browse the repository at this point in the history

  10. Add nagivation to editting currency route

    @youssef-lr
    youssef-lr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    11883ed View commit details
    Browse the repository at this point in the history

  11. Add success & failure data to original transaction

    @youssef-lr
    youssef-lr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    20be465 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'youssef_completeSplitBill' of github.com:Expensify/App … 

    …into youssef_completeSplitBill
    @youssef-lr
    youssef-lr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    9311976 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Cleanup splitOrRequestOptions

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    1e71502 View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e3dc941 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>
    @youssef-lr @s77rt
    youssef-lr and s77rt authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    45d90fb View commit details
    Browse the repository at this point in the history

  4. Add failure data reverting changes made in optimistic data

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    3231d67 View commit details
    Browse the repository at this point in the history

  5. Fix typo

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    cc9a41c View commit details
    Browse the repository at this point in the history

  6. Optimize retrieval of Onyx data

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    b87312d View commit details
    Browse the repository at this point in the history

  7. Optimize Onyx data more

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    6a8de3f View commit details
    Browse the repository at this point in the history

  8. Address comments

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    c25228c View commit details
    Browse the repository at this point in the history

  9. Trim merchant

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    ba0174c View commit details
    Browse the repository at this point in the history

  10. Always navigate back to split details

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    4e54b1b View commit details
    Browse the repository at this point in the history

  11. Fix jerky animation (might be reverted not sure if this is okay)

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    63733b2 View commit details
    Browse the repository at this point in the history

  12. Show error fields next to missing fields

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    a518d61 View commit details
    Browse the repository at this point in the history

  13. Linting

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    cdf376b View commit details
    Browse the repository at this point in the history

  14. Remove testing code

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    95dc96f View commit details
    Browse the repository at this point in the history

  15. Lint

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    cc00910 View commit details
    Browse the repository at this point in the history

  16. Delete draft split transaction in success data

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    5aad7a8 View commit details
    Browse the repository at this point in the history

  17. Display form error when SmartScan fails

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    be6be0f View commit details
    Browse the repository at this point in the history

  18. Merge branch 'main' into youssef_completeSplitBill

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    b274a70 View commit details
    Browse the repository at this point in the history

  19. Rename param

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    56dc410 View commit details
    Browse the repository at this point in the history

  20. Include current user in splits

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    2f976ef View commit details
    Browse the repository at this point in the history

  21. Lint

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    f80a658 View commit details
    Browse the repository at this point in the history

  22. Dismiss modal and notify users after completing split bill

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    6a28df3 View commit details
    Browse the repository at this point in the history

  23. Update translations

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    1e21419 View commit details
    Browse the repository at this point in the history

  24. Use existing timeout logic for focusing text input

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    c7b5482 View commit details
    Browse the repository at this point in the history

  25. Display form error when completing split bill with missing fields

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    26a7311 View commit details
    Browse the repository at this point in the history

  26. Bug fix

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    48d684b View commit details
    Browse the repository at this point in the history

  27. Use areRequiredFieldsEmpty

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    362a1ae View commit details
    Browse the repository at this point in the history

  28. Fix lint and change form error when user completes split bill

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    f8484ae View commit details
    Browse the repository at this point in the history

  29. Display field errors next to missing smartscan fields when use confirms

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    583a607 View commit details
    Browse the repository at this point in the history

  30. Cleanup

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    bf021a5 View commit details
    Browse the repository at this point in the history

  31. Apply suggestions from code review 

    Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
    @youssef-lr @mountiny
    youssef-lr and mountiny authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    5867982 View commit details
    Browse the repository at this point in the history

  32. Revert change, should be handled in follow up clean up

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    7a6f4b2 View commit details
    Browse the repository at this point in the history

  33. Fix isScanning state to also check for required fields being empty

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    a740150 View commit details
    Browse the repository at this point in the history

  34. Fix areRequiredFieldsEmpty to check for non existent modified fields

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    f73674d View commit details
    Browse the repository at this point in the history

  35. Use non-interactive style instead of disabled style

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    0126d5f View commit details
    Browse the repository at this point in the history

  36. Merge branch 'main' into youssef_completeSplitBill

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    9107a5a View commit details
    Browse the repository at this point in the history

  37. Merge branch 'main' into youssef_completeSplitBill

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    272fb9b View commit details
    Browse the repository at this point in the history

  38. Fix MenuItem console warning and checking for modified amount

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    5cd7d9b View commit details
    Browse the repository at this point in the history

  39. Fix checking for modifiedAmount

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    95b3b9f View commit details
    Browse the repository at this point in the history

  40. Keep merchant error if it equal partial marchant (none)

    @youssef-lr
    youssef-lr committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    7945675 View commit details
    Browse the repository at this point in the history

  41. Merge branch 'main' into youssef_completeSplitBill

    @mountiny
    mountiny committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    ddc2214 View commit details
    Browse the repository at this point in the history

  42. Fix console warning

    @mountiny
    mountiny committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    1a51105 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. resolve conflicts

    @luacmartins
    luacmartins committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    69c0df9 View commit details
    Browse the repository at this point in the history