Android chrome crashes on opening password protected PDF #29103

ZhenjaHorbach · 2023-10-09T16:35:57Z

Details

Android chrome crashes on opening password protected PDF page

Fixed Issues

$ #28179
PROPOSAL: #28179 (comment)

Tests

Open the app
Open any report with password protected PDF sent to it
Open the password protected PDF
Verify that the app does not crash

Verify that no errors appear in the JS console

Offline tests

Open the app
Open any report with password protected PDF sent to it
Open the password protected PDF
Verify that the app does not crash

QA Steps

Open the app
Open any report with password protected PDF sent to it
Open the password protected PDF
Verify that the app does not crash

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-09.at.17.56.46.mov

Android: mWeb Chrome

Screen.Recording.2023-10-09.at.17.51.06.mov

iOS: Native

Screen.Recording.2023-10-09.at.17.52.36.mov

iOS: mWeb Safari

Screen.Recording.2023-10-09.at.17.49.25.mov

MacOS: Chrome / Safari

Screen.Recording.2023-10-09.at.17.27.27.mov

MacOS: Desktop

Screen.Recording.2023-10-09.at.18.12.18.mov

melvin-bot · 2023-10-09T16:36:03Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2023-10-09T16:40:25Z

@Ollyws

PR is ready)

Ollyws · 2023-10-10T10:33:25Z

src/libs/actions/CanvasSize.js

-        },
-    });
+    canvasSize
+        .maxArea({


Could we get a comment here explaining why we're doing this? Thanks!

ZhenjaHorbach · 2023-10-10T10:40:14Z

A bit explanation that I took from the issue from canvas-size library which calls a crash

Given these inconsistent results, my assumption would have been that the Browserstack VM is not as reliable as testing on real hardware. Since your users are experiencing issue on real hardware I can only assume that platform itself is unstable when rendering large canvas elements. This isn't totally unexpected given the hardware limitations on mobile devices and the RAM requirements of rendering large in-memory canvas elements.

Fortunately, there is an easy fix: limit the maximum canvas size used for testing. Since this issue is only affecting mobile devices, use the mobile test results available in the README.md to find a suitable max value.

jhildenbiddle/canvas-size#13

Ollyws · 2023-10-10T10:47:00Z

Thanks for the explanation but I meant a //comment in the code

Ollyws · 2023-10-10T11:30:02Z

Also could we update testing step 4 to read 4. Verify that the app does not crash, thanks!

Ollyws · 2023-10-10T14:18:42Z

src/libs/actions/CanvasSize.js

-            Onyx.merge(ONYXKEYS.MAX_CANVAS_AREA, width * height);
-        },
-    });
+    canvasSize


Suggested change

canvasSize

// We're limiting the maximum value on mobile web to prevent a crash related to rendering large canvas elements.

// More information at: https://github.com/jhildenbiddle/canvas-size/issues/13

canvasSize

Ollyws · 2023-10-10T14:19:03Z

src/libs/actions/CanvasSize.js


 /**
- * Calculate the max area of canvas on this specific platform and save it in onyx
+ * Calculate the max area of canvas on this specific platform and save it in onyx. The maximum value was limited because on mobile devices there is a crash related to the size of the area


Suggested change

* Calculate the max area of canvas on this specific platform and save it in onyx. The maximum value was limited because on mobile devices there is a crash related to the size of the area

* Calculate the max area of canvas on this specific platform and save it in onyx.

Ollyws · 2023-10-10T14:25:28Z

@ZhenjaHorbach Apologies for messing around but I made a second revision to that suggestion.

ZhenjaHorbach · 2023-10-10T14:27:26Z

@ZhenjaHorbach Apologies for messing around but I made a second revision to that suggestion.

I have fixed )

Ollyws · 2023-10-10T16:15:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

01_MacOS_Chrome.mp4

Mobile Web - Chrome

02_Android_Chrome.mp4

Mobile Web - Safari

03_iOS_Safari.mp4

Desktop

04_MacOS_Desktop.mp4

iOS

05_iOS_Native.mp4

Android

06_Android_Native.mp4

Ollyws

Tested on a variety of PDFs of varying sizes, works well.

youssef-lr

LGTM

OSBotify · 2023-10-11T10:41:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-13T21:58:08Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:10:11Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:26:24Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T23:01:49Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Fix app crash on opening password protected PDF

3aafc7c

ZhenjaHorbach requested a review from a team as a code owner October 9, 2023 16:35

melvin-bot bot requested review from Ollyws and removed request for a team October 9, 2023 16:36

Ollyws reviewed Oct 10, 2023

View reviewed changes

Update comment for retrieveMaxCanvasArea

ba6bb2c

Ollyws reviewed Oct 10, 2023

View reviewed changes

Update comment for retrieveMaxCanvasArea x2

83c0093

Update comment for retrieveMaxCanvasArea x3

1e2b7f4

Update comment for retrieveMaxCanvasArea x4

1793df2

Ollyws approved these changes Oct 10, 2023

View reviewed changes

melvin-bot bot requested a review from youssef-lr October 10, 2023 16:20

youssef-lr approved these changes Oct 11, 2023

View reviewed changes

youssef-lr merged commit 0bc4876 into Expensify:main Oct 11, 2023
15 checks passed

mountiny mentioned this pull request Oct 12, 2023

Deploy Checklist: New Expensify 2023-10-12 #29417

Closed

97 tasks

melvin-bot bot mentioned this pull request Oct 13, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] mWeb- Chat - Android chrome crashes on opening password protected PDF #28179

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android chrome crashes on opening password protected PDF #29103

Android chrome crashes on opening password protected PDF #29103

ZhenjaHorbach commented Oct 9, 2023 •

edited

Loading

melvin-bot bot commented Oct 9, 2023

ZhenjaHorbach commented Oct 9, 2023 •

edited

Loading

Ollyws Oct 10, 2023

ZhenjaHorbach commented Oct 10, 2023 •

edited

Loading

Ollyws commented Oct 10, 2023

Ollyws commented Oct 10, 2023 •

edited

Loading

Ollyws Oct 10, 2023

Ollyws Oct 10, 2023

Ollyws commented Oct 10, 2023

ZhenjaHorbach commented Oct 10, 2023

Ollyws commented Oct 10, 2023

Ollyws left a comment •

edited

Loading

youssef-lr left a comment

OSBotify commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

	* Calculate the max area of canvas on this specific platform and save it in onyx. The maximum value was limited because on mobile devices there is a crash related to the size of the area
	* Calculate the max area of canvas on this specific platform and save it in onyx.

Android chrome crashes on opening password protected PDF #29103

Android chrome crashes on opening password protected PDF #29103

Conversation

ZhenjaHorbach commented Oct 9, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 9, 2023

ZhenjaHorbach commented Oct 9, 2023 • edited Loading

Ollyws Oct 10, 2023

Choose a reason for hiding this comment

ZhenjaHorbach commented Oct 10, 2023 • edited Loading

Ollyws commented Oct 10, 2023

Ollyws commented Oct 10, 2023 • edited Loading

Ollyws Oct 10, 2023

Choose a reason for hiding this comment

Ollyws Oct 10, 2023

Choose a reason for hiding this comment

Ollyws commented Oct 10, 2023

ZhenjaHorbach commented Oct 10, 2023

Ollyws commented Oct 10, 2023

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment • edited Loading

Choose a reason for hiding this comment

youssef-lr left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

ZhenjaHorbach commented Oct 9, 2023 •

edited

Loading

ZhenjaHorbach commented Oct 9, 2023 •

edited

Loading

ZhenjaHorbach commented Oct 10, 2023 •

edited

Loading

Ollyws commented Oct 10, 2023 •

edited

Loading

Ollyws left a comment •

edited

Loading