Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS migration] Migrate 'AppNavigator' lib to TypeScript #29157

Merged
merged 33 commits into from
Dec 6, 2023
Merged

[TS migration] Migrate 'AppNavigator' lib to TypeScript #29157

merged 33 commits into from
Dec 6, 2023

Commits on Oct 10, 2023

  1. [TS migration] Migrate 'AppNavigator' lib

    @VickyStash
    VickyStash committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    9117c61 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ts-migration/appNavigator-lib 

    # Conflicts:
#	src/SCREENS.ts
    @VickyStash
    VickyStash committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    dbe6294 View commit details
    Browse the repository at this point in the history

  3. Fix ts error

    @VickyStash
    VickyStash committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    fa52838 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Minor code improvements

    @VickyStash
    VickyStash committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    0a8b4ad View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Merge branch 'main' into ts-migration/appNavigator-lib 

    # Conflicts:
#	src/SCREENS.ts
#	src/libs/Navigation/AppNavigator/AuthScreens.tsx
#	src/libs/Navigation/AppNavigator/ModalStackNavigators.js
#	src/libs/Navigation/AppNavigator/Navigators/CentralPaneNavigator.tsx
#	src/libs/Navigation/AppNavigator/Navigators/Overlay.tsx
#	src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx
#	src/libs/Navigation/AppNavigator/PublicScreens.tsx
#	src/libs/Navigation/AppNavigator/RHPScreenOptions.ts
#	src/libs/Navigation/AppNavigator/ReportScreenIDSetter.ts
#	src/libs/Navigation/AppNavigator/ReportScreenWrapper.js
#	src/libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter.ts
#	src/libs/Navigation/AppNavigator/createCustomStackNavigator/index.js
#	src/libs/Navigation/AppNavigator/getRootNavigatorScreenOptions.ts
#	src/libs/Navigation/AppNavigator/index.tsx
#	src/libs/Navigation/AppNavigator/modalCardStyleInterpolator.ts
#	src/styles/cardStyles/types.ts
#	src/types/onyx/Report.ts
    @VickyStash
    VickyStash committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    323f54a View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Resolve conflicts after merging main; partly fix TS issues

    @VickyStash
    VickyStash committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    ea93221 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ts-migration/appNavigator-lib 

    # Conflicts:
#	src/SCREENS.ts
#	src/libs/actions/App.ts
    @VickyStash
    VickyStash committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    080e66c View commit details
    Browse the repository at this point in the history

  3. TS fixes after merging main

    @VickyStash
    VickyStash committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    22e369f View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Merge branch 'main' into ts-migration/appNavigator-lib 

    # Conflicts:
#	src/SCREENS.ts
#	src/libs/Navigation/AppNavigator/AuthScreens.tsx
#	src/libs/Navigation/AppNavigator/ModalStackNavigators.js
#	src/libs/Navigation/AppNavigator/Navigators/Overlay.tsx
#	src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx
#	src/libs/Navigation/Navigation.js
#	src/types/onyx/Report.ts
    @VickyStash
    VickyStash committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    0c1164e View commit details
    Browse the repository at this point in the history

  2. Fix TS issues after merging main

    @VickyStash
    VickyStash committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    70bf742 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into ts-migration/appNavigator-lib 

    # Conflicts:
#	src/libs/Navigation/AppNavigator/ModalStackNavigators.js
#	src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx
#	src/libs/Navigation/AppNavigator/RHPScreenOptions.ts
#	src/libs/Navigation/AppNavigator/getRootNavigatorScreenOptions.ts
    @VickyStash
    VickyStash committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    68b31c0 View commit details
    Browse the repository at this point in the history

  4. Fix TS issues after merging main

    @VickyStash
    VickyStash committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    6799a1d View commit details
    Browse the repository at this point in the history

  5. Fix lint issue

    @VickyStash
    VickyStash committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    7580e3a View commit details
    Browse the repository at this point in the history

  6. Run prettier

    @VickyStash
    VickyStash committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    8cb67ac View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Merge branch 'main' into ts-migration/appNavigator-lib 

    # Conflicts:
#	src/libs/Navigation/AppNavigator/ReportScreenIDSetter.ts
    @VickyStash
    VickyStash committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    073bec5 View commit details
    Browse the repository at this point in the history

  2. Update CustomRouter typing

    @VickyStash
    VickyStash committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    16b732f View commit details
    Browse the repository at this point in the history

  3. Use types from Navigation types file

    @VickyStash
    VickyStash committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    603bab0 View commit details
    Browse the repository at this point in the history

  4. Update types file to use screen constants

    @VickyStash
    VickyStash committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    38d5c73 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. AuthScreens improvements

    @VickyStash
    VickyStash committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    bff0598 View commit details
    Browse the repository at this point in the history

  2. Code improvements

    @VickyStash
    VickyStash committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    a22d4f7 View commit details
    Browse the repository at this point in the history

  3. Add empty lines to improve code readability

    @VickyStash
    VickyStash committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    a44f5cd View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into ts-migration/appNavigator-lib

    @VickyStash
    VickyStash committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    c52ba4c View commit details
    Browse the repository at this point in the history

  5. Update createModalStackNavigator typing

    @VickyStash
    VickyStash committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    274073d View commit details
    Browse the repository at this point in the history

  6. Remove extra comments, get rid of ts-expect-error

    @VickyStash
    VickyStash committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    18e25a5 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into ts-migration/appNavigator-lib

    @VickyStash
    VickyStash committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    7a4879c View commit details
    Browse the repository at this point in the history

  8. Update NAVIGATION.md file and commented code

    @VickyStash
    VickyStash committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    371860f View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Remove old screen options; add default values to params

    @VickyStash
    VickyStash committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    5fbf995 View commit details
    Browse the repository at this point in the history

  2. Update ModalStackNavigator typing

    @VickyStash
    VickyStash committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b2ec5a7 View commit details
    Browse the repository at this point in the history

  3. Update reconnectApp function typing

    @VickyStash
    VickyStash committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    0fc1b1e View commit details
    Browse the repository at this point in the history

  4. Minor code improvement

    @VickyStash
    VickyStash committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    d666c0d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into ts-migration/appNavigator-lib

    @VickyStash
    VickyStash committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    d6c824b View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Merge branch 'main' into ts-migration/appNavigator-lib 

    # Conflicts:
#	src/libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter.ts
    @VickyStash
    VickyStash committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    791c713 View commit details
    Browse the repository at this point in the history

  2. Fix TS issue

    @VickyStash
    VickyStash committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    1d6a804 View commit details
    Browse the repository at this point in the history