fix: remove unnecessary dependency #29251

s-alves10 · 2023-10-11T03:05:42Z

Details

Remove unnecessary dependecy to prevent double call of useEffect callback

Fixed Issues

$ #29159
PROPOSAL: #29159 (comment)

Tests

Open ND and log in with any account
[WEB AND DESKTOP ONLY]Open any chat and send an attachment
[WEB AND DESKTOP ONLY]Click on the attachment to open the preview modal
[WEB AND DESKTOP ONLY]Reload the page
[WEB AND DESKTOP ONLY]Press CMD + K or Ctrl + K to open search page
[WEB AND DESKTOP ONLY]Verify that the attachment is closed and the search page appears
Close search page and send any message
Right click to open context menu and select "Delete comment"
Click on "Delete" to confirm
Verify that the message is deleted

Verify that no errors appear in the JS console

Offline tests

Open ND and log in with any account
[WEB AND DESKTOP ONLY]Open any chat and send an attachment
[WEB AND DESKTOP ONLY]Click on the attachment to open the preview modal
[WEB AND DESKTOP ONLY]Reload the page
[WEB AND DESKTOP ONLY]Press CMD + K or Ctrl + K to open search page
[WEB AND DESKTOP ONLY]Verify that the attachment is closed and the search page appears
Close search page and send any message
Right click to open context menu and select "Delete comment"
Click on "Delete" to confirm
Verify that the message is deleted

QA Steps

Open ND and log in with any account
[WEB AND DESKTOP ONLY]Open any chat and send an attachment
[WEB AND DESKTOP ONLY]Click on the attachment to open the preview modal
[WEB AND DESKTOP ONLY]Reload the page
[WEB AND DESKTOP ONLY]Press CMD + K or Ctrl + K to open search page
[WEB AND DESKTOP ONLY]Verify that the attachment is closed and the search page appears
Close search page and send any message
Right click to open context menu and select "Delete comment"
Click on "Delete" to confirm
Verify that the message is deleted

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

29159_android_native.mp4

Android: mWeb Chrome

29159_android_chrome.mp4

iOS: Native

29159_ios_native.mp4

iOS: mWeb Safari

29159_ios_safari.mp4

MacOS: Chrome / Safari

29159_mac_chrome.mp4

MacOS: Desktop

29159_mac_desktop.mp4

melvin-bot · 2023-10-11T03:14:21Z

@Ollyws @nkuoch One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s-alves10 · 2023-10-11T03:14:40Z

@jasperhuangg

I'm not sure why performance tests failed

s-alves10 · 2023-10-11T03:33:52Z

@jasperhuangg

Will you take a look at the PR?

jasperhuangg · 2023-10-11T03:34:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-10.at.8.33.35.PM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-10-11T03:36:03Z

@jasperhuangg looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

jasperhuangg · 2023-10-11T03:38:58Z

All 13 checks passed, not an Emergency

fix: remove unnecessary dependency (cherry picked from commit db45b3e)

OSBotify · 2023-10-11T03:41:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-11T04:20:21Z

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 1.3.80-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-10-11T04:40:44Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.80-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-12T04:48:59Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.3.83-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-13T21:58:38Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:10:41Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:26:54Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T23:02:19Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:13:59Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-16T21:50:19Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: remove unnecessary dependency

24b1681

jasperhuangg self-requested a review October 11, 2023 03:13

s-alves10 marked this pull request as ready for review October 11, 2023 03:14

s-alves10 requested a review from a team as a code owner October 11, 2023 03:14

melvin-bot bot requested review from nkuoch and Ollyws and removed request for a team October 11, 2023 03:14

sangar-1028 added 2 commits October 10, 2023 22:16

fix: try to re-run performance test

8b6e99c

fix: try to re-run performance test

944b338

jasperhuangg approved these changes Oct 11, 2023

View reviewed changes

jasperhuangg merged commit db45b3e into Expensify:main Oct 11, 2023
11 checks passed

melvin-bot bot added the Emergency label Oct 11, 2023

OSBotify pushed a commit that referenced this pull request Oct 11, 2023

Merge pull request #29251 from s-alves10/fix/issue-29159

81fe815

fix: remove unnecessary dependency (cherry picked from commit db45b3e)

OSBotify mentioned this pull request Oct 11, 2023

Deploy Checklist: New Expensify 2023-10-09 #29131

Closed

64 tasks

melvin-bot bot mentioned this pull request Oct 11, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-18] [$500] Web – Chat - Unable to delete message using Context menu #29159

Closed

6 tasks

ishpaul777 mentioned this pull request Oct 11, 2023

[HOLD for payment 2023-10-25] [$500] Fab - App disables CTRL+K / CTRL+SHIFT+K shortcuts on FAB menu option pages #29341

Closed

6 tasks

OSBotify mentioned this pull request Oct 12, 2023

Deploy Checklist: New Expensify 2023-10-12 #29417

Closed

97 tasks

0xmiros mentioned this pull request Oct 12, 2023

[$125] Web - Keyboard shortcuts don't work on Web #29444

Closed

6 tasks

s-alves10 deleted the fix/issue-29159 branch December 21, 2023 07:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove unnecessary dependency #29251

fix: remove unnecessary dependency #29251

s-alves10 commented Oct 11, 2023

melvin-bot bot commented Oct 11, 2023

s-alves10 commented Oct 11, 2023

s-alves10 commented Oct 11, 2023

jasperhuangg commented Oct 11, 2023 •

edited

Loading

melvin-bot bot commented Oct 11, 2023

jasperhuangg commented Oct 11, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 12, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

fix: remove unnecessary dependency #29251

fix: remove unnecessary dependency #29251

Conversation

s-alves10 commented Oct 11, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 11, 2023

s-alves10 commented Oct 11, 2023

s-alves10 commented Oct 11, 2023

jasperhuangg commented Oct 11, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Oct 11, 2023

jasperhuangg commented Oct 11, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 12, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

jasperhuangg commented Oct 11, 2023 •

edited

Loading