Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO QA] Add screenshot requirement to contributing.md #2927

Merged
merged 1 commit into from
May 14, 2021
Merged

[NO QA] Add screenshot requirement to contributing.md #2927

merged 1 commit into from
May 14, 2021

Conversation

Julesssss
Copy link
Contributor

Details

Add the requirement that contributors must share screenshots from all platforms to the contributing document.

Fixed Issues

N/A

Tests

N/A

QA Steps

N/A

@Julesssss Julesssss requested a review from a team May 14, 2021 16:03
@Julesssss Julesssss self-assigned this May 14, 2021
@MelvinBot MelvinBot requested review from chiragsalian and removed request for a team May 14, 2021 16:03
@chiragsalian chiragsalian merged commit 8a485cd into main May 14, 2021
@chiragsalian chiragsalian deleted the jules-addContributingScreenshotRequirement branch May 14, 2021 16:56
@OSBotify OSBotify mentioned this pull request May 14, 2021
Closed
14 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.45-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.46-0🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiragsalian chiragsalian chiragsalian approved these changes

Assignees

@Julesssss Julesssss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Julesssss @OSBotify @chiragsalian