Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Annual-Subscription.md #29472

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Update Annual-Subscription.md #29472

merged 1 commit into from
Oct 13, 2023

Conversation

shmaxey
Copy link
Contributor

@shmaxey shmaxey commented Oct 12, 2023

Updating copy on annual sub page
Replacing "coming soon" text with actual article copy.

https://github.com/Expensify/Expensify/issues/309837

QA Steps

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Updating copy on annual sub page
@shmaxey shmaxey requested a review from a team as a code owner October 12, 2023 18:20
@shmaxey shmaxey self-assigned this Oct 12, 2023
@melvin-bot melvin-bot bot removed the request for review from a team October 12, 2023 18:20
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f1cbf8a
Status: ✅  Deploy successful!
Preview URL: https://c9fabca7.helpdot.pages.dev
Branch Preview URL: https://shmaxey-patch-2.helpdot.pages.dev

View logs

Copy link
Member

@rushatgabhane rushatgabhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

@melvin-bot melvin-bot bot requested a review from Li357 October 12, 2023 21:29
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

@Li357 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #29504.

@Li357 Li357 merged commit bbbfc9c into main Oct 13, 2023
17 checks passed
@Li357 Li357 deleted the shmaxey-patch-2 branch October 13, 2023 02:43
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 13, 2023
@github-actions
Copy link
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1184.733 ms → 1255.674 ms (+70.940 ms, +6.0%) 🔴
App start runJsBundle 800.911 ms → 856.467 ms (+55.556 ms, +6.9%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1184.733 ms
Stdev: 42.119 ms (3.6%)
Runs: 1094.3306059995666 1101.4003229998052 1109.1356070004404 1109.9050519997254 1116.2362299999222 1121.0865890001878 1122.6909220004454 1124.6448389999568 1124.8065569996834 1131.374557999894 1139.9969159998 1140.4071019999683 1140.5752140004188 1141.2554700002074 1143.1426429999992 1145.101766999811 1145.8968820003793 1147.7175510004163 1149.5116379996762 1151.5462159998715 1153.2543010003865 1154.0556939998642 1155.8796150004491 1156.5840509999543 1159.2891499996185 1159.4702350003645 1160.3965819999576 1160.7852400001138 1161.4871530001983 1162.921330999583 1163.3932499997318 1164.4422469995916 1164.9257920002565 1165.2431929996237 1167.1200519995764 1167.718318999745 1167.8415249995887 1169.5420120004565 1169.7036680001765 1171.5899689998478 1178.413329999894 1178.9568130001426 1180.837070000358 1182.4074330003932 1183.0598010001704 1184.5097230002284 1185.2536169998348 1185.4699430000037 1185.6591579997912 1189.7568939998746 1190.070721000433 1190.0812139995396 1190.2050999999046 1190.7784909997135 1190.7943110000342 1192.2665349999443 1193.316810999997 1196.8255000002682 1200.1147069996223 1201.1457299999893 1202.5628709997982 1203.7594130001962 1203.828456000425 1205.266219000332 1205.7439679997042 1207.5162049997598 1208.5846450002864 1209.2613209998235 1210.7662599999458 1211.8304030001163 1215.289321999997 1218.4414400001988 1225.5677610002458 1225.8747640000656 1227.4737900001928 1227.558152999729 1228.8359059998766 1228.908971999772 1231.7640530001372 1235.5947789996862 1241.3979559997097 1246.0824030004442 1247.2161349998787 1253.1422600001097 1258.46750099957 1262.273807999678 1263.087515999563 1265.7625940004364 1266.1148899998516 1271.7313510002568 1274.6982659995556

Current
Mean: 1255.674 ms
Stdev: 53.412 ms (4.3%)
Runs: 1099.1304310001433 1170.831338999793 1177.5239690002054 1178.0096709998325 1178.3233479997143 1185.9529910003766 1187.7839320003986 1188.408773000352 1194.9186209999025 1195.905252999626 1197.5196219999343 1201.536205000244 1202.7727739997208 1204.4357080003247 1207.1539970003068 1208.47791399993 1208.613451000303 1209.4918929999694 1209.6488190004602 1211.2320130001754 1211.3347509996966 1211.7090520001948 1215.0608299998567 1215.926749999635 1216.570632999763 1216.7848540004343 1218.0922149997205 1218.5216720001772 1223.1884030001238 1225.6604100000113 1226.8869120003656 1228.5545089999214 1228.8315199995413 1230.8926459997892 1232.457825999707 1234.170269999653 1235.1036289995536 1237.1389049999416 1238.5578229995444 1241.0090460004285 1243.5202280003577 1243.6649620002136 1245.1160509996116 1245.1797489998862 1247.6895150002092 1248.1630830001086 1249.8274370003492 1250.4145830003545 1252.0861520003527 1258.3647689996287 1258.9691300000995 1259.814418000169 1260.3724899999797 1261.6469360003248 1264.2440649997443 1270.4066700004041 1274.2648120000958 1276.4491969998926 1277.6289990004152 1279.2187919998541 1279.8079829998314 1280.5045940000564 1280.83237299975 1284.8055050000548 1287.9629309996963 1289.5410639997572 1293.8583559999242 1294.2152840001509 1297.5206650001928 1297.968150000088 1298.8138579996303 1301.1652109995484 1301.401883999817 1303.9119849996641 1304.275670000352 1304.7792910002172 1305.4669329999015 1307.5593339996412 1312.8817360000685 1313.859969000332 1315.8041770001873 1328.5143799996004 1328.5919559998438 1332.232890999876 1332.3486230000854 1333.38030000031 1339.7896619997919 1348.3792249998078 1363.0501089999452 1399.8634500000626 1412.0544699998572
App start runJsBundle Baseline
Mean: 800.911 ms
Stdev: 33.495 ms (4.2%)
Runs: 723 728 729 729 734 748 756 756 759 759 760 762 764 764 769 774 776 777 777 778 779 779 781 781 784 784 785 785 786 786 789 789 790 791 791 794 794 795 795 795 796 797 797 799 800 800 802 803 803 804 804 805 806 808 810 810 810 811 811 813 814 814 816 818 822 823 824 824 825 826 826 829 829 830 831 831 832 835 837 839 840 842 852 854 859 860 862 863 876 885

Current
Mean: 856.467 ms
Stdev: 31.312 ms (3.7%)
Runs: 775 800 804 805 813 814 814 814 815 815 818 822 823 825 828 828 829 830 831 832 832 832 833 834 835 838 839 840 840 841 842 842 842 843 846 847 848 849 849 851 852 854 855 856 856 856 857 858 858 858 858 859 859 860 861 861 862 863 866 867 867 867 869 871 872 872 873 874 877 877 882 883 883 885 886 888 896 896 897 898 899 901 902 911 911 913 920 920 922 936

Meaningless Changes To Duration

Show entries
Name Duration
Open Search Page TTI 627.364 ms → 635.679 ms (+8.314 ms, +1.3%)
App start regularAppStart 0.014 ms → 0.015 ms (+0.001 ms, +5.6%)
App start nativeLaunch 20.847 ms → 20.775 ms (-0.072 ms, ±0.0%)
Show details
Name Duration
Open Search Page TTI Baseline
Mean: 627.364 ms
Stdev: 22.402 ms (3.6%)
Runs: 591.740112000145 595.2439379999414 596.9281419999897 598.4763589994982 600.4291590005159 600.8311769999564 600.8507899995893 600.9794920003042 602.2257090006024 605.4521080004051 605.8143720002845 605.8987640002742 605.9478759998456 606.1160899996758 606.8825690001249 607.032308999449 607.2801919998601 607.9022630006075 608.3890379993245 610.8293059999123 611.7557789999992 613.4171959999949 613.4387610005215 613.8940429994836 613.8957919999957 615.0225830003619 615.6151529997587 615.7334799999371 616.2449949998409 616.2590739997104 616.7083740001544 616.8653569994494 617.4242350002751 618.3561610002071 620.7504070000723 622.078409999609 622.2058930005878 622.2622889997438 622.7236330006272 622.7679039994255 623.2213540002704 623.4310710001737 623.5651050005108 623.6948659997433 624.172159999609 624.2406820002943 624.4841310000047 624.5621340004727 624.5743010006845 624.97106899973 625.1156009994447 625.3461109995842 625.3571370001882 626.0524089997634 626.4677740000188 626.9817300001159 630.034546000883 630.6426190007478 631.7576499991119 632.6729330001399 633.8713389998302 634.2966310000047 636.0474040005356 637.2104899995029 638.6070150006562 638.6125490004197 640.9182529998943 646.6038000006229 647.6546629993245 647.9191490001976 649.6994630005211 649.7064209999517 649.7939459998161 650.4170329999179 657.6908369995654 658.5510260006413 661.3020839998499 662.863241000101 663.6872969996184 666.2907320000231 667.7147220000625 670.6220300002024 680.7558599999174 699.5240479996428 701.5959469992667

Current
Mean: 635.679 ms
Stdev: 28.128 ms (4.4%)
Runs: 596.6650799997151 597.763753999956 598.004272999242 600.1968999998644 600.4587000003085 600.9861250007525 604.9819750003517 605.0588389998302 605.3178719999269 606.0742599992082 606.1940519995987 606.3447259999812 607.5142829995602 607.8101400006562 608.2762460000813 611.7390139997005 612.1731770001352 612.3885089997202 612.453166000545 612.487630000338 613.472616000101 614.5342620005831 614.7143560005352 615.2686360003427 615.2870689993724 615.6620690003037 615.7766519999132 616.8834230005741 616.9602870000526 617.1694750003517 617.3777259998024 618.4208169998601 618.7309980001301 621.1336260000244 621.7460940005258 622.66271999944 623.1139320004731 623.9361169999465 624.0596519997343 624.9582110000774 625.4441320002079 625.5211590006948 625.690755000338 626.0286870002747 626.3312590001151 629.3343910006806 629.636637000367 629.7257489999756 630.5132659999654 631.6359049994498 633.0231119999662 633.2661950001493 633.8307710001245 633.9703780002892 634.5439459998161 637.7249360000715 637.7993979994208 637.8409019997343 639.3442379999906 639.6183270001784 642.0555830001831 642.5246179997921 643.8577070003375 646.2394209997728 646.3470869995654 647.6637780005112 648.0681159999222 649.4639079999179 649.494099999778 651.1392830004916 651.9360360000283 655.4167889999226 655.4283450003713 657.8034269995987 658.1134029999375 666.7532560005784 667.4114589998499 670.6612549992278 671.1486009992659 678.7251389995217 680.4549970002845 683.9768480006605 685.0666910000145 685.5746659999713 687.7506920006126 691.2465409999713 692.2253430001438 692.3127039996907 701.7287189997733 706.3708910001442 714.2113450001925
App start regularAppStart Baseline
Mean: 0.014 ms
Stdev: 0.001 ms (6.7%)
Runs: 0.012287999503314495 0.012328999117016792 0.0125730000436306 0.012614000588655472 0.012695999816060066 0.012736000120639801 0.012777000665664673 0.012858999893069267 0.012897999957203865 0.012980000115931034 0.012980000115931034 0.013021000660955906 0.013061000034213066 0.013102000579237938 0.013143000192940235 0.013183999806642532 0.013224000111222267 0.013264999724924564 0.013265000656247139 0.013265000656247139 0.013305999338626862 0.013346000574529171 0.013388000428676605 0.013427999801933765 0.0134680001065135 0.0134680001065135 0.01355000026524067 0.013590999878942966 0.013590999878942966 0.013590999878942966 0.013630999252200127 0.013631000183522701 0.013671999797224998 0.013712999410927296 0.01371300034224987 0.013753000646829605 0.013793000020086765 0.013793999329209328 0.013875000178813934 0.013876000419259071 0.013915999792516232 0.013915999792516232 0.013957000337541103 0.013998000882565975 0.01403799932450056 0.014038000255823135 0.014118999242782593 0.01416000071913004 0.01416000071913004 0.014240999706089497 0.014241000637412071 0.014241000637412071 0.014241999946534634 0.014322999864816666 0.014363999478518963 0.014363999478518963 0.014364000409841537 0.014405000023543835 0.01444500032812357 0.014526000246405602 0.014566999860107899 0.01464799977838993 0.014688999392092228 0.014688999392092228 0.014689000323414803 0.014689999632537365 0.0147299999371171 0.014770999550819397 0.014770999550819397 0.014810999855399132 0.014812000095844269 0.014812000095844269 0.014851999469101429 0.014933000318706036 0.014973999932408333 0.015176999382674694 0.015259000472724438 0.015300000086426735 0.01534000039100647 0.015381000004708767 0.015420999377965927 0.015421000309288502 0.015463000163435936 0.015665999613702297 0.015786999836564064 0.015829000622034073 0.01590999960899353 0.016316999681293964 0.016642000526189804

Current
Mean: 0.015 ms
Stdev: 0.001 ms (5.5%)
Runs: 0.013345999643206596 0.013346999883651733 0.013508999720215797 0.013671999797224998 0.013712000101804733 0.01375299971550703 0.013753999955952168 0.013956000097095966 0.013956000097095966 0.013957000337541103 0.0139979999512434 0.0139979999512434 0.01403799932450056 0.014077999629080296 0.014159999787807465 0.014201000332832336 0.014201000332832336 0.014201000332832336 0.014240999706089497 0.014241999946534634 0.014241999946534634 0.014281999319791794 0.014282000251114368 0.014282000251114368 0.01428299956023693 0.014321999624371529 0.0143630001693964 0.014403999783098698 0.01444500032812357 0.01444500032812357 0.014485000632703304 0.014485000632703304 0.014526000246405602 0.014566999860107899 0.014566999860107899 0.014566999860107899 0.014566999860107899 0.014649000018835068 0.014649000018835068 0.014689000323414803 0.0147299999371171 0.0147299999371171 0.0147299999371171 0.014770999550819397 0.014810999855399132 0.014810999855399132 0.014852000400424004 0.014852000400424004 0.014932999387383461 0.014973999932408333 0.014973999932408333 0.015013999305665493 0.015015000477433205 0.015015000477433205 0.015056000091135502 0.015095999464392662 0.015178000554442406 0.015217999927699566 0.015257999300956726 0.015258999541401863 0.015300000086426735 0.01534000039100647 0.015381000004708767 0.015461999922990799 0.015461999922990799 0.015502999536693096 0.015542999841272831 0.015544000081717968 0.015625 0.015665999613702297 0.015666000545024872 0.015705999918282032 0.01574699953198433 0.015829000622034073 0.015949999913573265 0.015949999913573265 0.015951000154018402 0.01603199914097786 0.016154000535607338 0.016315999440848827 0.016397999599575996 0.01639800053089857 0.016439000144600868 0.01676500029861927 0.01680499967187643 0.01696799974888563
App start nativeLaunch Baseline
Mean: 20.847 ms
Stdev: 2.262 ms (10.9%)
Runs: 18 18 18 18 18 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 24 24 25 25 26 26 27 27 27 27

Current
Mean: 20.775 ms
Stdev: 2.012 ms (9.7%)
Runs: 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 23 23 23 23 23 24 24 24 25 25 26 26 27 27

@github-actions
Copy link
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.84-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform result
🤖 android 🤖 skipped 🚫
🖥 desktop 🖥 skipped 🚫
🍎 iOS 🍎 skipped 🚫
🕸 web 🕸 skipped 🚫

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.85-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants