get image from IOU when there is no source in transaction #29873

c3024 · 2023-10-18T15:43:06Z

Details

Fixed Issues

$ #29855
PROPOSAL: #29855 (comment)

Tests

Click on FAB
Click on Request Money > Manual
Input an mount and click Next
Enter/select an option for the request
Click on the three dot menu at top right
Click on "Add Receipt"
Click on "Choose File"
Select an image
Verify that the image is shown as receipt

Verify that no errors appear in the JS console

Offline tests

Click on FAB
Click on Request Money > Manual
Input an mount and click Next
Enter/select an option for the request
Click on the three dot menu at top right
Click on "Add Receipt"
Click on "Choose File"
Select an image
Verify that the image is shown as receipt

QA Steps

Click on FAB
Click on Request Money > Manual
Input an mount and click Next
Enter/select an option for the request
Click on the three dot menu at top right
Click on "Add Receipt"
Click on "Choose File"
Select an image
Verify that the image is shown as receipt

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-receipt.mp4

Android: mWeb Chrome

mWebChrome.mp4

iOS: Native

Screen.Recording.2023-10-18.at.9.33.48.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-10-18.at.9.28.04.PM.mov

MacOS: Chrome / Safari

webChrome-receipt.mov

MacOS: Desktop

desktop-receipt.mov

melvin-bot · 2023-10-18T15:57:29Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fedirjh · 2023-10-18T16:04:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

CleanShot.2023-10-18.at.17.06.33.mp4

Mobile Web - Chrome

CleanShot.2023-10-18.at.17.29.46.mp4

Mobile Web - Safari

CleanShot.2023-10-18.at.17.14.27.mp4

Desktop

CleanShot.2023-10-18.at.17.20.24.mp4

iOS

CleanShot.2023-10-18.at.17.15.14.mp4

Android

CleanShot.2023-10-18.at.17.44.13.mp4

fedirjh · 2023-10-18T16:26:02Z

src/libs/ReceiptUtils.ts

@@ -25,11 +25,11 @@ type FileNameAndExtension = {
 *
 * @param transaction
 */
-function getThumbnailAndImageURIs(transaction: Transaction): ThumbnailAndImageURI {
+function getThumbnailAndImageURIs(transaction: Transaction, receiptPath: string, receiptFileName: string): ThumbnailAndImageURI {


let's add params to jsdoc

fedirjh · 2023-10-18T16:28:09Z

src/libs/ReceiptUtils.ts

@@ -25,11 +25,11 @@ type FileNameAndExtension = {
 *
 * @param transaction
 */
-function getThumbnailAndImageURIs(transaction: Transaction): ThumbnailAndImageURI {
+function getThumbnailAndImageURIs(transaction: Transaction, receiptPath: string, receiptFileName: string): ThumbnailAndImageURI {


Suggested change

function getThumbnailAndImageURIs(transaction: Transaction, receiptPath: string, receiptFileName: string): ThumbnailAndImageURI {

function getThumbnailAndImageURIs(transaction: Transaction, receiptPath: string | null = null, receiptFileName: string | null = null): ThumbnailAndImageURI {

I think we should make these parameter optional.

Thanks. Done.

fedirjh

Looks good to me

OSBotify · 2023-10-18T17:52:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

get image from IOU when there is no source in transaction (cherry picked from commit 4a1e2b3)

OSBotify · 2023-10-18T18:34:57Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.3.86-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-10-18T23:53:21Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-20T21:40:09Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-23T04:52:21Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

get image from iou if no source in transaction

21b2215

c3024 marked this pull request as ready for review October 18, 2023 15:57

c3024 requested a review from a team as a code owner October 18, 2023 15:57

melvin-bot bot requested review from fedirjh and removed request for a team October 18, 2023 15:57

fedirjh reviewed Oct 18, 2023

View reviewed changes

add jsdoc param and null for optional params

a5f04ac

fedirjh approved these changes Oct 18, 2023

View reviewed changes

melvin-bot bot requested a review from cristipaval October 18, 2023 16:47

cristipaval approved these changes Oct 18, 2023

View reviewed changes

cristipaval merged commit 4a1e2b3 into Expensify:main Oct 18, 2023
14 of 16 checks passed

OSBotify pushed a commit that referenced this pull request Oct 18, 2023

Merge pull request #29873 from c3024/29855-receipt-missing-in-preview

2192d47

get image from IOU when there is no source in transaction (cherry picked from commit 4a1e2b3)

OSBotify mentioned this pull request Oct 18, 2023

Deploy Checklist: New Expensify 2023-10-17 #29837

Closed

youssef-lr mentioned this pull request Oct 18, 2023

[Wave 8 - ECard Transactions] Show EReceipts in ReportPreviews and Attachment View #29474

Merged

70 tasks

melvin-bot bot mentioned this pull request Oct 18, 2023

[HOLD for payment 2023-10-27][$500] Manual - Attachment placeholder is shown in preview instead of receipt after adding a receipt #29855

Closed

6 tasks

OSBotify mentioned this pull request Oct 20, 2023

Deploy Checklist: New Expensify 2023-10-20 #30108

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

get image from IOU when there is no source in transaction #29873

get image from IOU when there is no source in transaction #29873

c3024 commented Oct 18, 2023 •

edited

Loading

melvin-bot bot commented Oct 18, 2023

fedirjh commented Oct 18, 2023 •

edited

Loading

fedirjh Oct 18, 2023

c3024 Oct 18, 2023

fedirjh Oct 18, 2023

c3024 Oct 18, 2023

fedirjh left a comment

OSBotify commented Oct 18, 2023

OSBotify commented Oct 18, 2023

OSBotify commented Oct 18, 2023

OSBotify commented Oct 20, 2023

OSBotify commented Oct 23, 2023

	function getThumbnailAndImageURIs(transaction: Transaction, receiptPath: string, receiptFileName: string): ThumbnailAndImageURI {
	function getThumbnailAndImageURIs(transaction: Transaction, receiptPath: string \| null = null, receiptFileName: string \| null = null): ThumbnailAndImageURI {

get image from IOU when there is no source in transaction #29873

get image from IOU when there is no source in transaction #29873

Conversation

c3024 commented Oct 18, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 18, 2023

fedirjh commented Oct 18, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

fedirjh Oct 18, 2023

Choose a reason for hiding this comment

c3024 Oct 18, 2023

Choose a reason for hiding this comment

fedirjh Oct 18, 2023

Choose a reason for hiding this comment

c3024 Oct 18, 2023

Choose a reason for hiding this comment

fedirjh left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 18, 2023

OSBotify commented Oct 18, 2023

OSBotify commented Oct 18, 2023

OSBotify commented Oct 20, 2023

OSBotify commented Oct 23, 2023

c3024 commented Oct 18, 2023 •

edited

Loading

fedirjh commented Oct 18, 2023 •

edited

Loading