Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if principal's email is public #29929

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Check if principal's email is public #29929

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
657c102
check if principal's email is public
marcochavezf Oct 19, 2023
e413cd5
Merge branch 'main' into marco-checkEmailPrincipal
marcochavezf Oct 30, 2023
c10bfff
fix lint
marcochavezf Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/pages/TeachersUnite/IntroSchoolPrincipalPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import Text from '@components/Text';
import TextInput from '@components/TextInput';
import useLocalize from '@hooks/useLocalize';
import * as ErrorUtils from '@libs/ErrorUtils';
import * as LoginUtils from '@libs/LoginUtils';
import Navigation from '@libs/Navigation/Navigation';
import * as ValidationUtils from '@libs/ValidationUtils';
import styles from '@styles/styles';
Expand Down Expand Up @@ -74,6 +75,9 @@ function IntroSchoolPrincipalPage(props) {
if (!_.isEmpty(values.partnerUserID) && !Str.isValidEmail(values.partnerUserID)) {
ErrorUtils.addErrorMessage(errors, 'partnerUserID', translate('teachersUnitePage.error.enterValidEmail'));
}
if (!_.isEmpty(values.partnerUserID) && LoginUtils.isEmailPublicDomain(values.partnerUserID)) {
ErrorUtils.addErrorMessage(errors, 'partnerUserID', translate('teachersUnitePage.error.tryDifferentEmail'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: Do you think we should use a more descriptive error message? Maybe something on the lines of "Please use an email address associated with your school"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I think this message will be enough because we're already asking in the placeholder to enter a work email for the principal. This is only to cover the case when someone is trying to create a workspace with a public email, which probably is not an authentic school email.

}

return errors;
},
Expand Down
Loading