-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Form Provider Refactor] NewTaskTitlePage #30167
[Form Provider Refactor] NewTaskTitlePage #30167
Conversation
merge main into form-migration/NewTaskTitlePage
@fedirjh fixed the bug in the latest commit fix.mov |
@cdOut I get this warning :
CleanShot.2023-10-26.at.14.06.59.mp4 |
Reviewer Checklist
Screenshots/VideosWebCleanShot.2023-10-26.at.13.51.56.mp4Mobile Web - ChromeCleanShot.2023-10-26.at.15.21.35.mp4Mobile Web - SafariCleanShot.2023-10-26.at.14.11.02.mp4DesktopCleanShot.2023-10-26.at.14.32.21.mp4iOSCleanShot.2023-10-26.at.14.40.06.mp4AndroidCleanShot.2023-10-26.at.17.54.41.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@cdOut it seems like we have merge conflicts! |
@cdOut friendly bump to resolve conflicts |
@luacmartins will get on fixing the conflicts now, thanks for the reminder |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.94-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.94-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.95-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀
|
Details
Changed the Form component into the new FormProvider component in NewTaskTitlePage
Fixed Issues
$ #30000
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
ANDROID-NATIVE.mov
Android: mWeb Chrome
ANDROID-CHROME.mov
iOS: Native
IOS-NATIVE.mov
iOS: mWeb Safari
IOS-SAFARI.mov
MacOS: Chrome / Safari
SAFARI.mov
MacOS: Desktop
DESKTOP.mov