fix: vertical centering button text without padding #30192

s-alves10 · 2023-10-23T18:16:23Z

Details

Fixed Issues

$ #26985
PROPOSAL: #26985 (comment)

Tests

Because button is widely used across the entire app, we need to check various buttons
Below buttons will be checked

small-size button

Show more button in money request confirmation page
Carousel button in attachment view
Add to group button in new chats page
Add stop button in distance request page

medium-size button

Big numpad in request money amount page
Pay button in IOU card
Pay button in IOU report header
Choose file button in Scan request page

large-size button

Connect back account page in workspace reimburse page
Enable wallet button in wallet page
Submit button in Forms

Open ND and log in with any account
Go to workspace chat
Tap + button before the composer and select request money
In scan tab, verify that the Choose file button text isn't cut off
In distance tab, verify that the Add stop button and Next button texts aren't cut off
In manual tab, verify that the Next button text isn't cut off
[MOBILE WEB AND MOBILE] Verify that numpad button texts aren't cut off
Input amount and tap Next
Verify that Show more button and Request button texts aren't cut off
Tap Request button to request money
In workspace chat, verify that Pay with Expensify/Pay elsewhere button texts aren't cut off
Tap IOU card to go to the IOU report
Verify that Pay with Expensify/Pay elsewhere button texts aren't cut off in the report header
Send 2 images in workspace chat
Tap any image just sent to open attachment modal
Verify that > and < button texts aren't cut off
Tap FAB and select Start chat
Verify that Add to group button text isn't cut off
Go to settings -> workspace -> reimbursements page
Verify that Connect bank account button text isn't cut off
Go to settings -> wallet page
Verify that Enable wallet button text isn't cut off
Change language to Spanish and recheck all the steps above

Verify that no errors appear in the JS console

Offline tests

Open ND and log in with any account
Go to workspace chat
Tap + button before the composer and select request money
In scan tab, verify that the Choose file button text isn't cut off
In distance tab, verify that the Add stop button and Next button texts aren't cut off
In manual tab, verify that the Next button text isn't cut off
[MOBILE WEB AND MOBILE] Verify that numpad button texts aren't cut off
Input amount and tap Next
Verify that Show more button and Request button texts aren't cut off
Tap Request button to request money
Turn on the offline mode
In workspace chat, verify that Pay with Expensify/Pay elsewhere button texts aren't cut off
Tap IOU card to go to the IOU report
Verify that Pay with Expensify/Pay elsewhere button texts aren't cut off in the report header
Send 2 images in workspace chat
Tap any image just sent to open attachment modal
Verify that > and < button texts aren't cut off
Tap FAB and select Start chat
Verify that Add to group button text isn't cut off
Go to settings -> workspace -> reimbursements page
Verify that Connect bank account button text isn't cut off
Go to settings -> wallet page
Verify that Enable wallet button text isn't cut off
Change language to Spanish and recheck all the steps above

QA Steps

Open ND and log in with any account
Go to workspace chat
Tap + button before the composer and select request money
In scan tab, verify that the Choose file button text isn't cut off
In distance tab, verify that the Add stop button and Next button texts aren't cut off
In manual tab, verify that the Next button text isn't cut off
[MOBILE WEB AND MOBILE] Verify that numpad button texts aren't cut off
Input amount and tap Next
Verify that Show more button and Request button texts aren't cut off
Tap Request button to request money
In workspace chat, verify that Pay with Expensify/Pay elsewhere button texts aren't cut off
Tap IOU card to go to the IOU report
Verify that Pay with Expensify/Pay elsewhere button texts aren't cut off in the report header
Send 2 images in workspace chat
Tap any image just sent to open attachment modal
Verify that > and < button texts aren't cut off
Tap FAB and select Start chat
Verify that Add to group button text isn't cut off
Go to settings -> workspace -> reimbursements page
Verify that Connect bank account button text isn't cut off
Go to settings -> wallet page
Verify that Enable wallet button text isn't cut off
Change language to Spanish and recheck all the steps above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

26985_android_native1.mp4

26985_android_native2.mp4

Android: mWeb Chrome

26985_android_chrome.mp4

iOS: Native

26985_ios_native1.mp4

26985_ios_native2.mp4

iOS: mWeb Safari

26985_ios_safari1.mp4

26985_ios_safari2.mp4

MacOS: Chrome / Safari

26985_mac_chrome1.mp4

26985_mac_chrome2.mp4

26985_mac_chrome3.mp4

MacOS: Desktop

26985_mac_desktop.mp4

melvin-bot · 2023-10-23T18:27:54Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2023-10-24T07:25:18Z

@s-alves10 Please update the testing steps to cover the whole app. Also, update videos to show most of the buttons on the app. This PR affects all buttons.

s-alves10 · 2023-10-24T09:17:38Z

There is a lot of buttons(about 100) across the whole app. I think we can take one example per button type
For example,

small button in MoneyRequestConfirm page
medium button in IOU card
large button in Wallet page

Please let me know your thoughts @parasharrajat

parasharrajat · 2023-10-24T09:50:23Z

I understand it that's why I said most of the buttons. I would suggest we test all buttons where content is different as well as all the variants as you suggested.

Please create a list of buttons that you tested Componentwise so that it is easier to see and I don't miss any.

s-alves10 · 2023-10-24T14:44:53Z

@parasharrajat

Test steps and videos were updated. Will you take a look again?

parasharrajat · 2023-10-24T15:00:29Z

Thanks. Will check it now.

parasharrajat · 2023-10-25T07:34:25Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-10-25.at.2.14.34.PM.mov

🔲 iOS / Safari

Screen.Recording.2023-10-25.at.2.22.58.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-10-25.at.2.44.49.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-10-25.at.1.48.09.PM.mov

Screen.Recording.2023-10-25.at.1.50.35.PM.mov

🔲 Android / Chrome

Screen.Recording.2023-10-25.at.2.37.54.PM.mov

🔲 Android / native

Screen.Recording.2023-10-25.at.2.25.06.PM.mov

parasharrajat · 2023-10-25T08:01:27Z

src/styles/styles.ts

We should also remove padding from buttonCTA rule.

Yeah, I missed that. Removed the vertical padding from buttonCTA

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

OSBotify · 2023-10-25T16:42:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-25T17:50:25Z

🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.91-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-26T22:41:00Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.91-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-30T08:05:38Z

🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.93-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-31T21:38:47Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.93-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

chiragsalian · 2023-11-01T19:33:50Z

src/styles/styles.ts

@@ -480,7 +480,9 @@ const styles = (theme: ThemeDefault) =>
            borderRadius: variables.buttonBorderRadius,
            minHeight: variables.componentSizeLarge,
            justifyContent: 'center',
+            alignItems: 'center',


i think this change caused this issue

fix: vertical centering button text without padding

08b6850

s-alves10 marked this pull request as ready for review October 23, 2023 18:27

s-alves10 requested a review from a team as a code owner October 23, 2023 18:27

melvin-bot bot requested review from parasharrajat and removed request for a team October 23, 2023 18:27

s-alves10 mentioned this pull request Oct 23, 2023

[HOLD for payment 2023-11-02] [$1000] Android - letter "g" is cut off from the bottom in the IOU card when the language is spanish #26985

Closed

6 tasks

Merge branch 'main' into fix/issue-26985

9146146

parasharrajat suggested changes Oct 25, 2023

View reviewed changes

sangar-1028 added 2 commits October 25, 2023 03:05

Merge branch 'main' into fix/issue-26985

afde388

fix: remove vertical padding from buttonCTA

3271eb0

parasharrajat approved these changes Oct 25, 2023

View reviewed changes

melvin-bot bot requested a review from flodnv October 25, 2023 16:01

flodnv approved these changes Oct 25, 2023

View reviewed changes

flodnv merged commit 1e22431 into Expensify:main Oct 25, 2023
14 of 15 checks passed

OSBotify mentioned this pull request Oct 25, 2023

Deploy Checklist: New Expensify 2023-10-25 #30365

Closed

99 tasks

c3024 mentioned this pull request Oct 26, 2023

[PAID] BA - Icons and text on “Connect online with Plaid” button is offset relative other buttons #30400

Closed

6 tasks

OSBotify mentioned this pull request Oct 30, 2023

Deploy Checklist: New Expensify 2023-10-30 #30560

Closed

chiragsalian reviewed Nov 1, 2023

View reviewed changes

s-alves10 deleted the fix/issue-26985 branch December 21, 2023 07:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: vertical centering button text without padding #30192

fix: vertical centering button text without padding #30192

s-alves10 commented Oct 23, 2023 •

edited

Loading

melvin-bot bot commented Oct 23, 2023

parasharrajat commented Oct 24, 2023 •

edited

Loading

s-alves10 commented Oct 24, 2023

parasharrajat commented Oct 24, 2023 •

edited

Loading

s-alves10 commented Oct 24, 2023

parasharrajat commented Oct 24, 2023

parasharrajat commented Oct 25, 2023 •

edited

Loading

parasharrajat Oct 25, 2023

s-alves10 Oct 25, 2023

parasharrajat left a comment

OSBotify commented Oct 25, 2023

OSBotify commented Oct 25, 2023

OSBotify commented Oct 26, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 31, 2023

chiragsalian Nov 1, 2023

fix: vertical centering button text without padding #30192

fix: vertical centering button text without padding #30192

Conversation

s-alves10 commented Oct 23, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 23, 2023

parasharrajat commented Oct 24, 2023 • edited Loading

s-alves10 commented Oct 24, 2023

parasharrajat commented Oct 24, 2023 • edited Loading

s-alves10 commented Oct 24, 2023

parasharrajat commented Oct 24, 2023

parasharrajat commented Oct 25, 2023 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat Oct 25, 2023

Choose a reason for hiding this comment

s-alves10 Oct 25, 2023

Choose a reason for hiding this comment

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

OSBotify commented Oct 25, 2023

OSBotify commented Oct 25, 2023

OSBotify commented Oct 26, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 31, 2023

chiragsalian Nov 1, 2023

Choose a reason for hiding this comment

s-alves10 commented Oct 23, 2023 •

edited

Loading

parasharrajat commented Oct 24, 2023 •

edited

Loading

parasharrajat commented Oct 24, 2023 •

edited

Loading

parasharrajat commented Oct 25, 2023 •

edited

Loading