-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Lounge Access page #30473
Update Lounge Access page #30473
Conversation
@pecanoro This is looking good! I think we could also remove this This is the And this is just me setting |
@dannymcclain Ohh let me try it! |
@dannymcclain Before I take screenshots for all platforms, what about now? |
Bingo! Love it. |
@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@pecanoro Is it okay if modify Onyx data myself locally to test this since I don't have an account which is a part of paid policy |
Yes, that is totally fine! For some reason the linter wants me to run prettier but I am getting no changes locally, so odd |
Nvm, merging with main solved the linter issues |
Reviewer Checklist
Screenshots/Videos |
Looks good and test well. |
There is a conflict, probably because of new import aliases |
🎯 @alitoshmatov, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #30558. |
Reviewer Checklist
Screenshots/VideosAndroid: Native |
Updated to fix the conflicts, I retested it but it would be great if any of you could check I didn't mess it up. |
On it |
Ready to be merged! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.94-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.94-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.95-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀
|
Details
It simply removes most of the stuff to update Lounge Access page to let people know that we've temporarily closed the lounge
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/329518
PROPOSAL: https://github.com/Expensify/Expensify/issues/329518
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop