Validate login form whever the input is changed #30563

dukenv0307 · 2023-10-30T09:07:09Z

Details

Validate login form whever the input is changed

Fixed Issues

$ #29640
PROPOSAL: #29640 (comment)

Tests

Log out the account
On the login page, enter the invalid email and click on the next button
Verify that the error appears
Change a letter from lowercase to uppercase or vice versa
Verify that the error still appears

Verify that no errors appear in the JS console

Offline tests

QA Steps

Log out the account
On the login page, enter the invalid email and click on the next button
Verify that the error appears
Change a letter from lowercase to uppercase or vice versa
Verify that the error still appears

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-01.at.14.26.22.mov

Android: mWeb Chrome

Screen.Recording.2023-11-01.at.14.20.51.mov

iOS: Native

Screen.Recording.2023-11-01.at.14.24.31.mov

iOS: mWeb Safari

Screen.Recording.2023-11-01.at.14.22.10.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-01.at.14.17.59.mp4

MacOS: Desktop

Screen.Recording.2023-11-01.at.14.30.13.mov

melvin-bot · 2023-10-30T09:58:07Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/signin/LoginForm/BaseLoginForm.js

aimane-chnaif · 2023-11-01T15:26:50Z

BUG: Not able to signin with google on first button click

Screen.Recording.2023-11-01.at.4.25.14.PM.mov

dukenv0307 · 2023-11-01T15:51:25Z

Screen.Recording.2023-11-01.at.22.47.49.mov

I cannot reproduce but do you think we only need to allow validate when the text change after the first time we click on next button? That can prevent the error from appearing when we click on google or apple icon without clicking on the next button.

aimane-chnaif · 2023-11-01T15:56:36Z

we only need to allow validate when the text change after the first time we click on next button?

Nope. It's against Form guideline.

I think there was similar issue in the past. i.e. #12715. Please check how they handled it.

dukenv0307 · 2023-11-01T16:17:01Z

@aimane-chnaif It user onMouseDown event to prevent this issue. But the google icon is rendered by window.google how can we config that?

aimane-chnaif · 2023-11-01T16:26:58Z

@aimane-chnaif It user onMouseDown event to prevent this issue. But the google icon is rendered by window.google how can we config that?

yeah, I am also concerned about that. I think we should raise discussion on the expected behavior.

cc: @Beamanator

aimane-chnaif · 2023-11-01T20:23:33Z

@dukenv0307 meanwhile, please try to look for alternative solution without onMouseDown approach

dukenv0307 · 2023-11-02T05:06:13Z

@aimane-chnaif I updated.

aimane-chnaif · 2023-11-02T05:13:30Z

As lint says, it's not recommended at all

dukenv0307 · 2023-11-02T10:14:05Z

@aimane-chnaif Do you think we can disable eslint here because we only apply it in web.

aimane-chnaif · 2023-11-02T10:16:01Z

Can you test all CTAs on this page? I am still concerned

dukenv0307 · 2023-11-02T10:26:22Z

@aimane-chnaif I tested and it works well. These CTAs are beside the form so it doesn't have any problem when the error appears.

aimane-chnaif · 2023-11-05T16:05:28Z

Let me know when lint is fixed

dukenv0307 · 2023-11-06T06:38:34Z

@aimane-chnaif Updated to fix lint. And I saw that we also disabled this lint here.

App/src/stories/Tooltip.stories.js

Lines 73 to 75 in 925ff67

    
           {/* eslint-disable-next-line jsx-a11y/no-static-element-interactions */} 
        
           <div 
        
               onClick={() => setSize(size + 25)}

Beamanator · 2023-11-06T06:40:01Z

@aimane-chnaif It user onMouseDown event to prevent this issue. But the google icon is rendered by window.google how can we config that?

yeah, I am also concerned about that. I think we should raise discussion on the expected behavior.

cc: @Beamanator

I like the idea of bringing this to slack, though we can probably get away with validating on mouse down of the container that holds the sign in buttons, no? I wonder if the event bubbles up from the google icon to the container? (if that makes sense)

aimane-chnaif · 2023-11-12T21:56:42Z

@aimane-chnaif It user onMouseDown event to prevent this issue. But the google icon is rendered by window.google how can we config that?

yeah, I am also concerned about that. I think we should raise discussion on the expected behavior.
cc: @Beamanator

I like the idea of bringing this to slack, though we can probably get away with validating on mouse down of the container that holds the sign in buttons, no? I wonder if the event bubbles up from the google icon to the container? (if that makes sense)

@dukenv0307 can you do that?

dukenv0307 · 2023-11-13T05:02:33Z

@aimane-chnaif Yes, we can do that. Updated with @Beamanator's suggestion and tested.

Beamanator

A few little changes before we move forward

src/components/SignInButtons/GoogleSignIn/index.website.js

src/pages/signin/LoginForm/BaseLoginForm.js

Beamanator · 2023-11-13T07:56:44Z

Code is looking pretty good to me, though I'm not sure why the PR Reviewer Checklist is failing.. Seems like a bug since it looks like it got updated recently.

@aimane-chnaif will you please do a final retest before we move forward?

aimane-chnaif · 2023-11-13T14:08:13Z

Input is not blurred when click area between social login icons. Hope this wouldn't be considered as "bug"

Screen.Recording.2023-11-13.at.3.07.11.PM.mov

dukenv0307 · 2023-11-13T14:57:49Z

@aimane-chnaif Updated to fix this case.

aimane-chnaif · 2023-11-14T17:48:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

aimane-chnaif

LGTM 🎉
@Beamanator all yours

Beamanator

LGTM (one tiny comment copy change can be done later)

Beamanator · 2023-11-15T05:37:44Z

src/pages/signin/LoginForm/BaseLoginForm.js

-            setFormError('common.pleaseEnterEmailOrPhoneNumber');
-            return;
+        // For native, the single input doesn't lost focus when we click outside.
+        // So we need to change firstBlurred here to make the validate function is called whenever the text input is changed after the first validation.


Suggested change

// So we need to change firstBlurred here to make the validate function is called whenever the text input is changed after the first validation.

// So we need to change firstBlurred here to make sure the validate function is called whenever the text input is changed after the first validation.

OSBotify · 2023-11-15T05:47:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

roryabraham · 2023-11-17T17:08:37Z

This is working locally, but not working as expected on staging: #31413

(yes, this was already deployed to staging. Due to a problem with our deploy code it's just missing its deploy comment)

aimane-chnaif · 2023-11-17T17:12:13Z

We specifically fixed that bug during PR review.

Here's relevant code:
https://github.com/Expensify/App/pull/30563/files#diff-1b8ea63b4b5025e65b513cd701abdfcea77dbc112aa72908381d59dc4a59b3efR316-R321

No idea why doesn't work on staging.

OSBotify · 2023-11-20T13:40:43Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.0-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

validate login form whever the input is changed

f806a94

dukenv0307 marked this pull request as ready for review October 30, 2023 09:58

dukenv0307 requested a review from a team as a code owner October 30, 2023 09:58

melvin-bot bot removed the request for review from a team October 30, 2023 09:58

melvin-bot bot requested a review from aimane-chnaif October 30, 2023 09:58

dukenv0307 added 2 commits October 30, 2023 23:43

fix validate on native

803f9f9

merge main

c73e772

aimane-chnaif reviewed Nov 1, 2023

View reviewed changes

src/pages/signin/LoginForm/BaseLoginForm.js Show resolved Hide resolved

Merge branch 'main' into fix/29640

f5ca2c7

dukenv0307 added 2 commits November 2, 2023 11:58

Merge branch 'main' into fix/29640

fd70844

add onMounseDown for sign icon

d4ef364

fix bug on desktop

5d42500

dukenv0307 added 2 commits November 6, 2023 13:27

Merge branch 'main' into fix/29640

dc7d9ec

fix lint

7000d79

fix lint

5700fff

dukenv0307 added 3 commits November 13, 2023 11:44

Merge branch 'main' into fix/29640

68d7e17

update onMouseDown logic

464dae2

merge main

f3d2261

Beamanator requested changes Nov 13, 2023

View reviewed changes

src/components/SignInButtons/GoogleSignIn/index.website.js Outdated Show resolved Hide resolved

src/components/SignInButtons/GoogleSignIn/index.website.js Outdated Show resolved Hide resolved

src/pages/signin/LoginForm/BaseLoginForm.js Outdated Show resolved Hide resolved

revert hard code

b588fbb

dukenv0307 added 2 commits November 13, 2023 21:54

fix not blured

bd95170

revert hard code

5671583

fix lint

57031a6

aimane-chnaif approved these changes Nov 14, 2023

View reviewed changes

melvin-bot bot requested a review from Beamanator November 14, 2023 17:48

Beamanator approved these changes Nov 15, 2023

View reviewed changes

Beamanator merged commit 3bbb214 into Expensify:main Nov 15, 2023
16 checks passed

s-alves10 mentioned this pull request Nov 16, 2023

[HOLD for payment 2024-02-14] [$500] Login - When try to log in with Google, an error message under email field appears #31413

Closed

6 tasks

esh-g mentioned this pull request Nov 16, 2023

[$500] Login - Validation errors appears when cursor lost focus, a number or a letter is entered #31434

Closed

6 tasks

OSBotify mentioned this pull request Nov 16, 2023

Deploy Checklist: New Expensify 2023-11-15 #31404

Closed

37 tasks

melvin-bot bot mentioned this pull request Nov 20, 2023

[HOLD for payment 2023-11-27] [$500] Login - When user changes CAPS letter to small error cleared but reappears on tapping continue #29640

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate login form whever the input is changed #30563

Validate login form whever the input is changed #30563

dukenv0307 commented Oct 30, 2023 •

edited

Loading

melvin-bot bot commented Oct 30, 2023

aimane-chnaif commented Nov 1, 2023

dukenv0307 commented Nov 1, 2023

aimane-chnaif commented Nov 1, 2023

dukenv0307 commented Nov 1, 2023

aimane-chnaif commented Nov 1, 2023

aimane-chnaif commented Nov 1, 2023

dukenv0307 commented Nov 2, 2023

aimane-chnaif commented Nov 2, 2023

dukenv0307 commented Nov 2, 2023

aimane-chnaif commented Nov 2, 2023

dukenv0307 commented Nov 2, 2023

aimane-chnaif commented Nov 5, 2023

dukenv0307 commented Nov 6, 2023 •

edited

Loading

Beamanator commented Nov 6, 2023 •

edited

Loading

aimane-chnaif commented Nov 12, 2023

dukenv0307 commented Nov 13, 2023

Beamanator left a comment

Beamanator commented Nov 13, 2023 •

edited

Loading

aimane-chnaif commented Nov 13, 2023

dukenv0307 commented Nov 13, 2023

aimane-chnaif commented Nov 14, 2023

aimane-chnaif left a comment

Beamanator left a comment

Beamanator Nov 15, 2023

OSBotify commented Nov 15, 2023

roryabraham commented Nov 17, 2023 •

edited

Loading

aimane-chnaif commented Nov 17, 2023

OSBotify commented Nov 20, 2023

	// So we need to change firstBlurred here to make the validate function is called whenever the text input is changed after the first validation.
	// So we need to change firstBlurred here to make sure the validate function is called whenever the text input is changed after the first validation.

Validate login form whever the input is changed #30563

Validate login form whever the input is changed #30563

Conversation

dukenv0307 commented Oct 30, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 30, 2023

aimane-chnaif commented Nov 1, 2023

dukenv0307 commented Nov 1, 2023

aimane-chnaif commented Nov 1, 2023

dukenv0307 commented Nov 1, 2023

aimane-chnaif commented Nov 1, 2023

aimane-chnaif commented Nov 1, 2023

dukenv0307 commented Nov 2, 2023

aimane-chnaif commented Nov 2, 2023

dukenv0307 commented Nov 2, 2023

aimane-chnaif commented Nov 2, 2023

dukenv0307 commented Nov 2, 2023

aimane-chnaif commented Nov 5, 2023

dukenv0307 commented Nov 6, 2023 • edited Loading

Beamanator commented Nov 6, 2023 • edited Loading

aimane-chnaif commented Nov 12, 2023

dukenv0307 commented Nov 13, 2023

Beamanator left a comment

Choose a reason for hiding this comment

Beamanator commented Nov 13, 2023 • edited Loading

aimane-chnaif commented Nov 13, 2023

dukenv0307 commented Nov 13, 2023

aimane-chnaif commented Nov 14, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

Beamanator left a comment

Choose a reason for hiding this comment

Beamanator Nov 15, 2023

Choose a reason for hiding this comment

OSBotify commented Nov 15, 2023

roryabraham commented Nov 17, 2023 • edited Loading

aimane-chnaif commented Nov 17, 2023

OSBotify commented Nov 20, 2023

dukenv0307 commented Oct 30, 2023 •

edited

Loading

dukenv0307 commented Nov 6, 2023 •

edited

Loading

Beamanator commented Nov 6, 2023 •

edited

Loading

Beamanator commented Nov 13, 2023 •

edited

Loading

roryabraham commented Nov 17, 2023 •

edited

Loading