Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rodrigo fix shortcut bindings #30602

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Rodrigo fix shortcut bindings #30602

merged 2 commits into from
Oct 30, 2023

Conversation

rlinoz
Copy link
Contributor

@rlinoz rlinoz commented Oct 30, 2023

Details

We never added event handlers for left and right arrow keys, that wasn't a problem before because we used to use underscore.js every method which checks if the key exists.

Fixed Issues

$ #30593

Tests

  1. Open a chat in ND
  2. Type any sentence
  3. Open the console
  4. Move the cursor with the arrow keys
  5. Verify that no console error appears
  6. Use every other shortcut available (eg: cmd+k)
  7. Verify that it works
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Open a chat in ND
  2. Type any sentence
  3. Open the console
  4. Move the cursor with the arrow keys
  5. Verify that no console error appears
  6. Use every other shortcut available (eg: cmd+k)
  7. Verify that it works
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2023-10-30.at.18.06.47.mov

@rlinoz rlinoz requested a review from a team as a code owner October 30, 2023 18:09
@melvin-bot melvin-bot bot removed the request for review from a team October 30, 2023 18:09
@rlinoz rlinoz self-assigned this Oct 30, 2023
@melvin-bot melvin-bot bot requested a review from situchan October 30, 2023 18:09
@melvin-bot
Copy link

melvin-bot bot commented Oct 30, 2023

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@situchan
Copy link
Contributor

situchan commented Oct 30, 2023

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
android.mov
Android: mWeb Chrome
mchrome.mov
iOS: Native
ios.mov
iOS: mWeb Safari
msafari.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov

Copy link
Contributor

@situchan situchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@melvin-bot melvin-bot bot requested a review from joelbettner October 30, 2023 18:43
@melvin-bot
Copy link

melvin-bot bot commented Oct 30, 2023

@joelbettner Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@joelbettner joelbettner merged commit a26b8df into main Oct 30, 2023
17 checks passed
@joelbettner joelbettner deleted the rodrigo-fix-shortcut-bindings branch October 30, 2023 20:52
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 30, 2023
@github-actions
Copy link
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1164.262 ms → 1296.298 ms (+132.036 ms, +11.3%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1164.262 ms
Stdev: 32.015 ms (2.7%)
Runs: 1086.1572599997744 1090.5849500000477 1106.677862000186 1111.0762780001387 1113.336072999984 1114.7699420000426 1116.2396959997714 1120.3733120001853 1128.8329139999114 1134.0194470002316 1135.2280830000527 1135.314981999807 1136.5669419998303 1137.55502300011 1137.7814150000922 1138.6289510000497 1139.8348150001839 1140.637116999831 1141.5914989998564 1142.6850669998676 1143.2230750001036 1143.9095279998146 1147.4088400001638 1147.9778950000182 1149.3980009998195 1150.0909819998778 1151.185473000165 1152.0618799999356 1153.0674850000069 1153.9062839997932 1155.6489849998616 1156.8949839998968 1157.46499199979 1160.7050160001963 1160.8011320000514 1160.9589920002036 1160.980008999817 1161.318597999867 1161.6853169999085 1161.9064090000466 1162.012732999865 1162.783121000044 1162.8144919998012 1163.3694670000114 1163.4453280000016 1164.4264949997887 1168.6124869999476 1169.169885000214 1170.8953539999202 1172.5136250001378 1173.2685090000741 1173.94979899982 1176.3870040001348 1176.5284959999844 1177.0530989998952 1181.16256600013 1182.7471269997768 1185.865954999812 1187.198406000156 1188.270151999779 1188.7537569999695 1189.15340499999 1189.9334379998036 1192.8648009998724 1194.6492809997872 1195.3840250000358 1195.4683610000648 1195.6523589999415 1197.9492210000753 1199.0171249997802 1199.8400799999945 1200.6864539999515 1202.3251769999042 1202.4039739998989 1214.7265449999832 1229.3267370001413 1238.427343999967 1243.8972220001742 1245.3075729999691

Current
Mean: 1296.298 ms
Stdev: 38.965 ms (3.0%)
Runs: 1204.927149000112 1217.2396470000967 1220.4835109999403 1222.3792300000787 1232.5000280002132 1242.142351000104 1242.2592449998483 1245.2785629997961 1245.3280739998445 1253.0037070000544 1258.454735999927 1259.5711280000396 1260.378866000101 1260.5037090000696 1263.0790099999867 1264.530129000079 1265.6144139999524 1266.6330149997957 1267.6342319999821 1267.9625610001385 1270.0181959997863 1271.3470350001007 1272.3673009998165 1273.400549999904 1274.1004380001687 1276.1397580001503 1276.4582139998674 1277.1244230000302 1277.1615550001152 1281.3437700001523 1282.5903329998255 1283.632511000149 1284.0641990001313 1288.3036699998192 1289.050096000079 1291.2153559997678 1292.0877539999783 1292.455643999856 1294.213909999933 1294.7302359999157 1295.2541669998318 1299.2075049998239 1300.2861959999427 1301.3620480000973 1302.0112629998475 1302.179773000069 1304.3473359998316 1308.5973510001786 1311.0434409999289 1311.2252630000003 1312.1390490001068 1312.9709669998847 1315.0410910001956 1318.1780329998583 1319.0996630000882 1319.5309069999494 1320.676764999982 1324.1575440000743 1325.0828599999659 1325.4880110002123 1326.491717999801 1326.5845639999025 1326.604716999922 1327.192329000216 1328.3363089999184 1332.3577160001732 1333.2313729999587 1334.1668710000813 1338.3042109999806 1340.1735009998083 1344.6256780000404 1346.9801559997723 1351.2110000001267 1353.6786670000292 1359.2660429999232 1361.6552909999155 1365.40933699999 1388.0803080000915 1393.6268099998124

Meaningless Changes To Duration

Show entries
Name Duration
App start runJsBundle 815.922 ms → 907.909 ms (+91.987 ms, +11.3%)
Open Search Page TTI 707.323 ms → 746.912 ms (+39.589 ms, +5.6%)
App start nativeLaunch 19.474 ms → 22.403 ms (+2.928 ms, +15.0%) 🟡
App start regularAppStart 0.014 ms → 0.016 ms (+0.002 ms, +13.4%)
Show details
Name Duration
App start runJsBundle Baseline
Mean: 815.922 ms
Stdev: 24.155 ms (3.0%)
Runs: 761 764 772 779 781 782 782 787 788 788 788 789 789 793 793 794 795 797 797 799 801 801 801 802 803 805 808 810 811 811 811 811 811 812 813 814 815 815 815 815 816 818 818 819 820 822 822 823 824 824 824 824 825 825 826 826 830 831 832 833 833 835 836 837 838 842 844 847 848 854 854 854 855 858 862 864 880

Current
Mean: 907.909 ms
Stdev: 28.417 ms (3.1%)
Runs: 832 850 857 858 865 866 866 868 869 870 872 872 877 880 881 882 884 884 885 885 892 896 897 897 897 898 898 900 901 903 903 904 905 905 905 907 907 907 907 911 911 913 913 914 914 915 915 917 919 920 923 924 924 925 925 926 927 928 929 929 930 931 932 934 935 935 937 940 941 945 945 950 951 954 958 964 973
Open Search Page TTI Baseline
Mean: 707.323 ms
Stdev: 43.074 ms (6.1%)
Runs: 643.8950199997053 648.1199139999226 651.6437579998747 651.7128090001643 652.4750580000691 653.4047449999489 657.0190440001898 657.7624920001253 658.4021399999037 658.9205320002511 659.925741000101 662.9660649998114 664.6180019997992 665.5104169999249 666.1448569996282 666.1467699999921 666.4831960001029 666.896851000376 667.2006430001929 668.3895669998601 668.6189379999414 674.5635580001399 675.8417980000377 676.1139740003273 676.8949790000916 677.4034839998931 677.5363360000774 680.4168710000813 680.8417569999583 681.0445970003493 681.9217940000817 682.7563069998287 685.1072189998813 686.297038000077 686.5453289998695 693.3013100000098 694.5452479999512 694.975626999978 695.3059080000967 700.1084389998578 701.7912600003183 701.9161390000954 703.9606130002066 704.373128999956 705.5684409998357 705.9281419999897 706.0278730001301 708.553425999824 711.000163000077 712.0363770001568 714.9425869998522 716.1427819998935 717.8364669997245 719.0259610000066 723.2611090000719 723.5060629998334 725.5336099998094 730.3653159998357 731.5271409996785 732.1716310000047 733.5483400002122 733.875692000147 739.256713999901 749.0933439997025 752.1411129999906 752.7243660003878 755.8012699997053 757.9223629999906 763.1258959998377 766.3142099999823 770.5008140001446 771.4569500000216 775.5831710002385 778.3166099996306 781.3329269997776 782.6522619999014 789.969402000308 790.415934999939 794.1323650004342 794.5216070003808 807.2583830002695

Current
Mean: 746.912 ms
Stdev: 45.796 ms (6.1%)
Runs: 651.3227550000884 656.9325769999996 669.4538579997607 672.5891929999925 678.644654000178 681.3516440000385 688.1365970000625 689.1308600003831 690.1554769999348 691.0689289998263 692.3981529995799 694.4457599995658 696.5338960001245 700.2614750000648 702.0302740000188 703.7779549998231 705.1141769997776 705.7266440000385 707.8359779999591 708.7217200002633 712.405273000244 716.0175779997371 716.6772059998475 718.2491049999371 722.2663579997607 722.8786220001057 725.6062819999643 725.8052989998832 725.8700769999996 726.3908699997701 727.3843590002507 728.5793870002963 730.4908449999057 730.9501959998161 731.7149660000578 736.3609220003709 736.5311280000024 742.4256589999422 745.1687819999643 750.2545579997823 750.8860269999132 755.2051189998165 755.5343019999564 756.1417240002193 756.2589929997921 757.9643149999902 758.4058030000888 758.4482019999996 758.5522469999269 759.1515300003812 760.3727219998837 762.8085940000601 763.9389249999076 764.8085539997555 765.0295009999536 766.6338310004212 767.3427740000188 767.663290000055 768.6159270000644 769.0601809998043 771.7089039999992 771.9147950001061 778.897501999978 779.7226569997147 780.334472999908 781.287476000376 787.3353279996663 787.7191570000723 797.9365240000188 803.0661619999446 804.3616129998118 805.5538739999756 812.1868080003187 812.7976890001446 813.319010999985 828.671711999923 833.1617029998451 835.6064050002024 840.5345049998723 841.231811999809 852.0646159998141
App start nativeLaunch Baseline
Mean: 19.474 ms
Stdev: 1.318 ms (6.8%)
Runs: 17 17 17 17 17 18 18 18 18 18 18 18 18 18 18 18 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22

Current
Mean: 22.403 ms
Stdev: 1.478 ms (6.6%)
Runs: 19 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 23 23 23 23 23 23 24 24 24 24 24 24 24 24 24 24 24 25 25 25 25 26 26
App start regularAppStart Baseline
Mean: 0.014 ms
Stdev: 0.001 ms (6.6%)
Runs: 0.012613000348210335 0.012858000118285418 0.012858000118285418 0.01293900003656745 0.013020999729633331 0.013021000195294619 0.013061999808996916 0.013182999566197395 0.01318400027230382 0.01322399964556098 0.013224999886006117 0.013305999804288149 0.013387000188231468 0.013427999801933765 0.0134680001065135 0.013590999878942966 0.013630999717861414 0.013712000101804733 0.01371300034224987 0.013753000181168318 0.013753000181168318 0.013753999955952168 0.013753999955952168 0.013793999794870615 0.013875000178813934 0.013915999792516232 0.013916000258177519 0.013957000337541103 0.014078999869525433 0.01411899970844388 0.01411899970844388 0.014159999787807465 0.014161000028252602 0.0142000000923872 0.014200999867171049 0.014201000332832336 0.014241999946534634 0.014281999785453081 0.014282000251114368 0.014282000251114368 0.014283000025898218 0.014444999862462282 0.014485000167042017 0.014485999941825867 0.014525999780744314 0.014526000246405602 0.014607999939471483 0.014607999939471483 0.01464799977838993 0.014771000016480684 0.014771000016480684 0.014771000016480684 0.014812000095844269 0.014851999934762716 0.014851999934762716 0.014851999934762716 0.014932999853044748 0.014973999932408333 0.015055000316351652 0.015055000316351652 0.01509599993005395 0.015137000009417534 0.015137000009417534 0.015217999927699566 0.01525900000706315 0.01525900000706315 0.01525900000706315 0.015339999925345182 0.015503000002354383 0.01570600038394332 0.0157880000770092 0.0157880000770092 0.01582799991592765 0.015829000156372786 0.015950000379234552 0.016153999604284763 0.016195000149309635 0.016195000149309635 0.016600999981164932 0.016846000216901302

Current
Mean: 0.016 ms
Stdev: 0.001 ms (4.7%)
Runs: 0.014526000246405602 0.014566999860107899 0.014688999857753515 0.0148930000141263 0.015014000236988068 0.015137000009417534 0.015176999848335981 0.01525900000706315 0.015299000311642885 0.015339999925345182 0.015461999922990799 0.015542999841272831 0.01554399961605668 0.015583999920636415 0.015625 0.015664999838918447 0.015666000079363585 0.01570600038394332 0.01570700015872717 0.015746999997645617 0.015910000074654818 0.016031999606639147 0.016032000072300434 0.01607299968600273 0.01607299968600273 0.01607300015166402 0.016112999990582466 0.016113999765366316 0.01615400006994605 0.01615400006994605 0.01615400006994605 0.01615400006994605 0.016235999763011932 0.01627599960193038 0.016276000067591667 0.016316000372171402 0.01635799976065755 0.016398000065237284 0.01643899967893958 0.016478999983519316 0.016478999983519316 0.016561000142246485 0.016561000142246485 0.01660200022161007 0.01660200022161007 0.01664199959486723 0.016642000060528517 0.016642000060528517 0.0167239997535944 0.0167239997535944 0.016724000219255686 0.016764000058174133 0.016764000058174133 0.016845999751240015 0.016846000216901302 0.016846000216901302 0.01688600005581975 0.01688600005581975 0.01688600005581975 0.01688600005581975 0.0168869998306036 0.016926999669522047 0.016927000135183334 0.017008000053465366 0.017008999828249216 0.017048999667167664 0.017089999746531248 0.017089999746531248 0.017211999744176865 0.017212000209838152 0.0172520000487566 0.017374000046402216 0.0174150001257658 0.017416000366210938 0.017455999739468098 0.017456000205129385 0.017537000123411417 0.017659999895840883 0.01814799988642335

@github-actions
Copy link
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@hannojg
Copy link
Contributor

hannojg commented Oct 31, 2023

The reported deploy blocker is likely a false positive, investigating …

@Julesssss Julesssss removed the DeployBlockerCash This issue or pull request should block deployment label Oct 31, 2023
@Julesssss
Copy link
Contributor

Removing the blocker label and ignoring the performance check, as it's currently reporting false positives.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.94-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

1 similar comment
@OSBotify
Copy link
Contributor

OSBotify commented Nov 1, 2023

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.94-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 2, 2023

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 2, 2023

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.95-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Nov 6, 2023

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants