Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Add STORYBOOK.md #3061

Merged
merged 1 commit into from
May 24, 2021
Merged

[No QA] Add STORYBOOK.md #3061

merged 1 commit into from
May 24, 2021

Conversation

marcaaron
Copy link
Contributor

Details

Adds some background information and guide to using Storybook.

Fixed Issues

No issue

No QA

@marcaaron marcaaron self-assigned this May 21, 2021
@marcaaron marcaaron requested a review from Julesssss May 21, 2021 17:19
@marcaaron marcaaron marked this pull request as ready for review May 21, 2021 17:19
@marcaaron marcaaron requested a review from a team as a code owner May 21, 2021 17:19
@MelvinBot MelvinBot requested review from joelbettner and removed request for a team May 21, 2021 17:19
Julesssss
Julesssss approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we should encourage that people write a story when creating a new common component so that you don't end up implementing them all yourself. But this looks good for now

@Julesssss Julesssss merged commit 121adc2 into main May 24, 2021
@Julesssss Julesssss deleted the marcaaron-storybookDocs branch May 24, 2021 14:21
@OSBotify OSBotify mentioned this pull request May 24, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julesssss Julesssss Julesssss approved these changes

@joelbettner joelbettner Awaiting requested review from joelbettner

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcaaron @Julesssss