fix: Receipt - The border green line on top and bottom in native.

[Krishna2323]

Details

Fixed Issues

$ #30284
PROPOSAL: #30284 (comment)

Tests

1. Go to https://staging.new.expensify.com/
2. Tap fab
3. Tap request money-----manual
4. Enter an amount
5. Tap next
6. Select any user
7. Tap 3 dots on top right to select "add receipt"
8. Verify there is rounded green line border on top and bottom

• Verify that no errors appear in the JS console

Offline tests

1. Go to https://staging.new.expensify.com/
2. Tap fab
3. Tap request money-----manual
4. Enter an amount
5. Tap next
6. Select any user
7. Tap 3 dots on top right to select "add receipt"
8. Verify there is rounded green line border on top and bottom

QA Steps

1. Go to https://staging.new.expensify.com/
2. Tap fab
3. Tap request money-----manual
4. Enter an amount
5. Tap next
6. Select any user
7. Tap 3 dots on top right to select "add receipt"
8. Verify there is rounded green line border on top and bottom

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

[melvin-bot]

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Krishna2323]

@situchan, the camera view doesn't open in IOS native, can you pls check.

[situchan]

@situchan, the camera view doesn't open in IOS native, can you pls check.

you may need to test on physical device

[Krishna2323]

@situchan, I don't have a IOS device 🥲

[situchan]

cameraPermissionStatus check is redundant. This should be enough.

Suggested change

	style={{...styles.videoContainer, display: cameraPermissionStatus !== RESULTS.GRANTED ? 'none' : 'block'}}
	style={styles.flex1}

Any concern on this suggestion?

[Krishna2323]

Agree with you, cameraPermissionStatus check is redundant, now removed but I haven't removed videoContainer styling since we are using it in non-native view.

[situchan]

I tested on iOS physical device. It breaks style

[Krishna2323]

@situchan, can you pls check once again.

[Krishna2323]

@situchan, can you pls guide me how to run the app on physical device, I will try to get a IOS device for today.

[situchan]

@situchan, can you pls guide me how to run the app on physical device, I will try to get a IOS device for today.

#30374 (comment)

[Krishna2323]

Thanks 👍🏻

[Krishna2323]

@situchan, can you pls help, I'm unable to build on physical device, maybe there are multiple issues like different apple id account, it's not my phone so I can't make changes to the phone settings and profile. I made a style change after you tested, can you pls check once again when you have sometime.

[situchan]

@Krishna2323 same

Note: current production iOS app works perfect like mWeb. You can install from appstore and confirm.
This issue happens only on android native.

[situchan]

If you are not able to fix iOS, we can reassign someone who can test on iPhone.

[Krishna2323]

@situchan, can I open a new PR, I'm facing weird merge conflict issue and while resolving it I deleted all commits here.
The issue is fixed on IOS also:

Video.mov

[situchan]

can I open a new PR

No problem