Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request money placeholder #3069

Merged
merged 3 commits into from
May 24, 2021
Merged

Conversation

marcaaron
Copy link
Contributor

Details

cc @deetergp @shawnborton

Web/desktop views are confusing because it's not an obvious input to put stuff in.

Fixed Issues

No issues related to a slack convo here

Tests

QA Steps (Web/Desktop only)

  1. Select "Request Money" while in an open chat on web/desktop wide screen view
  2. Verify there is a placeholder

Tested On

  • Web
  • Desktop
  • Mobile Web
  • iOS
  • Android

Screenshots

Web

2021-05-21_10-28-32

Desktop

2021-05-21_10-30-28

@marcaaron marcaaron self-assigned this May 21, 2021
@marcaaron marcaaron requested a review from a team as a code owner May 21, 2021 20:33
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team May 21, 2021 20:33
@shawnborton
Copy link
Contributor

Nice!

Copy link
Contributor

@jasperhuangg jasperhuangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

@jasperhuangg jasperhuangg merged commit 059330f into main May 24, 2021
@jasperhuangg jasperhuangg deleted the marcaaron-requestMoneyPlaceholder branch May 24, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants