Fix copy invite room message #30898

dukenv0307 · 2023-11-06T05:09:46Z

Details

Fix copy invite room message

Fixed Issues

$ #30272
PROPOSAL: #30272 (comment)

Tests

Create a room
Click on the header of the room > Invite
Invite some users
After the invite message appears, hover over this message and click on copy to clipboard
Paste it to composer, verify that the message that is copied is the same as the invite message displayed
Go to admin room of the workspace
Copy policy log of invite action above
Paste it to composer, and verify that the message that is copied is the same as the invite message displayed

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Create a room
Click on the header of the room > Invite
Invite some users
After the invite message appears, hover over this message and click on copy to clipboard
Paste it to composer, verify that the message that is copied is the same as the invite message displayed
Go to admin room of the workspace
Copy policy log of invite action above
Paste it to composer, and verify that the message that is copied is the same as the invite message displayed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-06.at.11.55.59.mov

Screen.Recording.2023-11-08.at.15.57.58.mov

Android: mWeb Chrome

Screen.Recording.2023-11-06.at.11.27.16.mov

iOS: Native

Screen.Recording.2023-11-06.at.11.45.59.mov

iOS: mWeb Safari

Screen.Recording.2023-11-06.at.11.32.40.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-06.at.11.17.22.mov

MacOS: Desktop

Screen.Recording.2023-11-06.at.12.01.39.mov

melvin-bot · 2023-11-06T05:10:02Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/ReportUtils.js

src/styles/fontFamily/multiFontFamily.ts

src/libs/ReportUtils.js

dukenv0307 · 2023-11-07T09:50:44Z

@cubuspl42 I updated, please help to review again.

cubuspl42 · 2023-11-07T11:44:45Z

src/libs/ReportUtils.js

+ * @param {Object} reportAction
+ * @returns {String}
+ */
+function getRoomChannelLogMemberMessage(reportAction) {


Looks better! But I have a suggestion to increase the simplicity of the function. Let me know if you agree.

/** * Return room channel log display message * * @param {Object} reportAction * @returns {String} */ function getRoomChannelLogMemberMessage(reportAction) { const actionPerformed = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ROOMCHANGELOG.INVITE_TO_ROOM ? 'invited' : 'removed'; const mentions = _.map(reportAction.originalMessage.targetAccountIDs, (accountID) => { const personalDetail = lodashGet(allPersonalDetails, accountID); const displayNameOrLogin = LocalePhoneNumber.formatPhoneNumber(lodashGet(personalDetail, 'login', '')) || lodashGet(personalDetail, 'displayName', '') || Localize.translateLocal('common.hidden'); return `@${displayNameOrLogin}`; }); const lastMention = mentions.pop(); if (mentions.length === 0) { return `${actionPerformed} ${lastMention}`; } return `${actionPerformed} ${mentions.join(', ')} and ${lastMention}`; }

Look good to me. Will update soon.

@cubuspl42 I updated.

cubuspl42 · 2023-11-07T12:19:08Z

src/libs/ReportUtils.js

-    if (listMention.length === 1) {
-        lastPrefix = ' and ';
+
+    if (mentions.length === 1) {


Have you actually tested that this case is required? I thought I tested it with my suggested variant

Oh... I think I get it

Still, I think this logic is still slightly more readable (even if the advantage is smaller than I originally assumed)

cubuspl42 · 2023-11-07T12:34:15Z

Bad news: I think we'll need to expand the scope of the PR to handle another variant of the invited @foo, @bar, @baz message, which is nearly the same as ours, but not quite.

In the #admins channel, we have a message variant like this:

dukenv0307 · 2023-11-07T12:37:14Z

I think we can do that in the function of this PR.

cubuspl42 · 2023-11-07T12:45:34Z

@dukenv0307 Great! We'll need to expand the testing steps. When you do this, please re-upload at least the Web ("MacOS: Chrome / Safari") platform video.

dukenv0307 · 2023-11-08T08:59:40Z

@cubuspl42 Updated to fix copy policy log and rename the variable to the same as we used in SidebarUtils.

cubuspl42 · 2023-11-08T11:02:16Z

I'm having trouble observing the invite logs in the #admins channel...

In one case, I got information about one user being invited to a room when I invited three users at once:

In another case, I got no update about inviting to a room.

Do you always get reliable logs in #admins about the invited users, no matter how many you add at once?

dukenv0307 · 2023-11-08T14:47:51Z

@cubuspl42 Can you share a video for this case?

cubuspl42 · 2023-11-09T10:22:54Z

@cubuspl42 Can you share a video for this case?

admin-log-issue-web.mp4

invited @cubuspl42.1+1@gmail.com, @cubuspl42.1+3@gmail.com, and @cubuspl42.1+5@gmail.com

...but in #admins only:

invited @cubuspl42.1+5@gmail.com to #social12

I'm not saying this is something your PR introduced, but it complicates the testing 🫤

dukenv0307 · 2023-11-14T04:37:37Z

@cubuspl42 I tested sometimes and didn't face this issue.

cubuspl42 · 2023-11-14T09:27:01Z

@dukenv0307 I'll re-test

cubuspl42 · 2023-11-15T11:12:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

invited-members-copy-to-clipboard-web.mp4

Mobile Web - Chrome

invited-members-copy-to-clipboard-android-web-compressed.mp4

Mobile Web - Safari

invited-members-copy-to-clipboard-ios-web.mp4

Desktop

iOS

invited-members-copy-to-clipboard-ios.mp4

Android

invited-members-copy-to-clipboard-android-compressed.mp4

dukenv0307 · 2023-11-16T09:08:37Z

@cubuspl42 Is this PR already to approve?

cubuspl42 · 2023-11-16T09:29:29Z

@dukenv0307 Thank you for reminding me. I submitted the checklist without approving.

OSBotify · 2023-11-16T15:34:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-22T00:49:39Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.1-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

shubham1206agra · 2024-01-03T16:07:38Z

src/libs/ReportUtils.js

+            reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ROOMCHANGELOG.INVITE_TO_ROOM || reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.POLICYCHANGELOG.INVITE_TO_ROOM
+                ? ' to'
+                : ' from';
+        message += `${preposition} ${roomName}`;


Minor bug from here, the room name was not shown as link. More details here #31568

Fix copy invite room message

9fbb883

dukenv0307 marked this pull request as ready for review November 6, 2023 05:09

dukenv0307 requested a review from a team as a code owner November 6, 2023 05:09

melvin-bot bot removed the request for review from a team November 6, 2023 05:10

melvin-bot bot requested a review from cubuspl42 November 6, 2023 05:10

cubuspl42 reviewed Nov 6, 2023

View reviewed changes

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

cubuspl42 reviewed Nov 6, 2023

View reviewed changes

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

cubuspl42 reviewed Nov 6, 2023

View reviewed changes

src/styles/fontFamily/multiFontFamily.ts Outdated Show resolved Hide resolved

cubuspl42 reviewed Nov 6, 2023

View reviewed changes

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

dukenv0307 added 2 commits November 7, 2023 16:28

merge main

c1ddbef

refactor function

427be61

cubuspl42 reviewed Nov 7, 2023

View reviewed changes

simplicity function

4df098e

cubuspl42 reviewed Nov 7, 2023

View reviewed changes

cubuspl42 mentioned this pull request Nov 7, 2023

translate invite member to room #30927

Merged

58 tasks

dukenv0307 added 2 commits November 8, 2023 15:30

Merge branch 'main' into fix/30272

db16de3

fix copy message for policy member log

65c5cc9

cubuspl42 mentioned this pull request Nov 9, 2023

[HOLD for payment 2023-12-15] [$500] Dev: Alternate text on sidebar does not translate when Invite member to room #30087

Closed

6 tasks

Merge branch 'main' into fix/30272

d581ca2

cubuspl42 approved these changes Nov 16, 2023

View reviewed changes

melvin-bot bot requested a review from bondydaa November 16, 2023 09:29

bondydaa approved these changes Nov 16, 2023

View reviewed changes

bondydaa merged commit e5e1965 into Expensify:main Nov 16, 2023
16 checks passed

This was referenced Nov 20, 2023

fix: 29978 User mention in the system message after inviting member to the room cannot be copied #31169

Closed

[$500] Room - User mention in the system message after inviting member to the room cannot be copied #29978

Closed

os-botify bot mentioned this pull request Nov 20, 2023

Deploy Checklist: New Expensify 2023-11-20 #31556

Closed

90 tasks

lanitochka17 mentioned this pull request Nov 20, 2023

[HOLD for payment 2023-12-29] [$500] Room - In admin room, when copy to clipboard, the room name is not shown as link #31568

Closed

6 tasks

melvin-bot bot mentioned this pull request Nov 22, 2023

[HOLD for payment 2023-11-29] [$500] The email addresses of mentioned users in the "Invited" message are not copied along with the message #30272

Closed

6 tasks

shubham1206agra reviewed Jan 3, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix copy invite room message #30898

Fix copy invite room message #30898

dukenv0307 commented Nov 6, 2023 •

edited by github-actions bot

Loading

melvin-bot bot commented Nov 6, 2023

dukenv0307 commented Nov 7, 2023

cubuspl42 Nov 7, 2023

dukenv0307 Nov 7, 2023

dukenv0307 Nov 7, 2023

cubuspl42 Nov 7, 2023

cubuspl42 Nov 7, 2023

cubuspl42 Nov 7, 2023

cubuspl42 commented Nov 7, 2023

dukenv0307 commented Nov 7, 2023

cubuspl42 commented Nov 7, 2023 •

edited

Loading

dukenv0307 commented Nov 8, 2023 •

edited

Loading

cubuspl42 commented Nov 8, 2023 •

edited

Loading

dukenv0307 commented Nov 8, 2023

cubuspl42 commented Nov 9, 2023

dukenv0307 commented Nov 14, 2023 •

edited

Loading

cubuspl42 commented Nov 14, 2023

cubuspl42 commented Nov 15, 2023

dukenv0307 commented Nov 16, 2023

cubuspl42 commented Nov 16, 2023

OSBotify commented Nov 16, 2023

OSBotify commented Nov 22, 2023

shubham1206agra Jan 3, 2024

Fix copy invite room message #30898

Fix copy invite room message #30898

Conversation

dukenv0307 commented Nov 6, 2023 • edited by github-actions bot Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 6, 2023

dukenv0307 commented Nov 7, 2023

cubuspl42 Nov 7, 2023

Choose a reason for hiding this comment

dukenv0307 Nov 7, 2023

Choose a reason for hiding this comment

dukenv0307 Nov 7, 2023

Choose a reason for hiding this comment

cubuspl42 Nov 7, 2023

Choose a reason for hiding this comment

cubuspl42 Nov 7, 2023

Choose a reason for hiding this comment

cubuspl42 Nov 7, 2023

Choose a reason for hiding this comment

cubuspl42 commented Nov 7, 2023

dukenv0307 commented Nov 7, 2023

cubuspl42 commented Nov 7, 2023 • edited Loading

dukenv0307 commented Nov 8, 2023 • edited Loading

cubuspl42 commented Nov 8, 2023 • edited Loading

dukenv0307 commented Nov 8, 2023

cubuspl42 commented Nov 9, 2023

dukenv0307 commented Nov 14, 2023 • edited Loading

cubuspl42 commented Nov 14, 2023

cubuspl42 commented Nov 15, 2023

Reviewer Checklist

Screenshots/Videos

dukenv0307 commented Nov 16, 2023

cubuspl42 commented Nov 16, 2023

OSBotify commented Nov 16, 2023

OSBotify commented Nov 22, 2023

shubham1206agra Jan 3, 2024

Choose a reason for hiding this comment

dukenv0307 commented Nov 6, 2023 •

edited by github-actions bot

Loading

cubuspl42 commented Nov 7, 2023 •

edited

Loading

dukenv0307 commented Nov 8, 2023 •

edited

Loading

cubuspl42 commented Nov 8, 2023 •

edited

Loading

dukenv0307 commented Nov 14, 2023 •

edited

Loading