Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new template for requesting a library to be added in package.json #31035

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Nov 7, 2023

Fixed Issues

Part of https://github.com/Expensify/Expensify/issues/334255

Tests

None

Offline tests

None

QA Steps

None

PR Author Checklist

No checklist required for this change since it's only adding a GH issue template

@tgolen tgolen self-assigned this Nov 7, 2023
@tgolen tgolen requested a review from a team as a code owner November 7, 2023 21:41
@tgolen
Copy link
Contributor Author

tgolen commented Nov 7, 2023

cc @AndrewGable @mountiny

@melvin-bot melvin-bot bot requested review from grgia and removed request for a team November 7, 2023 21:41
Copy link

melvin-bot bot commented Nov 7, 2023

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor

mountiny commented Nov 8, 2023

Copy looks good to me, @grgia all yours!

@tgolen
Copy link
Contributor Author

tgolen commented Nov 9, 2023

The tests will fail on this PR due to not having any checklists. This is OK to bypass and merge since the changes do not change any code.

@tgolen
Copy link
Contributor Author

tgolen commented Nov 9, 2023

bump @grgia for review please

@grgia grgia merged commit c3692a7 into main Nov 9, 2023
6 of 8 checks passed
@grgia grgia deleted the tgolen-library-review-template branch November 9, 2023 17:32
@melvin-bot melvin-bot bot added the Emergency label Nov 9, 2023
Copy link

melvin-bot bot commented Nov 9, 2023

@grgia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@grgia grgia removed the Emergency label Nov 9, 2023
@grgia
Copy link
Contributor

grgia commented Nov 9, 2023

#31035 (comment) ^

@OSBotify
Copy link
Contributor

OSBotify commented Nov 9, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.98-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.98-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.99-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants