Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change IOUBadge color depending on which user owes money #3105

Merged
merged 1 commit into from
May 25, 2021
Merged

Change IOUBadge color depending on which user owes money #3105

merged 1 commit into from
May 25, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented May 25, 2021

@Julesssss will you please review this?

Details

This PR updates the IOUBadge color to be red if the user owes money and green if they are owed money.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/154518

Tests/QA

  1. Sign in with 2 different users on 2 different platforms
  2. Have User A request money from User B, confirm that an IOU badge shows up
  3. Confirm the badge for User A is green and the badge for User B is red
  4. Confirm the badge color is correct in both the header and the option list
  5. Have User B request money from User A so that User A owes User B, confirm the badge colors switch

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

Desktop

image

iOS

Android

@Jag96 Jag96 requested a review from Julesssss May 25, 2021 01:43
@Jag96 Jag96 self-assigned this May 25, 2021
@Jag96 Jag96 requested a review from a team as a code owner May 25, 2021 01:43
@MelvinBot MelvinBot requested review from nickmurray47 and removed request for a team May 25, 2021 01:43
@Julesssss
Copy link
Contributor

All yours @nickmurray47

nickmurray47
nickmurray47 approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@nickmurray47 nickmurray47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@nickmurray47 nickmurray47 merged commit 5dcfe0d into main May 25, 2021
@nickmurray47 nickmurray47 deleted the joe-iou-badge-colors branch May 25, 2021 16:59
@OSBotify OSBotify mentioned this pull request May 25, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julesssss Julesssss Julesssss approved these changes

@nickmurray47 nickmurray47 nickmurray47 approved these changes

Assignees

@Jag96 Jag96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jag96 @Julesssss @nickmurray47