-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade expensify-common #3106
Upgrade expensify-common #3106
Conversation
"react-native-modal": "^11.10.0", | ||
"react-native-onyx": "git+https://github.com/Expensify/react-native-onyx.git#d0a5d12c08f2f029e3038fb3516a93a9403e9746", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLARIFICATION: The version here wasn't changed (the commit hashes are the same), npm install
simply changed the location of this when I ran it (I guess it sorted everything alphabetically).
@Luke9389 I self-reviewed just to clarify some stuff, this should be good for a quick review from you, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, simple version bump 👍
@@ -59,7 +59,7 @@ | |||
"electron-log": "^4.2.4", | |||
"electron-serve": "^1.0.0", | |||
"electron-updater": "^4.3.4", | |||
"expensify-common": "git+https://github.com/Expensify/expensify-common.git#2e5cff552cf132da90a3fb9756e6b4fb6ae7b40c", | |||
"expensify-common": "^1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to revert this. Sorry @jasperhuangg the SO instructions you followed are outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @marcaaron, can you add context on why this is being reverted? Just curious to see what broke.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't be publishing expensify-common
to npm. The advice in the SO is outdated (my bad). We must reference the commit hash instead like we have been doing for every other expensify-common
update.
Details
Made some changes to ExpensiMark that were recently merged and deployed to npm, so this PR upgrades expensify-common so we can have those new changes.
If you're confused as to why the package.json isn't using the commit hash anymore, it's because I followed these steps (which I think use the major/minor version): https://stackoverflow.com/c/expensify/questions/7216
Fixed Issues
N/A, but here's the expensify-common PR: Expensify/expensify-common#376
Tests
Same as QA
QA Steps
Try to send this as a message in any chat, and verify it renders the same as the screenshot:
Tested On
Screenshots
Web
2021-05-24_19-20-04.mp4
Mobile Web
2021-05-24_19-42-48.mp4
iOS
2021-05-24_19-40-34.mp4
Android
1621913590738637.mp4
Desktop
2021-05-24_19-23-36.mp4