Flip TU constants for QA #31094

marcochavezf · 2023-11-09T01:50:41Z

~~On hold for https://github.com/Expensify/Web-Expensify/pull/39601~~

Details

This PR flips the TU constants (policyID and public room reportID) in the clientside when the environment is not production.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/334697

Tests

Navigate to Save The World > I know a teacher, fill in the form, and verify the teacher is invited (a whisper message appears in the public room).
As the teacher navigate to Save The World > I'm a teacher, fill in the form and verify a workspace is created for the teacher.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

referTeachersUniteVolunteer and addSchoolPrincipal functions

IntroSchoolPrincipalPage

instead of environment

whitespace

marcochavezf · 2023-11-09T02:00:08Z

src/pages/TeachersUnite/SaveTheWorldPage.js

-                    onPress={() => Navigation.navigate(ROUTES.I_AM_A_TEACHER)}
-                />
-            )}
+            <MenuItem


I removed this condition to allow the teacher to enter again the principal email in case they entered the email incorrectly

melvin-bot · 2023-11-09T02:02:49Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

marcochavezf · 2023-11-09T02:04:04Z

On hold for backend changes, but the code changes are ready for review.

mollfpr

It mostly looks good, but I'll look more profound with my laptop.

mollfpr

Looks good, left a few suggestions.

src/pages/TeachersUnite/SaveTheWorldPage.js

mollfpr · 2023-11-09T15:12:33Z

src/pages/TeachersUnite/KnowATeacherPage.js

@@ -51,7 +53,9 @@ function KnowATeacherPage(props) {
        const firstName = values.firstName.trim();
        const lastName = values.lastName.trim();

-        TeachersUnite.referTeachersUniteVolunteer(contactMethod, firstName, lastName);
+        const policyID = isProduction ? CONST.TEACHERS_UNITE.PROD_POLICY_ID : CONST.TEACHERS_UNITE.TEST_POLICY_ID;
+        const publicRoomReportID = isProduction ? CONST.TEACHERS_UNITE.PROD_PUBLIC_ROOM_ID : CONST.TEACHERS_UNITE.TEST_PUBLIC_ROOM_ID;


I think we can create a hook to return the teachers' unite policyID and publicRoomID based on the environment.

This constants will be only used in these two places, so I think it's not necessary to move it to a hook atm

marcochavezf · 2024-01-04T20:50:32Z

Hi @mollfpr! 👋🏽 The backend changes were deployed to production, and this PR is ready for review. You should be redirected to the testing public room and the testing policy when a teacher is referred or signed up.

mollfpr · 2024-01-06T10:11:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

31094.Android.-.Member.mp4

31094.Android.-.Teacher.mp4

Android: mWeb Chrome

31094.mWeb-Chrome.-.Member.mp4

31094.mWeb-Chrome.-.Teacher.mp4

iOS: Native

31094.iOS.-.Member.mp4

31094.iOS.-.Teacher.mp4

iOS: mWeb Safari

31094.mWeb-Safari.-.Member.mp4

31094.mWeb-Safari.-.Teacher.mp4

MacOS: Chrome / Safari

31094.Web.-.Teacher.mp4

31094.Web.-.Member.mp4

MacOS: Desktop

31094.Desktop.-.Member.mp4

31094.Desktop.-.Teacher.mp4

mollfpr

LGTM and tests well 👍

@marcochavezf I think you need to update the checklist with the latest. There's a new checklists.

If the PR modifies the form input styles:
I verified that all the inputs inside a form are aligned with each other.
I added Design label so the design team can review the changes.

melvin-bot · 2024-01-06T10:23:17Z

@francoisl Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-01-06T10:23:21Z

🎯 @mollfpr, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #34074.

OSBotify · 2024-01-08T19:04:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-09T05:35:39Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.23-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-10T06:02:54Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.23-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

marcochavezf added 8 commits November 8, 2023 18:18

Update TEACHERS_UNITE constants

671cd2d

Add policyID and publicRoomReportID parameters to

3f45a72

referTeachersUniteVolunteer and addSchoolPrincipal functions

Add useEnvironment hook to

e266572

IntroSchoolPrincipalPage

Add useEnvironment hook to KnowATeacherPage

0903d8f

Show "I'm a teacher" button always

30f0fcc

Remove unused imports from SaveTheWorldPage.js

880a00a

Refactor environment variable to isProduction in

8c9a587

IntroSchoolPrincipalPage

Refactor useEnvironment hook to use isProduction

1fb005d

instead of environment

marcochavezf self-assigned this Nov 9, 2023

Fix import statement and remove unnecessary

5ff73dc

whitespace

marcochavezf commented Nov 9, 2023

View reviewed changes

marcochavezf marked this pull request as ready for review November 9, 2023 02:02

marcochavezf requested a review from a team as a code owner November 9, 2023 02:02

melvin-bot bot requested review from mollfpr and removed request for a team November 9, 2023 02:02

mollfpr reviewed Nov 9, 2023

View reviewed changes

eh2077 mentioned this pull request Nov 10, 2023

Feat: drop user to last chat after leaving a room #31097

Merged

50 tasks

marcochavezf added 5 commits December 22, 2023 17:35

Merge branch 'main' into marco-flipTUConstants

9978397

Use the global reportID as optimistic reportID for the TU room

072c07d

Change param to reportID

6da2729

Merge branch 'main' into marco-flipTUConstants

789edde

Pass policyID to check if we're using test TU policyID

47e8c87

marcochavezf changed the title ~~[HOLD] Flip TU constants for QA~~ Flip TU constants for QA Jan 4, 2024

marcochavezf requested a review from mollfpr January 4, 2024 20:48

mollfpr approved these changes Jan 6, 2024

View reviewed changes

melvin-bot bot requested a review from francoisl January 6, 2024 10:23

melvin-bot bot mentioned this pull request Jan 6, 2024

Payment issue for E/App PR#31094 #34074

Closed

francoisl approved these changes Jan 8, 2024

View reviewed changes

francoisl merged commit aed717d into main Jan 8, 2024
18 of 19 checks passed

francoisl deleted the marco-flipTUConstants branch January 8, 2024 19:00

github-actions bot mentioned this pull request Jan 9, 2024

Deploy Checklist: New Expensify 2024-01-09 #34121

Closed

87 tasks

VickyStash mentioned this pull request Jan 10, 2024

[TS migration] Migrate '[Remaining Group 2]' lib to TypeScript #32164

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flip TU constants for QA #31094

Flip TU constants for QA #31094

marcochavezf commented Nov 9, 2023 •

edited

Loading

marcochavezf Nov 9, 2023

melvin-bot bot commented Nov 9, 2023

marcochavezf commented Nov 9, 2023

mollfpr left a comment

mollfpr left a comment

mollfpr Nov 9, 2023

marcochavezf Jan 4, 2024

marcochavezf commented Jan 4, 2024

mollfpr commented Jan 6, 2024 •

edited

Loading

mollfpr left a comment

melvin-bot bot commented Jan 6, 2024

melvin-bot bot commented Jan 6, 2024

OSBotify commented Jan 8, 2024

OSBotify commented Jan 9, 2024

OSBotify commented Jan 10, 2024

Flip TU constants for QA #31094

Flip TU constants for QA #31094

Conversation

marcochavezf commented Nov 9, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

marcochavezf Nov 9, 2023

Choose a reason for hiding this comment

melvin-bot bot commented Nov 9, 2023

marcochavezf commented Nov 9, 2023

mollfpr left a comment

Choose a reason for hiding this comment

mollfpr left a comment

Choose a reason for hiding this comment

mollfpr Nov 9, 2023

Choose a reason for hiding this comment

marcochavezf Jan 4, 2024

Choose a reason for hiding this comment

marcochavezf commented Jan 4, 2024

mollfpr commented Jan 6, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jan 6, 2024

melvin-bot bot commented Jan 6, 2024

OSBotify commented Jan 8, 2024

OSBotify commented Jan 9, 2024

OSBotify commented Jan 10, 2024

marcochavezf commented Nov 9, 2023 •

edited

Loading

mollfpr commented Jan 6, 2024 •

edited

Loading