Build optimistic custom unit when creating workspace #31170

dukenv0307 · 2023-11-10T09:00:23Z

Details

Build optimistic custom unit when creating workspace

Fixed Issues

$ #30801
PROPOSAL: #30801 (comment)

Tests

Go offline
Create a new workspace
Go to policy expense chat of the workspace
Create a distance request
Select the start and finish address to go to the confirm page
Verify that the default currency displays in the Distance row instead of undefined

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Go offline
Create a new workspace
Go to policy expense chat of the workspace
Create a distance request
Select the start and finish address to go to the confirm page
Verify that the default currency displays in the Distance row instead of undefined

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-10.at.16.21.55.mov

Android: mWeb Chrome

Screen.Recording.2023-11-10.at.16.08.29.mov

iOS: Native

Screen.Recording.2023-11-10.at.16.16.27.mov

iOS: mWeb Safari

Screen.Recording.2023-11-10.at.16.04.19.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-10.at.15.56.12.mov

MacOS: Desktop

Screen.Recording.2023-11-10.at.16.26.59.mov

melvin-bot · 2023-11-10T09:31:22Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eVoloshchak · 2023-11-13T11:47:44Z

src/libs/actions/Policy.js

@@ -1130,7 +1133,8 @@ function createDraftInitialWorkspace(policyOwnerEmail = '', policyName = '', pol
 function createWorkspace(policyOwnerEmail = '', makeMeAdmin = false, policyName = '', policyID = generatePolicyID()) {
    const workspaceName = policyName || generateDefaultWorkspaceName(policyOwnerEmail);

-    const {customUnits, customUnitID, customUnitRateID} = buildOptimisticCustomUnits();
+    const outputCurrency = lodashGet(allPersonalDetails, [sessionAccountID, 'localCurrencyCode'], CONST.CURRENCY.USD);


We use the same line twice

const outputCurrency = lodashGet(allPersonalDetails, [sessionAccountID, 'localCurrencyCode'], CONST.CURRENCY.USD);

Can we move it to buildOptimisticCustomUnits? And for both cases (createWorkspace and createDraftInitialWorkspace) access it from customUnits[customUnitID].rates[customUnitRateID].currency

@eVoloshchak I updated.

dukenv0307 · 2023-11-20T03:48:54Z

@eVoloshchak Please help to review again when you have a chance.

src/libs/actions/Policy.js

Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>

dukenv0307 · 2023-11-21T16:44:46Z

@eVoloshchak Updated.

dukenv0307 · 2023-11-27T08:58:58Z

@eVoloshchak Friendly bump.

eVoloshchak · 2023-11-29T14:20:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-29.at.15.13.15.mov

Android: mWeb Chrome

Screen.Recording.2023-11-29.at.15.18.39.mov

iOS: Native

Screen.Recording.2023-11-29.at.15.10.09.mov

iOS: mWeb Safari

Screen.Recording.2023-11-29.at.15.11.38.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-29.at.15.08.51.mov

MacOS: Desktop

Screen.Recording.2023-11-29.at.15.23.02.mov

eVoloshchak

LGTM

robertjchen

Looks great, thanks!

OSBotify · 2023-12-03T17:42:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-05T02:55:26Z

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 1.4.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-12-05T13:40:31Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 1.4.8-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T20:30:36Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-06T20:40:08Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 added 5 commits November 6, 2023 17:47

fix: 30801

8b91fa4

build optimistic custom unit when create workspace

a567b1c

Merge branch 'main' into fix/30801

021fd60

fix test

e5fb0a1

fix lint

87c7e12

dukenv0307 marked this pull request as ready for review November 10, 2023 09:31

dukenv0307 requested a review from a team as a code owner November 10, 2023 09:31

melvin-bot bot requested review from eVoloshchak and removed request for a team November 10, 2023 09:31

dukenv0307 added 3 commits November 10, 2023 16:54

fix test

2b581aa

fix lint

697adae

Merge branch 'main' into fix/30801

5fd04b5

eVoloshchak reviewed Nov 13, 2023

View reviewed changes

dukenv0307 added 2 commits November 14, 2023 12:01

Merge branch 'main' into fix/30801

7d05976

move output currency

17f7b49

eVoloshchak reviewed Nov 21, 2023

View reviewed changes

src/libs/actions/Policy.js Outdated Show resolved Hide resolved

Update src/libs/actions/Policy.js

34ecf98

Co-authored-by: Eugene Voloshchak <copyreading@gmail.com>

eVoloshchak approved these changes Nov 29, 2023

View reviewed changes

melvin-bot bot requested a review from robertjchen November 29, 2023 14:26

robertjchen approved these changes Dec 3, 2023

View reviewed changes

robertjchen merged commit cc4add5 into Expensify:main Dec 3, 2023
16 checks passed

github-actions bot mentioned this pull request Dec 5, 2023

Deploy Checklist: New Expensify 2023-12-05 #32463

Closed

66 tasks

eVoloshchak mentioned this pull request Dec 8, 2023

[Payment due][$500] Distance - Distance rate shows undefined when both workspace and request are created offline #30801

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build optimistic custom unit when creating workspace #31170

Build optimistic custom unit when creating workspace #31170

dukenv0307 commented Nov 10, 2023 •

edited

Loading

melvin-bot bot commented Nov 10, 2023

eVoloshchak Nov 13, 2023

dukenv0307 Nov 14, 2023

dukenv0307 commented Nov 20, 2023

dukenv0307 commented Nov 21, 2023

dukenv0307 commented Nov 27, 2023

eVoloshchak commented Nov 29, 2023 •

edited

Loading

eVoloshchak left a comment

robertjchen left a comment

OSBotify commented Dec 3, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

Build optimistic custom unit when creating workspace #31170

Build optimistic custom unit when creating workspace #31170

Conversation

dukenv0307 commented Nov 10, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 10, 2023

eVoloshchak Nov 13, 2023

Choose a reason for hiding this comment

dukenv0307 Nov 14, 2023

Choose a reason for hiding this comment

dukenv0307 commented Nov 20, 2023

dukenv0307 commented Nov 21, 2023

dukenv0307 commented Nov 27, 2023

eVoloshchak commented Nov 29, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

robertjchen left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 3, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 5, 2023

OSBotify commented Dec 6, 2023

OSBotify commented Dec 6, 2023

dukenv0307 commented Nov 10, 2023 •

edited

Loading

eVoloshchak commented Nov 29, 2023 •

edited

Loading