[CP Staging] Fix/issue 31069 #31184

s-alves10 · 2023-11-10T13:14:40Z

Details

Fixed Issues

$ #31069
PROPOSAL: #31069 (comment)

Tests

Open ND and log in with account A and account B on two devices
Account B: Send a money request to account A
Account A: Go to chat with account B
Account A: Tap the down arrow button in IOU card
Verify that the popover is positioned correctly above the pay button
Account B: Send any message to account A
Hover or right click the message and select emoji button
Verify that EmojiPicker is positioned correct
React with any emoji
Tap the emoji bubble button in the reaction bar below the message
Verify that EmojiPicker is positioned properly
Verify that EmojiPicker is positioned properly for emoji buttons in the main composer and edit composer

Verify that no errors appear in the JS console

Offline tests

Open ND and log in with account A and account B on two devices
Account B: Send a money request to account A
Account A: Go to chat with account B and go to offline
Account A: Tap the down arrow button in IOU card
Verify that the popover is positioned correctly above the pay button
Account B: Send any message to account A
Hover or right click the message and select emoji button
Verify that EmojiPicker is positioned correct
React with any emoji
Tap the emoji bubble button in the reaction bar below the message
Verify that EmojiPicker is positioned properly
Verify that EmojiPicker is positioned properly for emoji buttons in the main composer and edit composer

QA Steps

Open ND and log in with account A and account B on two devices
Account B: Send a money request to account A
Account A: Go to chat with account B
Account A: Tap the down arrow button in IOU card
Verify that the popover is positioned correctly above the pay button
Account B: Send any message to account A
Hover or right click the message and select emoji button
Verify that EmojiPicker is positioned correct
React with any emoji
Tap the emoji bubble button in the reaction bar below the message
Verify that EmojiPicker is positioned properly
Verify that EmojiPicker is positioned properly for emoji buttons in the main composer and edit composer

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

31069_android_native.mp4

Android: mWeb Chrome

31069_android_chrome.mp4

iOS: Native

31069_ios_native.mp4

iOS: mWeb Safari

31069_ios_safari.mp4

MacOS: Chrome / Safari

31069_mac_safari.mp4

MacOS: Desktop

31069_mac_desktop.mp4

melvin-bot · 2023-11-10T13:23:12Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

getusha · 2023-11-10T13:23:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

situchan

BUG: cannot open emoji picker first time

emoji.picker.mov

getusha · 2023-11-10T13:33:28Z

Lets remove this code @s-alves10 i think it'll fix the ^ issue @situchan mentioned

if (!anchorLocationVertical) {
     break;
}

s-alves10 · 2023-11-10T13:43:11Z

@situchan @getusha

Will you take a look again?

situchan · 2023-11-10T13:44:10Z

yes works now. testing other platforms for safety

getusha

Looks good!

src/components/PopoverWithMeasuredContent.js

situchan · 2023-11-10T13:53:19Z

@mountiny I thought we temporarily applied workaround to fix performance tests failing?

situchan

Tests well! @mountiny all yours!

mountiny · 2023-11-10T13:58:21Z

@s-alves10 can you also merge in main, the reassure tests should be fixed there

s-alves10 · 2023-11-10T14:00:44Z

@mountiny

I think I am not allowed to merge. I have no permissions

mountiny · 2023-11-10T14:01:12Z

I menat to sync up this branch with main :D but all good it passed this time

mountiny

Thanks!

OSBotify · 2023-11-10T14:08:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[CP Staging] Fix/issue 31069 (cherry picked from commit a6629d4)

OSBotify · 2023-11-10T14:48:32Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-11-10T15:42:18Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-14T22:11:51Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-15T20:55:07Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.99-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

sangar-1028 added 2 commits November 10, 2023 05:43

fix: RNW patch for measureInWindow

1f07068

fix: remove shouldUseTargetLocation from PopoverWithMeasuredContent

5e9f3df

s-alves10 marked this pull request as ready for review November 10, 2023 13:23

s-alves10 requested a review from a team as a code owner November 10, 2023 13:23

melvin-bot bot requested review from getusha and removed request for a team November 10, 2023 13:23

s-alves10 mentioned this pull request Nov 10, 2023

[HOLD for payment 2023-11-21] [$500] Wrong position of payment method dropdown menu #31069

Closed

6 tasks

mountiny changed the title ~~Fix/issue 31069~~ [CP Staging] Fix/issue 31069 Nov 10, 2023

mountiny assigned s-alves10 Nov 10, 2023

situchan suggested changes Nov 10, 2023

View reviewed changes

fix: emoji picker not open first time

a75ce3e

getusha approved these changes Nov 10, 2023

View reviewed changes

melvin-bot bot requested a review from mountiny November 10, 2023 13:49

situchan reviewed Nov 10, 2023

View reviewed changes

src/components/PopoverWithMeasuredContent.js Outdated Show resolved Hide resolved

fix: remove unnecessary variable

6bf03f2

situchan approved these changes Nov 10, 2023

View reviewed changes

mountiny approved these changes Nov 10, 2023

View reviewed changes

mountiny merged commit a6629d4 into Expensify:main Nov 10, 2023
15 checks passed

OSBotify pushed a commit that referenced this pull request Nov 10, 2023

Merge pull request #31184 from s-alves10/fix/issue-31069

c83ee6d

[CP Staging] Fix/issue 31069 (cherry picked from commit a6629d4)

OSBotify mentioned this pull request Nov 10, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

OSBotify mentioned this pull request Nov 14, 2023

Deploy Checklist: New Expensify 2023-11-14 #31324

Closed

Beamanator mentioned this pull request Dec 6, 2023

Tracker to follow up with react-native-web patches #32544

Closed

s-alves10 deleted the fix/issue-31069 branch December 21, 2023 07:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix/issue 31069 #31184

[CP Staging] Fix/issue 31069 #31184

s-alves10 commented Nov 10, 2023

melvin-bot bot commented Nov 10, 2023

getusha commented Nov 10, 2023 •

edited

Loading

situchan left a comment

getusha commented Nov 10, 2023 •

edited

Loading

s-alves10 commented Nov 10, 2023

situchan commented Nov 10, 2023

getusha left a comment

situchan commented Nov 10, 2023

situchan left a comment

mountiny commented Nov 10, 2023

s-alves10 commented Nov 10, 2023 •

edited

Loading

mountiny commented Nov 10, 2023

mountiny left a comment

OSBotify commented Nov 10, 2023

OSBotify commented Nov 10, 2023

OSBotify commented Nov 10, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 15, 2023

[CP Staging] Fix/issue 31069 #31184

[CP Staging] Fix/issue 31069 #31184

Conversation

s-alves10 commented Nov 10, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 10, 2023

getusha commented Nov 10, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

getusha commented Nov 10, 2023 • edited Loading

s-alves10 commented Nov 10, 2023

situchan commented Nov 10, 2023

getusha left a comment

Choose a reason for hiding this comment

situchan commented Nov 10, 2023

situchan left a comment

Choose a reason for hiding this comment

mountiny commented Nov 10, 2023

s-alves10 commented Nov 10, 2023 • edited Loading

mountiny commented Nov 10, 2023

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 10, 2023

OSBotify commented Nov 10, 2023

OSBotify commented Nov 10, 2023

OSBotify commented Nov 14, 2023

OSBotify commented Nov 15, 2023

getusha commented Nov 10, 2023 •

edited

Loading

getusha commented Nov 10, 2023 •

edited

Loading

s-alves10 commented Nov 10, 2023 •

edited

Loading