Fix scrolling down on edit composer scroll up the page #31271

bernhardoj · 2023-11-13T17:01:52Z

Details

When we do scroll inside an edit composer, the page scroll will be in reverse.

Fixed Issues

$ #30987
PROPOSAL: #30987 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Web/Desktop

Open any chat
Send a >8 lines of message
Press Edit on the message
Inside the edit composer, keep scrolling up
Verify the edit composer content is scrolled up and when it reaches the top of input, the page is also scrolled up
Send a long code block that is horizontally scrollable*
Scroll to the right and then scroll up
Verify the page is scrolled up

NOTE: scroll using a mouse wheel or laptop touch pad.
*example:

```put a long code block here in one line```

Android/iOS/mWeb

Open any chat
Send a >8 lines of message
Press Edit on the message
Verify the scrolling inside the edit composer works just fine
Send a long code block that is horizontally scrollable
Verify you can scroll horizontally the code block just fine

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-14.at.00.46.00.mov

Android: mWeb Chrome

Screen.Recording.2023-11-14.at.00.49.30.mov

iOS: Native

Screen.Recording.2023-11-14.at.00.44.34.mov

iOS: mWeb Safari

Screen.Recording.2023-11-14.at.00.47.35.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-14.at.00.42.59.mov

MacOS: Desktop

Screen.Recording.2023-11-14.at.00.43.50.mov

melvin-bot · 2023-11-13T17:01:57Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2023-11-13T17:02:44Z

src/components/HTMLEngineProvider/HTMLRenderers/PreRenderer/index.js

@@ -33,7 +33,6 @@ function PreRenderer(props) {
        const horizontalOverflow = node.scrollWidth > node.offsetWidth;
        if (event.currentTarget === node && horizontalOverflow && !debouncedIsScrollingVertically(event)) {
            node.scrollLeft += event.deltaX;
-            event.stopPropagation();


Just realized that this issue also happens with a code block. To reproduce it, scroll the code block horizontally and then vertically. The vertical scroll will be in reverse.

akinwale · 2023-11-16T08:12:11Z

Been having issues with Android mWeb testing on the simulator. I will complete the review today.

akinwale · 2023-11-16T16:17:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

31271-web.mp4

MacOS: Desktop

31271-desktop.mp4

akinwale

LGTM.

Tests well.

OSBotify · 2023-11-17T16:52:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-22T00:50:18Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.1-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix scrolling is reversed

7902028

bernhardoj requested a review from a team as a code owner November 13, 2023 17:01

melvin-bot bot removed the request for review from a team November 13, 2023 17:01

melvin-bot bot requested a review from akinwale November 13, 2023 17:01

bernhardoj commented Nov 13, 2023

View reviewed changes

remove unused return

0fd9f79

akinwale approved these changes Nov 17, 2023

View reviewed changes

melvin-bot bot requested a review from tgolen November 17, 2023 06:01

tgolen approved these changes Nov 17, 2023

View reviewed changes

tgolen merged commit 0a8ba58 into Expensify:main Nov 17, 2023
13 checks passed

os-botify bot mentioned this pull request Nov 20, 2023

Deploy Checklist: New Expensify 2023-11-20 #31556

Closed

90 tasks

izarutskaya mentioned this pull request Nov 21, 2023

[$500] Chat - Chat view jerks when opening multline text in edit mode and scrolling up #31609

Closed

6 tasks

akinwale mentioned this pull request Dec 6, 2023

[$500] Chat - Scrolling down on edit composer with multi lines scrolls up the chat history #30987

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix scrolling down on edit composer scroll up the page #31271

Fix scrolling down on edit composer scroll up the page #31271

bernhardoj commented Nov 13, 2023

melvin-bot bot commented Nov 13, 2023

bernhardoj Nov 13, 2023

akinwale commented Nov 16, 2023

akinwale commented Nov 16, 2023 •

edited

Loading

akinwale left a comment

OSBotify commented Nov 17, 2023

OSBotify commented Nov 22, 2023

Fix scrolling down on edit composer scroll up the page #31271

Fix scrolling down on edit composer scroll up the page #31271

Conversation

bernhardoj commented Nov 13, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 13, 2023

bernhardoj Nov 13, 2023

Choose a reason for hiding this comment

akinwale commented Nov 16, 2023

akinwale commented Nov 16, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

akinwale left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 17, 2023

OSBotify commented Nov 22, 2023

akinwale commented Nov 16, 2023 •

edited

Loading